search for: path_entry

On Wed, 12 Jun, at 11:17:44AM, Gerardo Exequiel Pozzi wrote: > Cool thanks!. Now looks better, but still not work. > > For some reason, "ldlinux.c32" is apparently sent but "Failed to load" > by PXELINUX and few seconds later, dnsmasq shows an error message > "failed sending": Argh! The patch was broken. I missed the new core/path.c file. My bad.

...6 +770,39 @@ extern void loadkeys(char *); extern char syslinux_banner[]; extern char copyright_str[]; +/* + * PATH-based lookup + * + * Each entry in the PATH directive is separated by a space, e.g. + * + * PATH /bar /bin/foo /baz/bar/bin + */ +static int parse_path(char *p) +{ + struct path_entry *entry; + const char *str; + + while (*p) { + /* Find the next directory */ + str = refdup_word(&p); + if (!str) + goto bail; + + entry = path_add(str); + refstr_put(str); + + if (!entry) + goto bail; + + p = skipspace(p); + } + + return 0; + +bail: + return -1; +} + sta...

...6 +770,39 @@ extern void loadkeys(char *); extern char syslinux_banner[]; extern char copyright_str[]; +/* + * PATH-based lookup + * + * Each entry in the PATH directive is separated by a space, e.g. + * + * PATH /bar /bin/foo /baz/bar/bin + */ +static int parse_path(char *p) +{ + struct path_entry *entry; + const char *str; + + while (*p) { + /* Find the next directory */ + str = refdup_word(&p); + if (!str) + goto bail; + + entry = path_add(str); + refstr_put(str); + + if (!entry) + goto bail; + + p = skipspace(p); + } + + return 0; + +bail: + return -1; +} + sta...

On Mon, 10 Jun, at 07:57:50AM, H. Peter Anvin wrote: > Either that or make the path a list rather than a string, using the > normal word separators when entered on the command line, a bit like the > (t)csh does. That is a bigger change but is probably a better solution. How would this solution handle filenames containing spaces? Would we need to escape (presumably with a backslash)

...inux_banner[]; > extern char copyright_str[]; > > +/* > + * PATH-based lookup > + * > + * Each entry in the PATH directive is separated by a space, e.g. > + * > + * PATH /bar /bin/foo /baz/bar/bin > + */ > +static int parse_path(char *p) > +{ > + struct path_entry *entry; > + const char *str; > + > + while (*p) { > + /* Find the next directory */ > + str = refdup_word(&p); > + if (!str) > + goto bail; > + > + entry = path_add(str); > + refstr_put(str); > + > + if (!entry) > + goto bail; > + > + p...

...beginning of the list. This fixes an issue where PATH with multiple directories listed would effectively reverse the order of the searched directories diff --git a/core/path.c b/core/path.c index 8e517ca..7b4d886 100644 --- a/core/path.c +++ b/core/path.c @@ -32,7 +32,7 @@ __export struct path_entry *path_add(const char *str) if (!entry->str) goto bail; - list_add(&entry->list, &PATH); + list_add_tail(&entry->list, &PATH); return entry; -- Philip Pokorny, RHCE Chief Technology Officer PENGUIN COMPUTING, Inc www.penguincomputing.com Changi...

...in core/include/fs.h? Next, path_add() adds new entries at the beginning of the list not the end. This causes directories to be search last first not first to last. This should fix that. diff --git a/core/path.c b/core/path.c --- a/core/path.c +++ b/core/path.c @@ -32,7 +32,7 @@ __export struct path_entry *path_add(const char *str) if (!entry->str) goto bail; - list_add(&entry->list, &PATH); + list_add_tail(&entry->list, &PATH); return entry; But that will cause the code that attempts to put the CurrentDirName at the beginning of the list to break...

...missing buttons 32444 Incorrect graphic rendering when using Circuit Wizard 32453 Incorrect Common Control Font Size 32466 KwMusic's config program needs unimplemented function msvcrt.dll._atodbl 32467 Windows Sysinternals "bginfo" tool crashes due to incorrect sysparams PATH_ENTRY macro definition 32468 Windows Sysinternals "PsInfo" tool crashes while trying to retrieve WMI class Win32_WindowsProductActivation data 32469 Conflict: Denied Ops crashes while loading a mission (without native msvcr80) 32486 The Settlers 7 needs msvcr90.dll._aligned_msize 324...

So last week I was wondering if XFS was still working -- even with its last on-disk structure changes -- and it _suprisingly_ worked as expected. Right, now I can finally get rid of GRUB and use Syslinux to boot my Linux on EFI from a rootfs with xfs. Shit, I have two partitions (the first one being the required ESP) so there is no way to access the other partitions since because Syslinux does not