search for: passinstrumentationanalysis

...ere for some time and have hand-added instrumentation to various passes to honor it. It's saved us man-years of debug time. I was planning on sending it upstream but saw this effort with pass execution instrumentation and thought it might fit there. Initially I think some very simple APIs in PassInstrumentationAnalysis would be fine, something like: // PIA - PassInstrumentationAnalysis if (PIA->skipTransformation()) { return; } // Do it. PIA->didTransformation(); This kind of interface also encourages good pass design like doing all the analysis for a transformation before actually doing the transformat...

...gt;>>> >>>> Also, the intent is for execution counters to be able provide >>>> thread-safety in multi-threaded >>>> pipeline execution (though no work planned for it yet). >>>> >>>> 5. introduce a new analysis llvm::PassInstrumentationAnalysis >>>> >>>> This is a convenience wrapper to provide an access to >>>> PassInstrumentation via analysis framework. >>>> If using analysis is not convenient (?legacy) then >>>> PassInstrumentation can be queried >>>>...

...break in presence of fixed-point iteration      passes like RepeatedPass/DevirtSCCRepeatedPass      Also, the intent is for execution counters to be able provide thread-safety in multi-threaded      pipeline execution (though no work planned for it yet).   5. introduce a new analysis llvm::PassInstrumentationAnalysis      This is a convenience wrapper to provide an access to PassInstrumentation via analysis framework.      If using analysis is not convenient (?legacy) then PassInstrumentation can be queried      directly from LLVMContext. Additional goals ================   - layering problem     Cur...

...ot break in presence of fixed-point iteration passes like RepeatedPass/DevirtSCCRepeatedPass Also, the intent is for execution counters to be able provide thread-safety in multi-threaded pipeline execution (though no work planned for it yet). 5. introduce a new analysis llvm::PassInstrumentationAnalysis This is a convenience wrapper to provide an access to PassInstrumentation via analysis framework. If using analysis is not convenient (?legacy) then PassInstrumentation can be queried directly from LLVMContext. Additional goals ================ - layering problem Curre...

...      passes like RepeatedPass/DevirtSCCRepeatedPass > >       Also, the intent is for execution counters to be able provide > thread-safety in multi-threaded >       pipeline execution (though no work planned for it yet). > >    5. introduce a new analysis llvm::PassInstrumentationAnalysis > >       This is a convenience wrapper to provide an access to > PassInstrumentation via analysis framework. >       If using analysis is not convenient (?legacy) then > PassInstrumentation can be queried >       directly from LLVMContext. > > > A...

Fedor Sergeev <fedor.sergeev at azul.com> writes: > On 06/12/2018 12:04 AM, David A. Greene wrote: >> // PIA - PassInstrumentationAnalysis >> if (PIA->skipTransformation()) { >> return; >> } >> // Do it. >> PIA->didTransformation(); > That should be easily doable (though the interface would be part of > PassInstrumentation > rather than PassInstrumentationAnalysis). Ok. The way I envi...