search for: passdb_success

Hi, I'm playing with the new events, and encounter some issues: First the 'auth_request_finished' event is documented as having a 'successful' field, but in the code, the field is defined as 'success' (e->add_str("success", "yes")). But more important, in the function "auth_request_success_continue()" (auth/auth-request.c:288),

...Daniel Dupas via dovecot < <a href="mailto:dovecot@dovecot.org">dovecot@dovecot.org</a>> wrote: </div> <div> <br> </div> <div> <br> </div> <div> An other issue is that when 'request->passdb_success' is FALSE, the request fails but the error field is not set (as it is only set when request->failure is TRUE), which make it hard to create metrics for failed login attempts. </div> <div> <br> </div> <div> We have (assuming success were worki...

An other issue is that when 'request->passdb_success' is FALSE, the request fails but the error field is not set (as it is only set when request->failure is TRUE), which make it hard to create metrics for failed login attempts. We have (assuming success were working as expected): - success = yes -> means auth OK - error is present -> me...