search for: parttype_string

...*) let get_partition_content = let pvs_full = Array.to_list (g#pvs_full ()) in @@ -977,7 +984,10 @@ read the man page virt-resize(1). let last_error = ref "" in let rec initialize_partition_table g attempts = let ok = - try g#part_init "/dev/sdb" parttype_string; true + try + g#part_init "/dev/sdb" parttype_string; + may (g#part_set_disk_guid "/dev/sdb") disk_guid; + true with G.Error error -> last_error := error; false in if ok then g, true else if attempts > 0 then ( -- 1....

Some OSes (e.g. Windows Server 2012 R2) fail to boot after virt-resize due to changed disk guid. To fix it, we add new APIs: part_get_disk_guid part_set_disk_guid part_set_disk_guid_random We also preserve disk GUID in virt-resize. Maxim Perevedentsev (3): New API: part_get_disk_guid and part_set_disk_guid. New API: part_set_disk_guid_random. resize: preserve GPT disk GUID.

...e man page virt-resize(1). (fst infile) insize; if outsize < Int64.of_int max_bootloader then error (f_"%s: file is too small to be a disk image (%Ld bytes)") - outfile outsize; + (fst outfile) outsize; (* Get the source partition type. *) let parttype, parttype_string = @@ -983,7 +993,7 @@ read the man page virt-resize(1). (* Try hard to initialize the partition table. This might involve * relaunching another handle. *) - message (f_"Setting up initial partition table on %s") outfile; + message (f_"Setting up initial partit...

...e man page virt-resize(1). (fst infile) insize; if outsize < Int64.of_int max_bootloader then error (f_"%s: file is too small to be a disk image (%Ld bytes)") - outfile outsize; + (fst outfile) outsize; (* Get the source partition type. *) let parttype, parttype_string = @@ -983,7 +999,7 @@ read the man page virt-resize(1). (* Try hard to initialize the partition table. This might involve * relaunching another handle. *) - message (f_"Setting up initial partition table on %s") outfile; + message (f_"Setting up initial partit...

...e man page virt-resize(1). (fst infile) insize; if outsize < Int64.of_int max_bootloader then error (f_"%s: file is too small to be a disk image (%Ld bytes)") - outfile outsize; + (fst outfile) outsize; (* Get the source partition type. *) let parttype, parttype_string = @@ -983,7 +993,7 @@ read the man page virt-resize(1). (* Try hard to initialize the partition table. This might involve * relaunching another handle. *) - message (f_"Setting up initial partition table on %s") outfile; + message (f_"Setting up initial partit...

...(* Main disk with the built image. *) diff --git a/resize/resize.ml b/resize/resize.ml index 4eeb0a170..837c3ce9e 100644 --- a/resize/resize.ml +++ b/resize/resize.ml @@ -1005,7 +1005,7 @@ read the man page virt-resize(1). let ok = try g#part_init "/dev/sdb" parttype_string; - may (g#part_set_disk_guid "/dev/sdb") disk_guid; + Option.may (g#part_set_disk_guid "/dev/sdb") disk_guid; true with G.Error error -> last_error := error; false in if ok then g, true @@ -1195,8 +1195,8 @@ read the man page virt-...

Some simple refactoring of virt-resize. I originally had the idea that we could turn virt-resize into a library (cf. virt-customize) and use it from virt-builder, but I now don't think that would make any meaningful difference. In particular we'd still have to open the handle the same number of times. These two patches are left over from my work on that. Rich.

...- ); + debug "%s size %Ld bytes" (fst infile) insize; + debug "%s size %Ld bytes" outfile outsize; sectsize, insize, outsize in let max_bootloader = @@ -398,7 +396,7 @@ read the man page virt-resize(1). (* Get the source partition type. *) let parttype, parttype_string = let pt = g#part_get_parttype "/dev/sda" in - if verbose () then printf "partition table type: %s\n%!" pt; + debug "partition table type: %s" pt; match pt with | "msdos" -> MBR, "msdos" @@ -753,9 +751,8 @@ read the man pag...

Add a Common_utils.debug function for printing messages only when in verbose mode. Rich.

In Std_utils we already extend Char and String. These commits take it a little further by extending List and adding a new Option submodule. All basically simple refactoring. Rich.

This time including the first commit ...

...in - if verbose then ( + if verbose () then ( printf "%s size %Ld bytes\n" (fst infile) insize; printf "%s size %Ld bytes\n" outfile outsize ); @@ -416,7 +412,7 @@ read the man page virt-resize(1). (* Get the source partition type. *) let parttype, parttype_string = let pt = g#part_get_parttype "/dev/sda" in - if verbose then printf "partition table type: %s\n%!" pt; + if verbose () then printf "partition table type: %s\n%!" pt; match pt with | "msdos" -> MBR, "msdos" @@ -543,7 +539,...

Version 1 of the patch, for discussion, but not to be applied. It does work, but needs a lot more testing. This removes all the psychopathic gettextify cruft, and replaces it with a 99 line Makefile.am. A large win, I think. The third patch implements gettext support in the OCaml tools. The fourth patch is just for illustration. It shows the consequent changes to libguestfs.pot and the po

.. and a lot of refactoring. https://bugzilla.redhat.com/show_bug.cgi?id=1167623 Rich.

https://bugzilla.redhat.com/show_bug.cgi?id=1167623