search for: partitioning2

...' command not available" > - exit 77 > -fi > + > +rm -f ip.pid ipv4.out ipv6.out > +cleanup_fn rm -f ip.pid ipv4.out ipv6.out ...but the rewrite does not. Could be solved with: requires qemu-img info --image-opts driver=file,filename=functions.sh > +++ b/tests/test-partitioning2.sh > @@ -40,16 +40,12 @@ source ./functions.sh > set -e > set -x > > +requires mke2fs -V > + > files="partitioning2.pid partitioning2.sock partitioning2.fs partitioning2.p1 partitioning2.p3" > rm -f $files > cleanup_fn rm -f $files > > -# Test tha...

...ut the rewrite does not. Could be solved with: > > requires qemu-img info --image-opts driver=file,filename=functions.sh Yes - as you can see I didn't convert the old test, it's still there. However I will try your variation to see if that works instead. > > +++ b/tests/test-partitioning2.sh > > @@ -40,16 +40,12 @@ source ./functions.sh > > set -e > > set -x > > > > +requires mke2fs -V > > + > > files="partitioning2.pid partitioning2.sock partitioning2.fs partitioning2.p1 partitioning2.p3" > > rm -f $files > > cl...

v1 was here: https://www.redhat.com/archives/libguestfs/2019-January/thread.html#00198 For v2 I changed most existing prerequisite tests to use the new mechanism. I only changed simple tests. There are a few more complex tests that don't fit the “requires model” and those are not changed. I normalized qemu-io/qemu-img testing to always use the --version flag, where previously we used a mix

...kit-partitioning-plugin.pod | 118 +++ plugins/partitioning/partitioning.c | 837 ++++++++++++++++++ plugins/split/nbdkit-split-plugin.pod | 6 +- tests/Makefile.am | 10 + tests/test-partitioning1.sh | 83 ++ tests/test-partitioning2.sh | 75 ++ 12 files changed, 1381 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 2a4879a..3f99459 100644 --- a/configure.ac +++ b/configure.ac @@ -573,6 +573,7 @@ non_lang_plugins="\ memory \ nbd \ null \ + pa...

nbdkit partitioning boot.img swap.img root.img ... creates a virtual disk by adding a partition table. In ancient times Xen used to do this. Rich.

...- tests/test-parallel-file.sh | 10 ++-------- tests/test-parallel-nbd.sh | 10 ++-------- tests/test-partition1.sh | 22 ++++------------------ tests/test-partition2.sh | 6 +----- tests/test-partitioning1.sh | 8 ++------ tests/test-partitioning2.sh | 8 ++------ tests/test-partitioning4.sh | 6 +----- tests/test-partitioning5.sh | 8 ++------ tests/test-partitioning6.sh | 6 +----- tests/test-pattern-largest-for-qemu.sh | 8 ++------ tests/test-pattern-largest.sh | 8 ++------ test...

The partitioning plugin patch is the same (except for rebasing). However I have changed the first two patches based on feedback received. In particular this fixes a very serious bug found by Eric Blake in the current truncate filter. Rich.

...ests to come. Results: 06:43:00 PASS: test-cache.sh 06:37:48 PASS: test-cache-on-read.sh [ test-cow.sh possibly here ] 00:35:41 PASS: test-partitioning3.sh 00:34:29 PASS: test-partitioning5.sh 00:34:03 PASS: test-linuxdisk-copy-out.sh 00:33:58 PASS: test-floppy.sh 00:30:45 PASS: test-partitioning2.sh 00:28:41 PASS: test-linuxdisk.sh 00:28:34 PASS: test-iso.sh 00:02:59 PASS: test-cache-max-size.sh 00:02:58 PASS: test-partitioning6.sh 00:02:55 PASS: test-partitioning4.sh 00:02:51 PASS: test-eflags.sh 00:01:11 PASS: test-export-name.sh 00:01:01 PASS: test-parallel-sh.sh 00:00:54 PASS: test-pyth...

...h 00:33:57 PASS: test-partitioning3.sh 00:33:46 PASS: test-perl 00:33:38 PASS: test-partitioning5.sh 00:33:38 PASS: test-memory 00:33:28 PASS: test-ocaml 00:33:11 PASS: test-lua 00:32:33 PASS: test-tcl 00:32:16 PASS: test-offset 00:31:48 PASS: test-xz 00:31:47 PASS: test-xz-curl 00:30:19 PASS: test-partitioning2.sh 00:28:57 PASS: test-linuxdisk.sh 00:28:46 PASS: test-data 00:28:24 PASS: test-gzip 00:27:57 PASS: test-ext2 00:27:49 PASS: test-curl 00:27:16 PASS: test-iso.sh 00:25:56 PASS: test-nbd [all others < 7 mins] Analysis of what these tests do as in the previous email: test-readahead...

...PARTTYPE_MBR) + create_mbr_layout (); + else /* parttype == PARTTYPE_GPT */ create_gpt_layout (); - } return 0; } diff --git a/tests/Makefile.am b/tests/Makefile.am index 420cb45..27abbaf 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -83,6 +83,7 @@ EXTRA_DIST = \ test-partitioning2.sh \ test-partitioning3.sh \ test-partitioning4.sh \ + test-partitioning5.sh \ test-pattern.sh \ test-pattern-largest.sh \ test-pattern-largest-for-qemu.sh \ @@ -456,7 +457,8 @@ TESTS += \ if HAVE_GUESTFISH TESTS += \ test-partitioning2.sh \ - test-partitioning3.sh + test-partitioning...

...-largest.sh \ test-pattern-largest-for-qemu.sh \ @@ -454,7 +455,8 @@ test_memory_LDADD = libtest.la $(LIBGUESTFS_LIBS) # partitioning plugin test. TESTS += \ test-partitioning1.sh \ - test-partitioning4.sh + test-partitioning4.sh \ + test-partitioning6.sh if HAVE_GUESTFISH TESTS += \ test-partitioning2.sh \ diff --git a/tests/test-partitioning4.sh b/tests/test-partitioning4.sh index 4177640..f80c7ae 100755 --- a/tests/test-partitioning4.sh +++ b/tests/test-partitioning4.sh @@ -33,7 +33,7 @@ # Test the partitioning plugin. # -# Test 4: Test > 128 partitions. +# Test 4: Test > 128 partiti...

This is a revised version of the two series previously posted here: https://www.redhat.com/archives/libguestfs/2019-January/msg00137.html https://www.redhat.com/archives/libguestfs/2019-January/msg00139.html There have been many smaller changes but the highlights are: - Using SECTOR_SIZE instead of hard-coding 512 everywhere. - Additional safety checks that the EBR chain doesn't jump

...te package) diff --git a/tests/Makefile.am b/tests/Makefile.am index 27abbaf..007203f 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -79,6 +79,7 @@ EXTRA_DIST = \ test-offset2.sh \ test-parallel-file.sh \ test-parallel-nbd.sh \ + test-partition.sh \ test-partitioning1.sh \ test-partitioning2.sh \ test-partitioning3.sh \ @@ -792,11 +793,7 @@ test_offset_LDADD = libtest.la $(LIBGUESTFS_LIBS) TESTS += test-offset2.sh # partition filter test. -LIBGUESTFS_TESTS += test-partition - -test_partition_SOURCES = test-partition.c test.h -test_partition_CFLAGS = $(WARNINGS_CFLAGS) $(LIBGUESTF...

...e package) diff --git a/tests/Makefile.am b/tests/Makefile.am index 033c1a1..18936e4 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -79,6 +79,7 @@ EXTRA_DIST = \ test-offset2.sh \ test-parallel-file.sh \ test-parallel-nbd.sh \ + test-partition1.sh \ test-partitioning1.sh \ test-partitioning2.sh \ test-partitioning3.sh \ @@ -794,11 +795,7 @@ test_offset_LDADD = libtest.la $(LIBGUESTFS_LIBS) TESTS += test-offset2.sh # partition filter test. -LIBGUESTFS_TESTS += test-partition - -test_partition_SOURCES = test-partition.c test.h -test_partition_CFLAGS = $(WARNINGS_CFLAGS) $(LIBGUESTF...

I think this addresses everything in Eric's v2 review. Note that the first patch is best viewed using ‘-w’ to ignore whitespaces changes. Rich.

This implements support for MBR logical partitions in nbdkit-partition-filter, complementing existing support in the partitioning plugin. Rich.

An evolution of the patch I posted yesterday to qemu-devel (https://www.mail-archive.com/qemu-devel@nongnu.org/msg588920.html) which (a) works and (b) has a test. Rich.