search for: part_label

...continue; - /* Check for a GPT disk */ - if (!(boot_part->type == typegpt)) { - pi_del(&boot_part); + if (!(iter = pi_begin(&diskinfo, opt.piflags))) continue; - } - /* Check for a matching partition */ - while (!pi_next(boot_part)) { - if (!strcmp(label, boot_part->gpt.part_label)) - goto ok; - } + /* Check for a matching GPT partition label */ + if (iter->type == typegpt) + while (!pi_next(iter)) { + if (!strcmp(label, iter->gpt.part_label)) + goto ok; + } + pi_del(&iter); } drive = -1; ok: - *_boot_part = boot_part; + *_boot_part...

>From the earlier patches - that simple fix for indexes not counting non-data partitions in gpt and mbr cases. Patches don't touch any other parts of the code at this stage - bigger stuff later for disklib as we agreed - but this is potentially useful right now. Michal Soltys (1): chain.c: fix public index value in mbr and gpt iterators

...isk during iteration Right after creation, pi_begin() (previously get_first_partition()) does not iterate to first partition. 2e) available data at any time - disk guid or disk signature (sub.gpt.disk_guid or sub.dos_disk_sig) - parition guid (sub.gpt.part_guid) - parition label, asciiz (sub.gpt.part_label) - pointer to record holding unaltered partition entry (record) - iterator type (type) - lba beginning of partition (start_lba) - disk (0) / partition (1+) index (index) See partiter.h for details. 2f) pi_begin() It does sanity checks - including gpt's primary+backup+array crc checks - and a...

On 07/14/16 05:56, Ady Ady via Syslinux wrote: > > @Peter, Erwan, Gene, Michal, (and anyone else interested)... > > Although I haven't actually tested Erwan's patch, would it be > acceptable by you (all) if I were to send a patch to this Syslinux > Mailing List with the same code while changing the wording as I > previously suggested in a prior email? Would it be

...= table + part->private.mbr_index; return part; - free(ebr_part); err_alloc: free(part->block); @@ -869,7 +863,7 @@ static struct disk_part_iter *next_gpt_part(struct disk_part_iter *part) part->private.gpt.part_guid = &gpt_part->uid; part->private.gpt.part_label = gpt_part->name; /* Update our index */ - part->index++; + part->index = part->private.gpt.index + 1; gpt_part_dump(gpt_part); /* In a GPT scheme, we re-use the iterator */ -- 1.6.3.1

...sk_get_params(drive, &diskinfo)) + continue; /* Drive doesn't exist */ + if (!(iter = pi_begin(&diskinfo, opt.piflags))) + continue; + /* Check for a matching GPT Partition Name */ + if (iter->type == typegpt) + while (!pi_next(iter)) { + if (!strcmp(label, iter->gpt.part_label)) + // We don't care about the actual partition that matched + pi_del(&iter); + // Let's return the disk itself instead + iter = pi_begin(&diskinfo, opt.piflags); + goto ok; + } + } + drive = -1; +ok: + *_boot_part = iter; + return drive; +}...

...const int16_t *orig_lab; - - gp = (const struct disk_gpt_part_entry *) - (iter->data + iter->index0 * iter->gpt.pe_size); - orig_lab = (const int16_t *)gp->name; - - /* caveat: this is very crude conversion */ - for (int i = 0; i < PI_GPTLABSIZE/2; i++) { - iter->gpt.part_label[i] = (char)orig_lab[i]; - } - iter->gpt.part_label[PI_GPTLABSIZE/2] = 0; -} - -static inline int valid_crc(uint32_t crc, const uint8_t *buf, unsigned int siz) -{ - return crc == crc32(crc32(0, NULL, 0), buf, siz); -} - -static int gpt_check_hdr_crc(const struct disk_info * const diskinf...

...const int16_t *orig_lab; - - gp = (const struct disk_gpt_part_entry *) - (iter->data + iter->index0 * iter->gpt.pe_size); - orig_lab = (const int16_t *)gp->name; - - /* caveat: this is very crude conversion */ - for (int i = 0; i < PI_GPTLABSIZE/2; i++) { - iter->gpt.part_label[i] = (char)orig_lab[i]; - } - iter->gpt.part_label[PI_GPTLABSIZE/2] = 0; -} - -static inline int valid_crc(uint32_t crc, const uint8_t *buf, unsigned int siz) -{ - return crc == crc32(crc32(0, NULL, 0), buf, siz); -} - -static int valid_crc_gpth(struct disk_gpt_header *gh, int flags) -{...

This is a bit updated set of chain.c32 changes that simplifies a few things (and in partiter part), fixes few minor issues and adds a few new features. Details are in the following commits, below is the summary and pull details at the end. Shao - any chance to peek over them ? Most of those are relatively simple changes and well tested, though of course something might have slipped my attention.

This small set fixes few bugs, improves gpt handling (under buggy conditions) and implements strict flag with more fine grained control which should fix issues with sanity checks against disk sizes. If this set is allright I'd want to do what I mentioned in older discussion with Ady - backport missing patches from 6.x to 5.x and 4.x so all versions have up to date chain version. Michal

So last week I was wondering if XFS was still working -- even with its last on-disk structure changes -- and it _suprisingly_ worked as expected. Right, now I can finally get rid of GRUB and use Syslinux to boot my Linux on EFI from a rootfs with xfs. Shit, I have two partitions (the first one being the required ESP) so there is no way to access the other partitions since because Syslinux does not

This patch introduces extra functionality to chain.c, mainly with reference to BPB adjustments, but not only that. It expects 3 small patches I sent earlier (they are included for easy reference, patches 1-3/4). The changes introduced are: 1) file and boot sector use separate options to control load address and jump address (if applicable). Options are as described below: *

Hello, the following patches should get multidisk access working. The syntax accepted is the following: (hdx,y)/path/to/file where x is the disk number and start at 0 and the y is the partition number starting at 1. So (hd0,1) is the first partition of the first disk. the other accepted syntax is using MBR's 32 bits disk signature so for example: (mbr:0x12345678,2)/foo/bar would address