search for: part_get_name

Windows server 2012 sets partition names with spaces. ><fs> part-get-name /dev/sda 3 libguestfs: trace: part_get_name "/dev/sda" 3 guestfsd: main_loop: new request, len 0x38 parted -s -m /dev/null Error: The device /dev/null is so small that it cannot possibly store a file system or partition table. Perhaps you selected the wrong device? Warning: Error fsyncing/closing /dev/null: Invalid argument parte...

Hi, attached there are few patches to implement a way to get the label of GPT partitions (refactoring an existing function and adding a new daemon API) and using it in virt-resize to restore them when copying partitions. Thanks, Pino Toscano (3): daemon: parted: refactor sgdisk info parsing code New API: part-get-name (RHBZ#593511). resize: preserve GPT partition names (RHBZ#1060404).

Hi Rich, This is v3 series to add support for resizing MBR logical partitions. changes to v3: 1. merge patch 1 and patch 3 in v3 2. let mbr_part_type return 'primary' for GPT partitions 3. add test for resizing logical partitions 4. fix extending the extended partition (yet). see patch 7. changes to v2: 1. remove p_part_num 2. remove filter_parts 3. name the function

...ition GUID (GPT only). *) + p_attributes : string option; (* Partition attributes hex bit mask (GPT only). *) (* What we're going to do: *) mutable p_operation : partition_operation; @@ -493,6 +494,12 @@ read the man page virt-resize(1). let label = try Some (g#part_get_name "/dev/sda" part_num) with G.Error _ -> None in + let attributes = + match parttype with + | MBR -> None + | GPT -> + try Some (g#part_get_gpt_attributes "/dev/sda" part_num) + with G.Error...

...Partition GUID (GPT only). *) + p_attributes : int64 option; (* Partition attributes bit mask (GPT only). *) (* What we're going to do: *) mutable p_operation : partition_operation; @@ -493,6 +494,12 @@ read the man page virt-resize(1). let label = try Some (g#part_get_name "/dev/sda" part_num) with G.Error _ -> None in + let attributes = + match parttype with + | MBR -> None + | GPT -> + try Some (g#part_get_gpt_attributes "/dev/sda" part_num) + with G.Error...

...h_perror ("strndup"); + return NULL; + } + + return ret; +} + char * do_part_get_gpt_type (const char *device, int partnum) { return sgdisk_info_extract_field (device, partnum, "Partition GUID code", extract_uuid); } + +char * +do_part_get_name (const char *device, int partnum) +{ + char *parttype = do_part_get_parttype (device); + if (STREQ (parttype, "gpt")) + return sgdisk_info_extract_field (device, partnum, + "Partition name", extract_optionally_quoted); + + reply_with_er...

...entPV sz -> sprintf "LVM PV (%Ld bytes)" sz @@ -459,9 +465,13 @@ read the man page virt-resize(1). let typ = if is_extended_partition id then ContentExtendedPartition else get_partition_content name in + let label = + try Some (g#part_get_name "/dev/sda" part_num) + with G.Error _ -> None in { p_name = name; p_part = part; p_bootable = bootable; p_id = id; p_type = typ; + p_label = label; p_operation = OpCopy; p_target_partnum = 0; p_target_start = 0L;...

Hi all, Here is the latest version of the series addressing Pino's comments. Cédric Bosdonnat (3): daemon: make sgdisk_info_extract_uuid_field more generic New APIs: part_set_gpt_attributes and part_get_gpt_attributes resize: copy GPT partition flags daemon/parted.ml | 45 +++++++++++++++++++++++++++++++++++---------- daemon/parted.mli | 3 +++

virt-resize didn't preserve the per-partition GPT GUID. Now that guests using UEFI are becoming common (basically it's the default on aarch64) we need to take into account that sometimes the partition GUID is used by the bootloader NVRAM variables to identify the boot partition, so it must be preserved across resize. This bug caused the 'virt-builder --size' option to fail on

Hi all, Here is v3 of the series, taking Richard's comments in account. Cédric Bosdonnat (3): daemon: make sgdisk_info_extract_uuid_field more generic New APIs: part_set_gpt_attributes and part_get_gpt_attributes resize: copy GPT partition flags daemon/parted.ml | 45 +++++++++++++++++++++++++++++++++++---------- daemon/parted.mli | 2 ++ generator/actions_core.ml

Hi all, Here is the series fixing the bug I mentioned on IRC regarding the GPT attribute flags to copy to the new disk in a virt-resize. Cédric Bosdonnat (3): daemon: make sgdisk_info_extract_uuid_field more generic New APIs: part_set_gpt_attributes and part_get_gpt_attributes resize: copy GPT partition flags daemon/parted.ml | 34 +++++++++++++++++++++++++++-------

...g rhel7 guest:virt-v2v:could not update grub2 console: aug_get: no matching node (ignored) https://bugzilla.redhat.com/1143866 virt-v2v fails with error: cannot open Packages index using db5 https://bugzilla.redhat.com/1142416 part-get-name give 'libguestfs: error: part_get_name: parted does not support the machine output (-m)' error message when run 'part-get-name /dev/sda 1' https://bugzilla.redhat.com/1142186 virt-sysprep option '--mount-options' don't work well https://bugzilla.redhat.com/1142158 Illegal comma...

This is a follow-up to the other generator changes in: https://www.redhat.com/archives/libguestfs/2017-February/msg00217.html Rich.

If we want to permit more than 255 drives to be added, then we will have to add the disks to the same virtio-scsi target using different unit (LUN) numbers. Unfortunately SCSI LUN enumeration in the Linux is not deterministic (eg. two disks with target=0, lun=[0,1] can be enumerated as /dev/sda or /dev/sdb randomly). Dealing with that will require some very complex device name translation on the

...shortdesc = "copy the attributes of a path (file/directory) to another"; longdesc = "\ Copy the attributes of a path (which can be a file or a directory) @@ -8823,7 +8823,7 @@ enables all the other flags, if they are not specified already. { defaults with name = "part_get_name"; added = (1, 25, 33); - style = RString "name", [Device "device"; Int "partnum"], []; + style = RString "name", [String (Device, "device"); Int "partnum"], []; shortdesc = "get partition name"; longdesc = &q...

Very large but mechanical change to the generator. Rich.

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

Split up the huge generator/actions.ml into several smaller files. Rich.