search for: parsedeclarationspecifi

...we will end up accepting invalid C++ declarations such as: private int i; or even int private i; There are several 80-col violations in lib/Parse/ParseDecl.cpp and in the CreateIntegerAttribute function. git also picked up some trailing whitespace errors. To avoid the code duplication between ParseDeclarationSpecifiers, ParseOptionalTypeSpecifier and ParseTypeQualifierListOpt you should introduce a ParseOpenCLTypeAttributes function (e.g. see ParseBorlandTypeAttributes). Other than that, LGTM. Thanks, -- Peter

> -----Original Message----- > From: Peter Collingbourne [mailto:peter at pcc.me.uk] > Sent: 04 January 2011 21:42 > To: Anton Lokhmotov > Cc: cfe-dev at cs.uiuc.edu > Subject: Re: OpenCL support > > Here are my comments on the second patch. > > > +enum OpenCLAddressSpace { > > + OPENCL_PRIVATE = 0, > > + OPENCL_GLOBAL = 1, > > + OPENCL_LOCAL

...libc-2.23/assert/assert.c:92:0 #8 0x00007f72e0830dc3 (/usr/local/fbcode/gcc-5-glibc-2.23/lib/libc.so.6+0x2ddc3) #9 0x0000000005c811c6 clang::Parser::ConsumeToken() /data/users/meyering/fbsource/fbcode/llvm/build/../tools/clang/include/clang/Parse/Parser.h:324:5 #10 0x0000000005caa09b clang::Parser::ParseDeclarationSpecifiers(clang::DeclSpec&, clang::Parser::ParsedTemplateInfo const&, clang::AccessSpecifier, clang::Parser::DeclSpecContext, clang::Parser::LateParsedAttrList*) /data/users/meyering/fbsource/fbcode/llvm/tools/clang/lib/Parse/ParseDecl.cpp:0:7 #11 0x0000000005c79d61 clang::Parser::ParseDeclOrFunct...

...libc-2.23/assert/assert.c:92:0 #8 0x00007f72e0830dc3 (/usr/local/fbcode/gcc-5-glibc-2.23/lib/libc.so.6+0x2ddc3) #9 0x0000000005c811c6 clang::Parser::ConsumeToken() /data/users/meyering/fbsource/fbcode/llvm/build/../tools/clang/include/clang/Parse/Parser.h:324:5 #10 0x0000000005caa09b clang::Parser::ParseDeclarationSpecifiers(clang::DeclSpec&, clang::Parser::ParsedTemplateInfo const&, clang::AccessSpecifier, clang::Parser::DeclSpecContext, clang::Parser::LateParsedAttrList*) /data/users/meyering/fbsource/fbcode/llvm/tools/clang/lib/Parse/ParseDecl.cpp:0:7 #11 0x0000000005c79d61 clang::Parser::ParseDeclOrFunct...

...:92:0 > #8 0x00007f72e0830dc3 (/usr/local/fbcode/gcc-5-glibc-2.23/lib/libc.so.6+0x2ddc3) > #9 0x0000000005c811c6 clang::Parser::ConsumeToken() > /data/users/meyering/fbsource/fbcode/llvm/build/../tools/clang/include/clang/Parse/Parser.h:324:5 > #10 0x0000000005caa09b > clang::Parser::ParseDeclarationSpecifiers(clang::DeclSpec&, > clang::Parser::ParsedTemplateInfo const&, clang::AccessSpecifier, > clang::Parser::DeclSpecContext, clang::Parser::LateParsedAttrList*) > /data/users/meyering/fbsource/fbcode/llvm/tools/clang/lib/Parse/ParseDecl.cpp:0:7 > #11 0x0000000005c79d61 > clang:...