Displaying 2 results from an estimated 2 matches for "parseborlandtypeattributes".
2011 Feb 23
0
[LLVMdev] [PATCH] OpenCL support - update on keywords
...seDecl.cpp
and in the CreateIntegerAttribute function. git also picked
up some trailing whitespace errors.
To avoid the code duplication between ParseDeclarationSpecifiers,
ParseOptionalTypeSpecifier and ParseTypeQualifierListOpt you
should introduce a ParseOpenCLTypeAttributes function (e.g. see
ParseBorlandTypeAttributes).
Other than that, LGTM.
Thanks,
--
Peter
2011 Feb 18
6
[LLVMdev] [PATCH] OpenCL support - update on keywords
> -----Original Message-----
> From: Peter Collingbourne [mailto:peter at pcc.me.uk]
> Sent: 04 January 2011 21:42
> To: Anton Lokhmotov
> Cc: cfe-dev at cs.uiuc.edu
> Subject: Re: OpenCL support
>
> Here are my comments on the second patch.
>
> > +enum OpenCLAddressSpace {
> > + OPENCL_PRIVATE = 0,
> > + OPENCL_GLOBAL = 1,
> > + OPENCL_LOCAL