search for: parse_reportdesc

...xmalloc(size); + + if (fread(buf, size, 1, f) != 1) { + upslog_with_errno(LOG_CRIT, "Short read of %s", descfile); + fclose(f); + free(buf); + return 0; + } + fclose(f); + + rdbuf = buf; + rdlen = size; + } + /* Parse Report Descriptor */ Free_ReportDesc(pDesc); pDesc = Parse_ReportDesc(rdbuf, rdlen); + + if (descfile) + free(rdbuf); + if (!pDesc) { upsdebug_with_errno(1, "Failed to parse report descriptor!"); return 0; -- 2.7.4 -- Russell King

Hi all, greetings and a happy new year! I am writing as a user, rather than as an ex-developer. Usbhid-ups contains a fatal bug that was apparently introduced in r1210 (I did a binary search to find the exact revision). Arjen, you wrote "correct me if I'm wrong", so it seems that's what I am doing. ------------------------------------------------------------------------ r1210

Hi, I've been checking out NUT with an OpenUPS board over the last couple of weekends, and have noticed that it doesn't seem to report sensible values. This lead me to investigate usbhid-ups and delve into various issues. As mentioned in a github issue, one of the problems is with the report descriptor - dumping this from the usbhid-ups debug output and picking through it reveals that

...ODE_REOPEN) { > upsdebugx(4, "Device reopened successfully"); > return hd; > } > @@ -632,6 +683,7 @@ > upsdebug_hex(3, "Report Descriptor", ReportDesc, ReportSize); > > /* Parse Report Descriptor */ > + Free_ReportDesc(pDesc); > pDesc = Parse_ReportDesc(ReportDesc, ReportSize); > if (!pDesc) { > HIDCloseDevice(*udevp); > @@ -639,6 +691,7 @@ > } > > /* prepare report buffer */ > + free_report_buffer(rbuf); > rbuf = new_report_buffer(pDesc); > if (!rbuf) { > Free_ReportDesc(pDesc); > > Modified:...