search for: parse_dhcp

...linux.org/commit/38e861ebf45a804bc5fbd74d9c19292822c84487 > Author: Gene Cumm <gene.cumm at gmail.com> > AuthorDate: Sat, 20 Jun 2015 21:17:18 -0400 > Committer: Gene Cumm <gene.cumm at gmail.com> > CommitDate: Sat, 20 Jun 2015 21:17:18 -0400 > > core/pxe: extend parse_dhcp() for packet type > > Add packet type so we can eventually only grab certain data elements from > the DHCP packets appropriately > > Signed-off-by: Gene Cumm <gene.cumm at gmail.com> > * > + * pkt_type 1 for Discover, 2 for Ack, 3 for ProxyDHCP, 0 for everything >...

...linux.org/commit/38e861ebf45a804bc5fbd74d9c19292822c84487 > Author: Gene Cumm <gene.cumm at gmail.com> > AuthorDate: Sat, 20 Jun 2015 21:17:18 -0400 > Committer: Gene Cumm <gene.cumm at gmail.com> > CommitDate: Sat, 20 Jun 2015 21:17:18 -0400 > > core/pxe: extend parse_dhcp() for packet type > > Add packet type so we can eventually only grab certain data elements from > the DHCP packets appropriately When will it be visible at our new git repo location? <snip/> > _______________________________________________ > Syslinux-commits mailing list &...

...> Feedback appreciated. > > Best, > Patrick > > Signed-off-by: Patrick Masotta <masottaus at yahoo.com> <bigsnip/> > --- a/efi/pxe.c 2014-10-06 10:27:44.000000000 -0600 > +++ b/efi/pxe.c 2015-02-18 19:39:43.118182728 -0700 > @@ -154,7 +154,12 @@ void net_parse_dhcp(void) > * Get the boot file and other info. This lives in the CACHED_REPLY > * packet (query info 3) > */ > - parse_dhcp(&mode->PxeReply.Dhcpv4, pkt_len); > + > + if(&mode->ProxyOfferReceived) > + parse_dhcp(&mode->ProxyOffer....

...s when deciding where the PXE server is located. syslinux.efi is taking the next-server IP from an answer from a DHCP server that did not identified itself as a PXE server (no option 60). It looks like a bug to me. I think I "kind" of fixed the bug; at syslinux-6.03/efi/pxe.c void net_parse_dhcp(void) { ... //patmod start if(&mode->ProxyOfferReceived) parse_dhcp(&mode->ProxyOffer.Dhcpv4, pkt_len); else //patmod end parse_dhcp(&mode->PxeReply.Dhcpv4, pkt_len); Print(L"\n"); ... } just add the code surrounded by comments the idea i...

...inux, + .boot_efi = efi_boot_efi, + .clear_screen = efi_clear_screen, .vesa = &efi_vesa_ops, .mem = &efi_mem_ops, }; diff -uprN a/efi/pxe.c b/efi/pxe.c --- a/efi/pxe.c 2014-10-06 10:27:44.000000000 -0600 +++ b/efi/pxe.c 2015-02-18 19:39:43.118182728 -0700 @@ -154,7 +154,12 @@ void net_parse_dhcp(void) * Get the boot file and other info. This lives in the CACHED_REPLY * packet (query info 3) */ - parse_dhcp(&mode->PxeReply.Dhcpv4, pkt_len); + + if(&mode->ProxyOfferReceived) + parse_dhcp(&mode->ProxyOffer.Dhcpv4, pkt_len); + else + parse...

On Sun, Jan 11, 2015 at 10:32 AM, Patrick Masotta <masottaus at yahoo.com> wrote: > >>First, I was looking for the actual values. >>For a VM with (among other values): > >> config.version = "8" >> virtualHW.version = "10" >> ethernet0.virtualDev = "e1000" >> guestOS = "rhel6-64" >> firmware =

from: Jeff Sloan <jeff_sloan at selinc.com> Update UEFI PXE proxyDHCP handling. This patch is based on commit ID 8a00e49 Modify two files to specify valid ip addresses. These files are efi/pxe.c and efi/udp.c. In efi/pxe.c: In net_parse_dhcp function. If ProxyOffer has been received, start with DhcpAck packet since it is the most complete. This requires a minimum of changes to the packet except that it contains NULL server ip so populate server from ProxyOffer packet. The information is loaded into pkt_v4 and then parsed. In efi/u...

>First, I was looking for the actual values.? >For a VM with (among other values): > config.version = "8" > virtualHW.version = "10" > ethernet0.virtualDev = "e1000" > guestOS = "rhel6-64" > firmware = "efi" > I see: > option-93 = 0x07 > option-60 ="PXEClient:Arch:00007:UNDI:003016" OK I take

This patch adds to Com32 modules the capabilities of accessing the EFI environment The idea is simple, the EFI parameters "image" and "table" received by syslinux.efi's efi_main() are stored in the "firmware" structure, next they are retrieved from the Com32 module which is linked against the gnu-efi static library. The Com32 module can use the EFI

...t;> {52, option_overload}, >> - {54, server}, >> {61, client_identifier}, >> + {66, tftpserver_name}, >> {67, bootfile_name}, >> {97, uuid_client_identifier}, >> {209, pxelinux_configfile}, >> @@ -215,7 +215,7 @@ void parse_dhcp_options(const void *option, int size, uint8_t opt_filter) >> * information is present: >> * >> * MyIP - client IP address >> - * server_ip - boot server IP address >> + * server_ip - boot server IP address, REVIEW ME FIXME >> * net_m...

>> +? ? if(&mode->ProxyOfferReceived) >> +? ? ? ? parse_dhcp(&mode->ProxyOffer.Dhcpv4,pkt_len); >> +? ? else > > I think that change should go into another commit. > Geert Stappers You may be right; but as I've said, all the testing was conducted on PXE (proxyDHCP) environments where those lines are mandatory to my patch. I just...

...gt; server is located. syslinux.efi is taking the next-server IP from an answer from a DHCP server that > did not identified itself as a PXE server (no option 60). It looks like a bug to me. > > I think I "kind" of fixed the bug; > at syslinux-6.03/efi/pxe.c > > void net_parse_dhcp(void) > { > ... > > //patmod start > if(&mode->ProxyOfferReceived) > parse_dhcp(&mode->ProxyOffer.Dhcpv4, pkt_len); > else > //patmod end > > parse_dhcp(&mode->PxeReply.Dhcpv4, pkt_len); > Print(L"\n"); > &gt...

...d to be parsed. > > Not really; If you parse both "next server" from the > last parsed packet (PxeReply) will overwrite > the value gathered from the ProxyOffer and that leads > to "Nest-server"= DHCP Server IP (wrong) Order: at syslinux-6.03/efi/pxe.c void net_parse_dhcp(void) { ... parse_dhcp(&mode->PxeReply.Dhcpv4, pkt_len); //genemod start if(&mode->ProxyOfferReceived) parse_dhcp(&mode->ProxyOffer.Dhcpv4, pkt_len); //genemod end Print(L"\n"); ... } Though I'm trying to think of a DHCP option that wouldn&...

> EFI has proven to be more robust.? The catch > here is order.? The > ProxyOffer data must > take precedence over the PxeReply data but both > of them probably need to be parsed. Not really; If you parse both "next server" from the last parsed packet (PxeReply) will overwrite the value gathered from the ProxyOffer and that leads to "Nest-server"= DHCP Server IP

I am sending a patch that makes the debugging output of PXELINUX slightly more concise, without (intentionally) affecting its completeness at all. Additionally, I am proposing that the debugging output of PXELINUX -- specifically the messages that appear after the copyright statement, but before the menu is loaded -- only be shown in response to keyboard input (such as holding Shift or Alt, or

...utilize the default routing otherwise. This may require more code to distinguish subnet-local versus remote. Looks like the thread starting at http://www.syslinux.org/archives/2013-November/021039.html 2) Why not touch efi/tcp.c also which also uses UseDefaultAddress? > In efi/pxe.c: In net_parse_dhcp function. > > If ProxyOffer has been received, start with DhcpAck packet since it is the > most complete. This requires a minimum of changes to the packet except that > it contains NULL server ip so populate server from ProxyOffer packet. The > information is loaded into pkt_v4 and t...

...n, > .vesa = &efi_vesa_ops, > .mem = &efi_mem_ops, > }; Looks good. Glue. > diff -uprN a/efi/pxe.c b/efi/pxe.c > --- a/efi/pxe.c 2014-10-06 10:27:44.000000000 -0600 > +++ b/efi/pxe.c 2015-02-18 19:39:43.118182728 -0700 > @@ -154,7 +154,12 @@ void net_parse_dhcp(void) > * Get the boot file and other info. This lives in the CACHED_REPLY > * packet (query info 3) > */ > - parse_dhcp(&mode->PxeReply.Dhcpv4, pkt_len); > + > + if(&mode->ProxyOfferReceived) > + parse_dhcp(&mode->ProxyOffer....

...dhcp_opts[] = { {15, local_domain}, {43, vendor_encaps}, {52, option_overload}, - {54, server}, {61, client_identifier}, + {66, tftpserver_name}, {67, bootfile_name}, {97, uuid_client_identifier}, {209, pxelinux_configfile}, @@ -215,7 +215,7 @@ void parse_dhcp_options(const void *option, int size, uint8_t opt_filter) * information is present: * * MyIP - client IP address - * server_ip - boot server IP address + * server_ip - boot server IP address, REVIEW ME FIXME * net_mask - network mask * gate_way - default gateway router IP * boot_fil...

...12, 2015 at 10:23 AM, Geert Stappers wrote: > >> diff --git a/core/fs/pxe/dhcp_option.c b/core/fs/pxe/dhcp_option.c > >> index 8d93a6a..b82e944 100644 > >> --- a/core/fs/pxe/dhcp_option.c > >> +++ b/core/fs/pxe/dhcp_option.c > >> @@ -252,4 +252,6 @@ void parse_dhcp(const void *pkt, size_t pkt_len, int pkt_type) > >> > >> if (over_load & 2) > >> parse_dhcp_options(dhcp->sname, 64, 0); > >> + > >> + /* What about option 66, tftserver_name ? FIXME */ > >> } > > > > Somet...

..., Geert Stappers wrote: >> >> diff --git a/core/fs/pxe/dhcp_option.c b/core/fs/pxe/dhcp_option.c >> >> index 8d93a6a..b82e944 100644 >> >> --- a/core/fs/pxe/dhcp_option.c >> >> +++ b/core/fs/pxe/dhcp_option.c >> >> @@ -252,4 +252,6 @@ void parse_dhcp(const void *pkt, size_t pkt_len, int pkt_type) >> >> >> >> if (over_load & 2) >> >> parse_dhcp_options(dhcp->sname, 64, 0); >> >> + >> >> + /* What about option 66, tftserver_name ? FIXME */ >> >> } &...