search for: parse_command_line_lv

When a disk image uses LVM thinp (thin provisioning), the guestfs_lvs API would return the thinp pools. This confused other APIs because thinp pools don't have corresponding /dev/VG/LV device nodes. Filter the LVs that are returned using "lv_role=public". Thanks: Fabian Deutsch --- daemon/lvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/daemon/lvm.c

..."-S", "lv_role=public", > + "--noheadings", > "--separator", "/", NULL); > if (r == -1) { > reply_with_error ("%s", err); Should the additional parameter passed also when calling `lvs` in parse_command_line_lvs (which implements lvs_full)? -- Pino Toscano

...ERROR (lvm2, NULL); + return parse_command_line_pvs (); } guestfs_int_lvm_vg_list * do_vgs_full (void) { + IF_NOT_AVAILABLE_ERROR (lvm2, NULL); + return parse_command_line_vgs (); } guestfs_int_lvm_lv_list * do_lvs_full (void) { + IF_NOT_AVAILABLE_ERROR (lvm2, NULL); + return parse_command_line_lvs (); } @@ -186,6 +198,8 @@ do_pvcreate (const char *device) char *err; int r; + IF_NOT_AVAILABLE_ERROR (lvm2, -1); + r = command (NULL, &err, "lvm", "pvcreate", device, NULL); if (r == -1) { @@ -208,6 +222,8 @@ do_vgcreate (const char *volgr...

The warnings in daemon were aggravating and risky for development (too easy to miss new ones) so I spent some time last week and today working on removing them. The first patch gets us down to almost no warnings with the original -Wall setting. That was by far the hardest part. Once I'd done that, I enabled nearly all of gcc's warnings via gnulib's warnings and manywarnings modules

Replace GUESTFSD_EXT_CMD with a command line option ‘./guestfsd --print-external-commands’