search for: paravirt_patch_32

A bugfix introduced a harmless warning: arch/x86/kernel/paravirt_patch_32.c: In function 'native_patch': arch/x86/kernel/paravirt_patch_32.c:71:1: error: label 'patch_default' defined but not used [-Werror=unused-label] This puts it in the same #ifdef as its caller. Fixes: 45dbea5f55c0 ("x86/paravirt: Fix native_patch()") Signed-off-by: Arnd B...

A bugfix introduced a harmless warning: arch/x86/kernel/paravirt_patch_32.c: In function 'native_patch': arch/x86/kernel/paravirt_patch_32.c:71:1: error: label 'patch_default' defined but not used [-Werror=unused-label] This puts it in the same #ifdef as its caller. Fixes: 45dbea5f55c0 ("x86/paravirt: Fix native_patch()") Signed-off-by: Arnd B...

...] patch_site: but those labels can simply be removed by directly calling the respective functions there. Signed-off-by: Borislav Petkov <bp at suse.de> Cc: Juergen Gross <jgross at suse.com> Cc: x86 at kernel.org Cc: virtualization at lists.linux-foundation.org --- arch/x86/kernel/paravirt_patch_32.c | 21 ++++++++++----------- arch/x86/kernel/paravirt_patch_64.c | 20 +++++++++----------- 2 files changed, 19 insertions(+), 22 deletions(-) diff --git a/arch/x86/kernel/paravirt_patch_32.c b/arch/x86/kernel/paravirt_patch_32.c index d460cbcabcfe..af57f0d0789f 100644 --- a/arch/x86/kernel/parav...

...] patch_site: but those labels can simply be removed by directly calling the respective functions there. Signed-off-by: Borislav Petkov <bp at suse.de> Cc: Juergen Gross <jgross at suse.com> Cc: x86 at kernel.org Cc: virtualization at lists.linux-foundation.org --- arch/x86/kernel/paravirt_patch_32.c | 21 ++++++++++----------- arch/x86/kernel/paravirt_patch_64.c | 20 +++++++++----------- 2 files changed, 19 insertions(+), 22 deletions(-) diff --git a/arch/x86/kernel/paravirt_patch_32.c b/arch/x86/kernel/paravirt_patch_32.c index d460cbcabcfe..af57f0d0789f 100644 --- a/arch/x86/kernel/parav...

On Fri, Dec 16, 2016 at 10:16:35AM +0100, Arnd Bergmann wrote: > A bugfix introduced a harmless warning: > > arch/x86/kernel/paravirt_patch_32.c: In function 'native_patch': > arch/x86/kernel/paravirt_patch_32.c:71:1: error: label 'patch_default' defined but not used [-Werror=unused-label] > > This puts it in the same #ifdef as its caller. > > Fixes: 45dbea5f55c0 ("x86/paravirt: Fix native_patch()&quo...

...spective functions there. Get rid of local variables too, while at it. Signed-off-by: Borislav Petkov <bp at suse.de> Cc: Juergen Gross <jgross at suse.com> Cc: x86 at kernel.org Cc: virtualization at lists.linux-foundation.org --- It looks even more cleaner now. :) arch/x86/kernel/paravirt_patch_32.c | 48 +++++++++++----------------- arch/x86/kernel/paravirt_patch_64.c | 49 ++++++++++++----------------- 2 files changed, 39 insertions(+), 58 deletions(-) diff --git a/arch/x86/kernel/paravirt_patch_32.c b/arch/x86/kernel/paravirt_patch_32.c index d460cbcabcfe..0865323c2716 100644 --- a/arch/...

...spective functions there. Get rid of local variables too, while at it. Signed-off-by: Borislav Petkov <bp at suse.de> Cc: Juergen Gross <jgross at suse.com> Cc: x86 at kernel.org Cc: virtualization at lists.linux-foundation.org --- It looks even more cleaner now. :) arch/x86/kernel/paravirt_patch_32.c | 48 +++++++++++----------------- arch/x86/kernel/paravirt_patch_64.c | 49 ++++++++++++----------------- 2 files changed, 39 insertions(+), 58 deletions(-) diff --git a/arch/x86/kernel/paravirt_patch_32.c b/arch/x86/kernel/paravirt_patch_32.c index d460cbcabcfe..0865323c2716 100644 --- a/arch/...

...rislav Petkov <bp at suse.de> > Cc: Juergen Gross <jgross at suse.com> > Cc: x86 at kernel.org > Cc: virtualization at lists.linux-foundation.org > --- > > It looks even more cleaner now. :) And there is still some more clean up possible: > > arch/x86/kernel/paravirt_patch_32.c | 48 +++++++++++----------------- > arch/x86/kernel/paravirt_patch_64.c | 49 ++++++++++++----------------- > 2 files changed, 39 insertions(+), 58 deletions(-) > > diff --git a/arch/x86/kernel/paravirt_patch_32.c b/arch/x86/kernel/paravirt_patch_32.c > index d460cbcabcfe..086532...

...GCC > extended asm syntax of two '%' characters instead of one when specifying > a register name. > > Signed-off-by: Josh Poimboeuf <jpoimboe at redhat.com> Reviewed-by: Juergen Gross <jgross at suse.com> Mind adding another patch to merge the now nearly identical paravirt_patch_32.c and paravirt_patch_64.c either into paravirt.c or paravirt_patch.c? This would require only very few #ifdef. Juergen > --- > arch/x86/include/asm/special_insns.h | 24 ++++++++++++++++++++++++ > arch/x86/kernel/paravirt_patch_32.c | 21 +++++++++++---------- > arch/x86/kernel/par...

...o be used by a future patch which requires the GCC extended asm syntax of two '%' characters instead of one when specifying a register name. Signed-off-by: Josh Poimboeuf <jpoimboe at redhat.com> --- arch/x86/include/asm/special_insns.h | 24 ++++++++++++++++++++++++ arch/x86/kernel/paravirt_patch_32.c | 21 +++++++++++---------- arch/x86/kernel/paravirt_patch_64.c | 29 +++++++++++++++-------------- 3 files changed, 50 insertions(+), 24 deletions(-) diff --git a/arch/x86/include/asm/special_insns.h b/arch/x86/include/asm/special_insns.h index ac402c6fc24b..0549c5f2c1b3 100644 --- a/arch/x86...

...imply be removed by directly calling the > respective functions there. > > Signed-off-by: Borislav Petkov <bp at suse.de> > Cc: Juergen Gross <jgross at suse.com> > Cc: x86 at kernel.org > Cc: virtualization at lists.linux-foundation.org > --- > arch/x86/kernel/paravirt_patch_32.c | 21 ++++++++++----------- > arch/x86/kernel/paravirt_patch_64.c | 20 +++++++++----------- > 2 files changed, 19 insertions(+), 22 deletions(-) > > diff --git a/arch/x86/kernel/paravirt_patch_32.c b/arch/x86/kernel/paravirt_patch_32.c > index d460cbcabcfe..af57f0d0789f 100644 &g...

...at it. Also, simplify function flow for better readability. Signed-off-by: Borislav Petkov <bp at suse.de> Cc: Juergen Gross <jgross at suse.com> Cc: x86 at kernel.org Cc: virtualization at lists.linux-foundation.org --- Here it is, rebased ontop of rc3+tip/master. arch/x86/kernel/paravirt_patch_32.c | 44 ++++++++++----------------- arch/x86/kernel/paravirt_patch_64.c | 46 +++++++++++------------------ 2 files changed, 33 insertions(+), 57 deletions(-) diff --git a/arch/x86/kernel/paravirt_patch_32.c b/arch/x86/kernel/paravirt_patch_32.c index d460cbcabcfe..6368c22fa1fa 100644 --- a/arch/x...

On Mon, Sep 10, 2018 at 08:54:12AM +0200, Juergen Gross wrote: > > + case PARAVIRT_PATCH(lock.queued_spin_unlock): > > + if (pv_is_native_spin_unlock()) > > + return paravirt_patch_insns(ibuf, len, > > + start_lock_queued_spin_unlock, > > + end_lock_queued_spin_unlock); > > + else > > + return paravirt_patch_default(type, ibuf,

On Mon, Sep 10, 2018 at 08:54:12AM +0200, Juergen Gross wrote: > > + case PARAVIRT_PATCH(lock.queued_spin_unlock): > > + if (pv_is_native_spin_unlock()) > > + return paravirt_patch_insns(ibuf, len, > > + start_lock_queued_spin_unlock, > > + end_lock_queued_spin_unlock); > > + else > > + return paravirt_patch_default(type, ibuf,

.../x86/include/asm/paravirt.h | 5 ++++ arch/x86/include/asm/paravirt_types.h | 3 +++ arch/x86/include/asm/qspinlock.h | 48 ++++++++++++++++++++++++----------- arch/x86/kernel/paravirt-spinlocks.c | 22 ++++++++-------- arch/x86/kernel/paravirt.c | 7 +++++ arch/x86/kernel/paravirt_patch_32.c | 18 ++++++------- arch/x86/kernel/paravirt_patch_64.c | 17 +++++-------- arch/x86/kernel/smpboot.c | 2 ++ arch/x86/xen/spinlock.c | 2 ++ 9 files changed, 79 insertions(+), 45 deletions(-) -- 2.12.3

.../x86/include/asm/paravirt.h | 5 ++++ arch/x86/include/asm/paravirt_types.h | 3 +++ arch/x86/include/asm/qspinlock.h | 48 ++++++++++++++++++++++++----------- arch/x86/kernel/paravirt-spinlocks.c | 22 ++++++++-------- arch/x86/kernel/paravirt.c | 7 +++++ arch/x86/kernel/paravirt_patch_32.c | 18 ++++++------- arch/x86/kernel/paravirt_patch_64.c | 17 +++++-------- arch/x86/kernel/smpboot.c | 2 ++ arch/x86/xen/spinlock.c | 2 ++ 9 files changed, 79 insertions(+), 45 deletions(-) -- 2.12.3

From: Borislav Petkov <bp at suse.de> When CONFIG_PARAVIRT_SPINLOCKS=n, it fires arch/x86/kernel/paravirt_patch_64.c: In function ?native_patch?: arch/x86/kernel/paravirt_patch_64.c:89:1: warning: label ?patch_site? defined but not used [-Wunused-label] patch_site: but that label can simply be removed by directly calling paravirt_patch_insns() there. Signed-off-by: Borislav Petkov

From: Borislav Petkov <bp at suse.de> When CONFIG_PARAVIRT_SPINLOCKS=n, it fires arch/x86/kernel/paravirt_patch_64.c: In function ?native_patch?: arch/x86/kernel/paravirt_patch_64.c:89:1: warning: label ?patch_site? defined but not used [-Wunused-label] patch_site: but that label can simply be removed by directly calling paravirt_patch_insns() there. Signed-off-by: Borislav Petkov

...kernel.org> > --- > arch/x86/include/asm/msr.h | 16 ++++++++-------- > arch/x86/include/asm/paravirt.h | 34 ---------------------------------- > arch/x86/include/asm/paravirt_types.h | 2 -- > arch/x86/kernel/paravirt.c | 2 -- > arch/x86/kernel/paravirt_patch_32.c | 2 -- > arch/x86/xen/enlighten.c | 3 --- > 6 files changed, 8 insertions(+), 51 deletions(-) Nice diffstat. Acked-by: Borislav Petkov <bp at suse.de> (leaving in the rest for reference) > diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm/msr.h &...

...kernel.org> > --- > arch/x86/include/asm/msr.h | 16 ++++++++-------- > arch/x86/include/asm/paravirt.h | 34 ---------------------------------- > arch/x86/include/asm/paravirt_types.h | 2 -- > arch/x86/kernel/paravirt.c | 2 -- > arch/x86/kernel/paravirt_patch_32.c | 2 -- > arch/x86/xen/enlighten.c | 3 --- > 6 files changed, 8 insertions(+), 51 deletions(-) Nice diffstat. Acked-by: Borislav Petkov <bp at suse.de> (leaving in the rest for reference) > diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm/msr.h &...