search for: pahole

...vive after calling BPF/XDP. After your change it will be overwritten in xdp_frame cases. > So let's just not reserve space for vnet header in this case. I think this is a wrong approach! We are working on supporting GRO multi-buffer for XDP. The vnet header contains GRO information (see pahole below sign). It is currently not used in the XDP case, but we will be working towards using it. There are a lot of unanswered questions on how this will be implemented. Thus, I cannot layout how we are going to leverage this info yet, but your patch are killing this info, which IHMO is going in th...

We tried to reserve space for vnet header before xdp.data_hard_start. But this is useless since the packet could be modified by XDP which may invalidate the information stored in the header and there's no way for XDP to know the existence of the vnet header currently. So let's just not reserve space for vnet header in this case. Cc: Jesper Dangaard Brouer <brouer at redhat.com>

We tried to reserve space for vnet header before xdp.data_hard_start. But this is useless since the packet could be modified by XDP which may invalidate the information stored in the header and there's no way for XDP to know the existence of the vnet header currently. So let's just not reserve space for vnet header in this case. Cc: Jesper Dangaard Brouer <brouer at redhat.com>

...a LAG. */ if (dp->lag && !host_addr) { if (!ds->ops->lag_fdb_add || !ds->ops->lag_fdb_del) return -EOPNOTSUPP; } else { if (!ds->ops->port_fdb_add || !ds->ops->port_fdb_del) return -EOPNOTSUPP; } What you should be doing is you should be using the pahole tool to find a good place for a new unsigned long field in struct dsa_switch, and add a new field ds->supported_fdb_flags. You should extend the early checking from dsa_slave_fdb_event() and exit without doing anything if the (fdb->flags & ~ds->supported_fdb_flags) expression is non-ze...

...ter your change it will be overwritten in xdp_frame cases. > > >> So let's just not reserve space for vnet header in this case. > I think this is a wrong approach! > > We are working on supporting GRO multi-buffer for XDP. The vnet header > contains GRO information (see pahole below sign). Another note is that since we need reserve room for skb_shared_info, GRO for XDP may probably lead more frag list. > It is currently not > used in the XDP case, but we will be working towards using it. Good to know that, but I think it can only work when the packet is no...

...ter your change it will be overwritten in xdp_frame cases. > > >> So let's just not reserve space for vnet header in this case. > I think this is a wrong approach! > > We are working on supporting GRO multi-buffer for XDP. The vnet header > contains GRO information (see pahole below sign). Another note is that since we need reserve room for skb_shared_info, GRO for XDP may probably lead more frag list. > It is currently not > used in the XDP case, but we will be working towards using it. Good to know that, but I think it can only work when the packet is no...

...in xdp_frame cases. > > > > > > > So let's just not reserve space for vnet header in this case. > > I think this is a wrong approach! > > > > We are working on supporting GRO multi-buffer for XDP. The vnet header > > contains GRO information (see pahole below sign). > > > Another note is that since we need reserve room for skb_shared_info, GRO for > XDP may probably lead more frag list. > > > > It is currently not > > used in the XDP case, but we will be working towards using it. > > > Good to know th...

Hello Gert, On 9 September 2015 at 12:42, Gerd Hoffmann <kraxel at redhat.com> wrote: > Add the bits needed for opengl rendering support: query > capabilities, new virtio commands, drm ioctls. > > Signed-off-by: Dave Airlie <airlied at redhat.com> > Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> > --- > + > +struct drm_ioctl_desc