search for: page_poisoning_en

On Wed, Feb 07, 2018 at 02:54:30PM +0800, Wei Wang wrote: > In some usages, e.g. virtio-balloon, a kernel module needs to know if > page poisoning is in use. This patch exposes the page_poisoning_enabled > function to kernel modules. > > Signed-off-by: Wei Wang <wei.w.wang at intel.com> > Cc: Andrew Morton <akpm at linux-foundation.org> > Cc: Michal Hocko <mhocko at kernel.org> > Cc: Michael S. Tsirkin <mst at redhat.com> > --- > mm/page_poison...

On Wed, Feb 07, 2018 at 02:54:30PM +0800, Wei Wang wrote: > In some usages, e.g. virtio-balloon, a kernel module needs to know if > page poisoning is in use. This patch exposes the page_poisoning_enabled > function to kernel modules. > > Signed-off-by: Wei Wang <wei.w.wang at intel.com> > Cc: Andrew Morton <akpm at linux-foundation.org> > Cc: Michal Hocko <mhocko at kernel.org> > Cc: Michael S. Tsirkin <mst at redhat.com> > --- > mm/page_poison...

On 02/08/2018 02:34 AM, Michael S. Tsirkin wrote: > On Wed, Feb 07, 2018 at 02:54:30PM +0800, Wei Wang wrote: >> In some usages, e.g. virtio-balloon, a kernel module needs to know if >> page poisoning is in use. This patch exposes the page_poisoning_enabled >> function to kernel modules. >> >> Signed-off-by: Wei Wang <wei.w.wang at intel.com> >> Cc: Andrew Morton <akpm at linux-foundation.org> >> Cc: Michal Hocko <mhocko at kernel.org> >> Cc: Michael S. Tsirkin <mst at redhat.com> >&g...

In some usages, e.g. virtio-balloon, a kernel module needs to know if page poisoning is in use. This patch exposes the page_poisoning_enabled function to kernel modules. Signed-off-by: Wei Wang <wei.w.wang at intel.com> Cc: Andrew Morton <akpm at linux-foundation.org> Cc: Michal Hocko <mhocko at kernel.org> Cc: Michael S. Tsirkin <mst at redhat.com> --- mm/page_poison.c | 6 ++++++ 1 file changed, 6 inserti...

In some usages, e.g. virtio-balloon, a kernel module needs to know if page poisoning is in use. This patch exposes the page_poisoning_enabled function to kernel modules. Signed-off-by: Wei Wang <wei.w.wang at intel.com> Cc: Andrew Morton <akpm at linux-foundation.org> Cc: Michal Hocko <mhocko at kernel.org> Cc: Michael S. Tsirkin <mst at redhat.com> --- mm/page_poison.c | 6 ++++++ 1 file changed, 6 inserti...

..._LICENSE() in drivers/pinctrl/pxa/pinctrl-pxa2xx.o > > see include/linux/module.h for more information > > WARNING: modpost: missing MODULE_LICENSE() in drivers/power/reset/zx-reboot.o > > see include/linux/module.h for more information > > > > ERROR: "page_poisoning_enabled" [drivers/virtio/virtio_balloon.ko] undefined! > > page_poisoning_enabled needs to be exposed. I'll send a small patch to add > EXPORT_SYMBOL_GPL(page_poisoning_enabled). > > > Best, > Wei This will probably miss this release cycle. -- MST

..._LICENSE() in drivers/pinctrl/pxa/pinctrl-pxa2xx.o > > see include/linux/module.h for more information > > WARNING: modpost: missing MODULE_LICENSE() in drivers/power/reset/zx-reboot.o > > see include/linux/module.h for more information > > > > ERROR: "page_poisoning_enabled" [drivers/virtio/virtio_balloon.ko] undefined! > > page_poisoning_enabled needs to be exposed. I'll send a small patch to add > EXPORT_SYMBOL_GPL(page_poisoning_enabled). > > > Best, > Wei This will probably miss this release cycle. -- MST

...odpost: missing MODULE_LICENSE() in drivers/pinctrl/pxa/pinctrl-pxa2xx.o > see include/linux/module.h for more information > WARNING: modpost: missing MODULE_LICENSE() in drivers/power/reset/zx-reboot.o > see include/linux/module.h for more information >>> ERROR: "page_poisoning_enabled" [drivers/virtio/virtio_balloon.ko] undefined! page_poisoning_enabled needs to be exposed. I'll send a small patch to add EXPORT_SYMBOL_GPL(page_poisoning_enabled). Best, Wei

...ctrl/pxa/pinctrl-pxa2xx.o > > > see include/linux/module.h for more information > > > WARNING: modpost: missing MODULE_LICENSE() in > drivers/power/reset/zx-reboot.o > > > see include/linux/module.h for more information > > > > > ERROR: "page_poisoning_enabled" [drivers/virtio/virtio_balloon.ko] > undefined! > > > > page_poisoning_enabled needs to be exposed. I'll send a small patch to > > add EXPORT_SYMBOL_GPL(page_poisoning_enabled). > > > > > > Best, > > Wei > > This will probably miss...

...ormation WARNING: modpost: missing MODULE_LICENSE() in drivers/pinctrl/pxa/pinctrl-pxa2xx.o see include/linux/module.h for more information WARNING: modpost: missing MODULE_LICENSE() in drivers/power/reset/zx-reboot.o see include/linux/module.h for more information >> ERROR: "page_poisoning_enabled" [drivers/virtio/virtio_balloon.ko] undefined! ERROR: "ia64_delay_loop" [drivers/spi/spi-thunderx.ko] undefined! ERROR: "ia64_delay_loop" [drivers/net/phy/mdio-cavium.ko] undefined! --- 0-DAY kernel test infrastructure Open Source Technology Cente...

...ormation WARNING: modpost: missing MODULE_LICENSE() in drivers/pinctrl/pxa/pinctrl-pxa2xx.o see include/linux/module.h for more information WARNING: modpost: missing MODULE_LICENSE() in drivers/power/reset/zx-reboot.o see include/linux/module.h for more information >> ERROR: "page_poisoning_enabled" [drivers/virtio/virtio_balloon.ko] undefined! ERROR: "ia64_delay_loop" [drivers/spi/spi-thunderx.ko] undefined! ERROR: "ia64_delay_loop" [drivers/net/phy/mdio-cavium.ko] undefined! --- 0-DAY kernel test infrastructure Open Source Technology Cente...

...o/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -1110,8 +1110,12 @@ static int virtballoon_validate(struct virtio_device *vdev) /* Tell the host whether we care about poisoned pages. */ if (!want_init_on_free() && (IS_ENABLED(CONFIG_PAGE_POISONING_NO_SANITY) || - !page_poisoning_enabled())) + !page_poisoning_enabled())) { __virtio_clear_bit(vdev, VIRTIO_BALLOON_F_PAGE_POISON); + } else if (!virtio_has_feature(vdev, VIRTIO_BALLOON_F_PAGE_POISON)) { + __virtio_clear_bit(vdev, VIRTIO_BALLOON_F_FREE_PAGE_HINT); + __virtio_clear_bit(vdev, VIRTIO_BALLOON_F_REPORTING); + }...

...o/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -1110,8 +1110,12 @@ static int virtballoon_validate(struct virtio_device *vdev) /* Tell the host whether we care about poisoned pages. */ if (!want_init_on_free() && (IS_ENABLED(CONFIG_PAGE_POISONING_NO_SANITY) || - !page_poisoning_enabled())) + !page_poisoning_enabled())) { __virtio_clear_bit(vdev, VIRTIO_BALLOON_F_PAGE_POISON); + } else if (!virtio_has_feature(vdev, VIRTIO_BALLOON_F_PAGE_POISON)) { + __virtio_clear_bit(vdev, VIRTIO_BALLOON_F_FREE_PAGE_HINT); + __virtio_clear_bit(vdev, VIRTIO_BALLOON_F_REPORTING); + }...

...ble the feature in that configuration >> suggested as an initial step > > Thanks for the finding. > Similar to this option: I'm thinking could we make > walk_free_mem_block() simply return if that option is on? > That is, at the beginning of the function: > if (!page_poisoning_enabled()) > return; > Thought about it more, I think it would be better to put this logic to virtio_balloon: send_free_page_cmd_id(vb, &vb->start_cmd_id); if (page_poisoning_enabled() && !IS_ENABLED(CONFIG_PAGE_POISONING_NO_SANIT...

...ble the feature in that configuration >> suggested as an initial step > > Thanks for the finding. > Similar to this option: I'm thinking could we make > walk_free_mem_block() simply return if that option is on? > That is, at the beginning of the function: > if (!page_poisoning_enabled()) > return; > Thought about it more, I think it would be better to put this logic to virtio_balloon: send_free_page_cmd_id(vb, &vb->start_cmd_id); if (page_poisoning_enabled() && !IS_ENABLED(CONFIG_PAGE_POISONING_NO_SANIT...

...+ 3 files changed, 26 insertions(+), 7 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 1c77d88..d95e5d3 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2469,11 +2469,13 @@ extern int apply_to_page_range(struct mm_struct *mm, unsigned long address, extern bool page_poisoning_enabled(void); extern void kernel_poison_pages(struct page *page, int numpages, int enable); extern bool page_is_poisoned(struct page *page); +extern bool page_poison_val_get(u8 *val); #else static inline bool page_poisoning_enabled(void) { return false; } static inline void kernel_poison_pages(s...

...ner case that the start cmd is overridden by the stop cmd when the host has a delay in reading the start cmd. v27->v28: - mm/page_poison: Move PAGE_POISON to page_poison.c and add a function to expose page poison val to kernel modules. v26->v27: - add a new patch to expose page_poisoning_enabled to kernel modules - virtio-balloon: set poison_val to 0xaaaaaaaa, instead of 0xaa v25->v26: virtio-balloon changes only - remove kicking free page vq since the host now polls the vq after initiating the reporting - report_free_page_func: detach all the used buffers after s...

...Cc: Michal Hocko <mhocko at kernel.org> --- drivers/virtio/virtio_balloon.c | 255 +++++++++++++++++++++++++++++++----- include/uapi/linux/virtio_balloon.h | 7 + mm/page_poison.c | 6 + 3 files changed, 232 insertions(+), 36 deletions(-) Resend Change: - Expose page_poisoning_enabled to kernel modules diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index a1fb52c..5476725 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -51,9 +51,22 @@ MODULE_PARM_DESC(oom_pages, "pages to free on OOM"); static...

...Cc: Michal Hocko <mhocko at kernel.org> --- drivers/virtio/virtio_balloon.c | 255 +++++++++++++++++++++++++++++++----- include/uapi/linux/virtio_balloon.h | 7 + mm/page_poison.c | 6 + 3 files changed, 232 insertions(+), 36 deletions(-) Resend Change: - Expose page_poisoning_enabled to kernel modules diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index a1fb52c..5476725 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -51,9 +51,22 @@ MODULE_PARM_DESC(oom_pages, "pages to free on OOM"); static...

...ssy migrates between the source and destination. Linux compilation, i.e. make bzImage -j4, is performed during the Ping-Pong migration. The legacy case takes 5min14s to finish the compilation. With this optimization patched, it takes 5min12s. ChangeLog: v26->v27: - add a new patch to expose page_poisoning_enabled to kernel modules - virtio-balloon: set poison_val to 0xaaaaaaaa, instead of 0xaa v25->v26: virtio-balloon changes only - remove kicking free page vq since the host now polls the vq after initiating the reporting - report_free_page_func: detach all the used buffers after s...