search for: page_chunk_type_unused

...s/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 5e2e7cc..95c703e 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -56,11 +56,12 @@ static struct vfsmount *balloon_mnt; /* Types of pages to chunk */ #define PAGE_CHUNK_TYPE_BALLOON 0 +#define PAGE_CHUNK_TYPE_UNUSED 1 #define MAX_PAGE_CHUNKS 4096 struct virtio_balloon { struct virtio_device *vdev; - struct virtqueue *inflate_vq, *deflate_vq, *stats_vq; + struct virtqueue *inflate_vq, *deflate_vq, *stats_vq, *miscq; /* The balloon servicing is delegated to a freezable workqueue. */ struct work_struc...

...io/virtio_balloon.c > index 5e2e7cc..95c703e 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -56,11 +56,12 @@ static struct vfsmount *balloon_mnt; > > /* Types of pages to chunk */ > #define PAGE_CHUNK_TYPE_BALLOON 0 > +#define PAGE_CHUNK_TYPE_UNUSED 1 > > #define MAX_PAGE_CHUNKS 4096 > struct virtio_balloon { > struct virtio_device *vdev; > - struct virtqueue *inflate_vq, *deflate_vq, *stats_vq; > + struct virtqueue *inflate_vq, *deflate_vq, *stats_vq, *miscq; > > /* The balloon servicing is delegated to a fre...

...io/virtio_balloon.c > index 5e2e7cc..95c703e 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -56,11 +56,12 @@ static struct vfsmount *balloon_mnt; > > /* Types of pages to chunk */ > #define PAGE_CHUNK_TYPE_BALLOON 0 > +#define PAGE_CHUNK_TYPE_UNUSED 1 > > #define MAX_PAGE_CHUNKS 4096 > struct virtio_balloon { > struct virtio_device *vdev; > - struct virtqueue *inflate_vq, *deflate_vq, *stats_vq; > + struct virtqueue *inflate_vq, *deflate_vq, *stats_vq, *miscq; > > /* The balloon servicing is delegated to a fre...

...t; > > #endif > > > +/* Types of pages to chunk */ > > > +#define PAGE_CHUNK_TYPE_BALLOON 0 > > > + > > Doesn't look like you are ever adding more types in this > > patchset. Pls keep code simple, generalize it later. > > > "#define PAGE_CHUNK_TYPE_UNUSED 1" is added in another patch. I would say add the extra code there too. Or maybe we can avoid adding it altogether. > Types of page to chunk are treated differently. Different types of page > chunks are sent to the host via different protocols. > > 1) PAGE_CHUNK_TYPE_BALLOON: Ba...

...t; > > #endif > > > +/* Types of pages to chunk */ > > > +#define PAGE_CHUNK_TYPE_BALLOON 0 > > > + > > Doesn't look like you are ever adding more types in this > > patchset. Pls keep code simple, generalize it later. > > > "#define PAGE_CHUNK_TYPE_UNUSED 1" is added in another patch. I would say add the extra code there too. Or maybe we can avoid adding it altogether. > Types of page to chunk are treated differently. Different types of page > chunks are sent to the host via different protocols. > > 1) PAGE_CHUNK_TYPE_BALLOON: Ba...

...dif >>>> +/* Types of pages to chunk */ >>>> +#define PAGE_CHUNK_TYPE_BALLOON 0 >>>> + >>> Doesn't look like you are ever adding more types in this >>> patchset. Pls keep code simple, generalize it later. >>> >> "#define PAGE_CHUNK_TYPE_UNUSED 1" is added in another patch. > I would say add the extra code there too. Or maybe we can avoid > adding it altogether. I'm trying to have the two features( i.e. "balloon pages" and "unused pages") decoupled while trying to use common functions to deal with the c...

This patch series implements two optimizations: 1) transfer pages in chuncks between the guest and host; 2) transfer the guest unused pages to the host so that they can be skipped to migrate in live migration. Changes: v8->v9: 1) Split the two new features, VIRTIO_BALLOON_F_BALLOON_CHUNKS and VIRTIO_BALLOON_F_MISC_VQ, which were mixed together in the previous implementation; 2) Simpler

This patch series implements two optimizations: 1) transfer pages in chuncks between the guest and host; 2) transfer the guest unused pages to the host so that they can be skipped to migrate in live migration. Changes: v8->v9: 1) Split the two new features, VIRTIO_BALLOON_F_BALLOON_CHUNKS and VIRTIO_BALLOON_F_MISC_VQ, which were mixed together in the previous implementation; 2) Simpler

...s of pages to chunk */ > >>>> +#define PAGE_CHUNK_TYPE_BALLOON 0 > >>>> + > >>> Doesn't look like you are ever adding more types in this patchset. > >>> Pls keep code simple, generalize it later. > >>> > >> "#define PAGE_CHUNK_TYPE_UNUSED 1" is added in another patch. > > I would say add the extra code there too. Or maybe we can avoid adding > > it altogether. > > I'm trying to have the two features( i.e. "balloon pages" and "unused pages") > decoupled while trying to use common fun...

...s of pages to chunk */ > >>>> +#define PAGE_CHUNK_TYPE_BALLOON 0 > >>>> + > >>> Doesn't look like you are ever adding more types in this patchset. > >>> Pls keep code simple, generalize it later. > >>> > >> "#define PAGE_CHUNK_TYPE_UNUSED 1" is added in another patch. > > I would say add the extra code there too. Or maybe we can avoid adding > > it altogether. > > I'm trying to have the two features( i.e. "balloon pages" and "unused pages") > decoupled while trying to use common fun...

...; MIGRATE_TYPES; >> + migratetype++) { >> + do { >> + ret = inquire_unused_page_block(zone, >> + order, migratetype, &page); >> + if (!ret) { >> + pfn = (u64)page_to_pfn(page); >> + add_one_chunk(vb, vq, >> + PAGE_CHUNK_TYPE_UNUSED, >> + pfn, >> + (u64)(1 << order)); >> + } >> + } while (!ret); >> + } >> + } >> + } >> + miscq_out_hdr->flags |= VIRTIO_BALLOON_MISCQ_F_COMPLETE; > And where is miscq_out_hdr used? I see no add_outbuf anywhere. >...

...struct vfsmount *balloon_mnt; >> #endif >> >> +/* Types of pages to chunk */ >> +#define PAGE_CHUNK_TYPE_BALLOON 0 >> + > Doesn't look like you are ever adding more types in this > patchset. Pls keep code simple, generalize it later. > "#define PAGE_CHUNK_TYPE_UNUSED 1" is added in another patch. Types of page to chunk are treated differently. Different types of page chunks are sent to the host via different protocols. 1) PAGE_CHUNK_TYPE_BALLOON: Ballooned (i.e. inflated/deflated) pages to chunk. For the ballooned type, it uses the basic chunk msg forma...

...type++) { > > > + do { > > > + ret = inquire_unused_page_block(zone, > > > + order, migratetype, &page); > > > + if (!ret) { > > > + pfn = (u64)page_to_pfn(page); > > > + add_one_chunk(vb, vq, > > > + PAGE_CHUNK_TYPE_UNUSED, > > > + pfn, > > > + (u64)(1 << order)); > > > + } > > > + } while (!ret); > > > + } > > > + } > > > + } > > > + miscq_out_hdr->flags |= VIRTIO_BALLOON_MISCQ_F_COMPLETE; > > And where is mi...

...type++) { > > > + do { > > > + ret = inquire_unused_page_block(zone, > > > + order, migratetype, &page); > > > + if (!ret) { > > > + pfn = (u64)page_to_pfn(page); > > > + add_one_chunk(vb, vq, > > > + PAGE_CHUNK_TYPE_UNUSED, > > > + pfn, > > > + (u64)(1 << order)); > > > + } > > > + } while (!ret); > > > + } > > > + } > > > + } > > > + miscq_out_hdr->flags |= VIRTIO_BALLOON_MISCQ_F_COMPLETE; > > And where is mi...

On Thu, Apr 13, 2017 at 05:35:05PM +0800, Wei Wang wrote: > Add a new feature, VIRTIO_BALLOON_F_BALLOON_CHUNKS, which enables Let's find a better name here. VIRTIO_BALLOON_F_PAGE_CHUNK > the transfer of the ballooned (i.e. inflated/deflated) pages in > chunks to the host. > > The implementation of the previous virtio-balloon is not very > efficient, because the ballooned

On Thu, Apr 13, 2017 at 05:35:05PM +0800, Wei Wang wrote: > Add a new feature, VIRTIO_BALLOON_F_BALLOON_CHUNKS, which enables Let's find a better name here. VIRTIO_BALLOON_F_PAGE_CHUNK > the transfer of the ballooned (i.e. inflated/deflated) pages in > chunks to the host. > > The implementation of the previous virtio-balloon is not very > efficient, because the ballooned

This patch series implements the follow two things: 1) Optimization of balloon page transfer: instead of transferring balloon pages to host one by one, the new mechanism transfers them in chunks. 2) A mechanism to report info of guest unused pages: the pages have been unused at some time between when host sent command and when guest reported them. Host uses that by tracking memory changes and

This patch series implements the follow two things: 1) Optimization of balloon page transfer: instead of transferring balloon pages to host one by one, the new mechanism transfers them in chunks. 2) A mechanism to report info of guest unused pages: the pages have been unused at some time between when host sent command and when guest reported them. Host uses that by tracking memory changes and