search for: p_source

...@ let parse_libvirt_xml ?conn xml = (* Non-removable disk devices. *) let disks = let get_disks, add_disk = - let disks = ref [] and i = ref 0 in + let disks = ref [] and i = ref (-1) in let get_disks () = List.rev !disks in let add_disk qemu_uri format controller p_source = incr i; -- 2.17.1

...devices. *) > > let disks = > > let get_disks, add_disk = > > - let disks = ref [] and i = ref 0 in > > + let disks = ref [] and i = ref (-1) in > > let get_disks () = List.rev !disks in > > let add_disk qemu_uri format controller p_source = > > incr i; > > NACK. The s_disk_id field is supposed to just be a unique ID and > -i libvirt is giving it a unique value here so it's not wrong. I did not say it is wrong, just that the way IDs are allocated here is different than in other input modes. > The pr...

...@ let parse_libvirt_xml ?conn xml = (* Non-removable disk devices. *) let disks = let get_disks, add_disk = - let disks = ref [] and i = ref 0 in + let disks = ref [] and i = ref (-1) in let get_disks () = List.rev !disks in let add_disk qemu_uri format controller p_source = incr i; -- 2.17.1

...t; > let get_disks, add_disk = > > > > - let disks = ref [] and i = ref 0 in > > > > + let disks = ref [] and i = ref (-1) in > > > > let get_disks () = List.rev !disks in > > > > let add_disk qemu_uri format controller p_source = > > > > incr i; > > > > > > NACK. The s_disk_id field is supposed to just be a unique ID and > > > -i libvirt is giving it a unique value here so it's not wrong. > > > > I did not say it is wrong, just that the way IDs are allocat...

v2 was posted here: https://www.redhat.com/archives/libguestfs/2019-July/msg00115.html This also has links to earlier versions. v3: - The 01/11 patch in v2 included a bunch of unnecessary plus one necessary change to how input_password is passed around. I moved the necessary change into the final patch (implementing SSH password authentication) and dropped the rest. - The 01/11

Originally posted here: https://www.redhat.com/archives/libguestfs/2019-April/thread.html#00054 https://www.redhat.com/archives/libguestfs/2019-April/msg00076.html https://www.redhat.com/archives/libguestfs/2019-April/msg00126.html This is a rebase on top of current master branch with no other changes. The first patch in the old series was pushed a while back, and the last "TEMPORARY"

This is built on top of the following patch series: https://www.redhat.com/archives/libguestfs/2019-April/msg00054.html Rich.

v3 posted here: https://www.redhat.com/archives/libguestfs/2019-July/msg00200.html v4: - The first patch in the v3 series was just a trivial doc whitespace fix so I pushed it. - There's a new patch using the nbdkit-retry-filter. This is not actually upstream in nbdkit but we know enough about how it will work. - Rebased against master and reran the tests. Rich.

This series (except the last one) changes virt-v2v to use nbdkit for several input modes: -i vmx -it vddk: No change in functionality, as this already uses nbdkit-vddk-plugin, but the code is refactored for the other modes to use. -i libvirtxml: Use nbdkit-curl-plugin instead of qemu curl. vCenter: Use nbdkit-curl-plugin instead of qemu curl. xen: Use nbdkit-ssh-plugin instead of qemu

This isn't quite the full thing. I think that Pino is also working on replacing the ssh and scp commands in the v2v/input_vmx.ml file with libssh. Without those changes, -i vmx will still issue raw ssh and scp commands, which will use ssh-agent (or keyboard-interactive). The Xen input method doesn't use raw ssh and scp commands, so that one is OK. Rich.

...> (* Non-removable disk devices. *) > let disks = > let get_disks, add_disk = > - let disks = ref [] and i = ref 0 in > + let disks = ref [] and i = ref (-1) in > let get_disks () = List.rev !disks in > let add_disk qemu_uri format controller p_source = > incr i; NACK. The s_disk_id field is supposed to just be a unique ID and -i libvirt is giving it a unique value here so it's not wrong. The problem with this bug is that the output driver used the s_disk_id field assuming it was a unique, monotonically increasing number count...

...let disks = > > > let get_disks, add_disk = > > > - let disks = ref [] and i = ref 0 in > > > + let disks = ref [] and i = ref (-1) in > > > let get_disks () = List.rev !disks in > > > let add_disk qemu_uri format controller p_source = > > > incr i; > > > > NACK. The s_disk_id field is supposed to just be a unique ID and > > -i libvirt is giving it a unique value here so it's not wrong. > > I did not say it is wrong, just that the way IDs are allocated here > is different than...

Patch 1 was previously posted here: https://www.redhat.com/archives/libguestfs/2020-June/msg00086.html to handle this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1848862 I was able to observe this bug and for me at least disabling readahead seems to cure it. Patches 2 and 3 are simplifications, removing a now-undocumented feature of virt-v2v-copy-to-local and thus simplifying greatly the

These patches add the --password-file parameter, allowing you to pass a single password via a file. https://bugzilla.redhat.com/show_bug.cgi?id=1158526 Rich.

See earlier thread on libvir-list: https://www.redhat.com/archives/libvir-list/2015-September/thread.html#00201 Libvirt >= 1.2.20 supplies the correct dcPath parameter. If it is available in the libvirt XML, use it, otherwise fall back to the old method of trying to guess it from the vpx:// path. Patches 1, 2 and 4 are just refactoring around this change. Rich.

v2 -> v3: - Changes to the Curl API suggested by Pino.

v1 -> v2: - Fixed the bug with precedence of if / @. - Add some imperative list operators inspired by Perl, and use those for constructing the Curl arguments, and more. Rich.

The first commit removes the --dcpath parameter, which just makes the following stuff simpler. Since libvirt has supported getting datacenterpath from VMware since Oct 2015, it's time to drop this hairy parameter. The rest is quite a complicated series of refactorings, followed by a very simple change to add handling of snapshots taken from old virt-v2v. Rich.

Use -ip instead of --password-file, and various refactorings. It strikes me that we should probably deprecate and eventually remove virt-v2v-copy-to-local. With the introduction of the new SSH and VDDK transports, and with RHEL 5 Xen becoming more irrelevant, it's no longer needed. Rich.

v2 -> v3: - Renamed List.assoc_ -> List.assoc_lbl. - Rebased on top of current master branch. Rich.