search for: p_bootabl

...--- 1 file changed, 35 insertions(+), 11 deletions(-) diff --git a/resize/resize.ml b/resize/resize.ml index 8683df7..a2670e5 100644 --- a/resize/resize.ml +++ b/resize/resize.ml @@ -48,6 +48,7 @@ type partition = { p_part : G.partition; (* SOURCE partition data from libguestfs. *) p_bootable : bool; (* Is it bootable? *) p_mbr_id : int option; (* MBR ID, if it has one. *) + p_gpt_type : string option; (* GPT ID, if it has one. *) p_type : partition_content; (* Content type and content size. *) (* What we're going to do: *) @@ -75,7 +76,14 @@ l...

...estore them after the partition copy. --- resize/resize.ml | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/resize/resize.ml b/resize/resize.ml index 191be83..c1794ed 100644 --- a/resize/resize.ml +++ b/resize/resize.ml @@ -49,6 +49,7 @@ type partition = { p_bootable : bool; (* Is it bootable? *) p_id : partition_id; (* Partition (MBR/GPT) ID. *) p_type : partition_content; (* Content type and content size. *) + p_label : string option; (* Label/name. *) (* What we're going to do: *) mutable p_operation : parti...

Hi, attached there are few patches to implement a way to get the label of GPT partitions (refactoring an existing function and adding a new daemon API) and using it in virt-resize to restore them when copying partitions. Thanks, Pino Toscano (3): daemon: parted: refactor sgdisk info parsing code New API: part-get-name (RHBZ#593511). resize: preserve GPT partition names (RHBZ#1060404).

...(g#part_get_gpt_attributes "/dev/sda" part_num) + with G.Error _ -> None in let guid = match parttype with | MBR -> None @@ -502,7 +509,7 @@ read the man page virt-resize(1). { p_name = name; p_part = part; p_bootable = bootable; p_id = id; p_type = typ; - p_label = label; p_guid = guid; + p_label = label; p_guid = guid; p_attributes = attributes; p_operation = OpCopy; p_target_partnum = 0; p_target_start = 0L; p_target_end = 0L } ) parts in @@ -1150,6 +115...

...(g#part_get_gpt_attributes "/dev/sda" part_num) + with G.Error _ -> None in let guid = match parttype with | MBR -> None @@ -502,7 +509,7 @@ read the man page virt-resize(1). { p_name = name; p_part = part; p_bootable = bootable; p_id = id; p_type = typ; - p_label = label; p_guid = guid; + p_label = label; p_guid = guid; p_attributes = attributes; p_operation = OpCopy; p_target_partnum = 0; p_target_start = 0L; p_target_end = 0L } ) parts in @@ -1150,6 +115...

Hi all, Here is the latest version of the series addressing Pino's comments. Cédric Bosdonnat (3): daemon: make sgdisk_info_extract_uuid_field more generic New APIs: part_set_gpt_attributes and part_get_gpt_attributes resize: copy GPT partition flags daemon/parted.ml | 45 +++++++++++++++++++++++++++++++++++---------- daemon/parted.mli | 3 +++

...1 deletions(-) > > diff --git a/resize/resize.ml b/resize/resize.ml > index 8683df7..a2670e5 100644 > --- a/resize/resize.ml > +++ b/resize/resize.ml > @@ -48,6 +48,7 @@ type partition = { > p_part : G.partition; (* SOURCE partition data from libguestfs. *) > p_bootable : bool; (* Is it bootable? *) > p_mbr_id : int option; (* MBR ID, if it has one. *) > + p_gpt_type : string option; (* GPT ID, if it has one. *) > p_type : partition_content; (* Content type and content size. *) > > (* What we're going to do...

...rt.G.part_end /^ sectsize) + ((p.p_part.G.part_end +^ 1L -^ p.p_part.G.part_start) /^ sectsize); + printf "\ttarget partition sector data: %Ld-%Ld (%Ld sectors)\n" + p.p_target_start p.p_target_end (p.p_target_end +^ 1L -^ p.p_target_start); printf "\tbootable: %b\n" p.p_bootable; printf "\tpartition ID: %s\n" (match p.p_id with -- 2.1.0

Hi all, Here is v3 of the series, taking Richard's comments in account. Cédric Bosdonnat (3): daemon: make sgdisk_info_extract_uuid_field more generic New APIs: part_set_gpt_attributes and part_get_gpt_attributes resize: copy GPT partition flags daemon/parted.ml | 45 +++++++++++++++++++++++++++++++++++---------- daemon/parted.mli | 2 ++ generator/actions_core.ml

Hi all, Here is the series fixing the bug I mentioned on IRC regarding the GPT attribute flags to copy to the new disk in a virt-resize. Cédric Bosdonnat (3): daemon: make sgdisk_info_extract_uuid_field more generic New APIs: part_set_gpt_attributes and part_get_gpt_attributes resize: copy GPT partition flags daemon/parted.ml | 34 +++++++++++++++++++++++++++-------

...; overwrites the partition + * table in the first sector of an extended partition if a partition + * is changed from primary to extended. Thus we need to set the + * MBR ID before doing the copy so sfdisk doesn't corrupt things. + *) + let set_partition_bootable_and_id p = + if p.p_bootable then + g#part_set_bootable "/dev/sdb" p.p_target_partnum true; + + may (g#part_set_name "/dev/sdb" p.p_target_partnum) p.p_label; + may (g#part_set_gpt_guid "/dev/sdb" p.p_target_partnum) p.p_guid; + + match parttype, p.p_id with + | GPT, GP...

...ize.ml @@ -1078,7 +1078,7 @@ read the man page virt-resize(1). *) p_name = ""; p_part = { G.part_num = 0l; part_start = 0L; part_end = 0L; - part_size = 0L }; + part_size = 0L; part_type = "" }; p_bootable = false; p_id = No_ID; p_type = ContentUnknown; p_label = None; p_guid = None; -- 2.1.0

virt-resize didn't preserve the per-partition GPT GUID. Now that guests using UEFI are becoming common (basically it's the default on aarch64) we need to take into account that sometimes the partition GUID is used by the bootloader NVRAM variables to identify the boot partition, so it must be preserved across resize. This bug caused the 'virt-builder --size' option to fail on

...p.p_part.G.part_size; + printf "\tpartition sector data: %Ld-%Ld\n" + (p.p_part.G.part_start /^ sectsize) (p.p_part.G.part_end /^ sectsize); + printf "\ttarget partition sector data: %Ld-%Ld \n" + p.p_target_start p.p_target_end; printf "\tbootable: %b\n" p.p_bootable; printf "\tpartition ID: %s\n" (match p.p_id with @@ -545,7 +549,7 @@ read the man page virt-resize(1). if verbose then ( printf "%d partitions found\n" (List.length partitions); - List.iter debug_partition partitions + List.iter (debug_partition ~sectsi...

...mp smp; g#set_network network; (* Make sure to turn SELinux off to avoid awkward interactions diff --git a/resize/resize.ml b/resize/resize.ml index b2802c7..ff10fca 100644 --- a/resize/resize.ml +++ b/resize/resize.ml @@ -1210,17 +1210,8 @@ read the man page virt-resize(1). if p.p_bootable then g#part_set_bootable "/dev/sdb" p.p_target_partnum true; - (match p.p_label with - | Some label -> - g#part_set_name "/dev/sdb" p.p_target_partnum label; - | None -> () - ); - - (match p.p_guid with - | Some guid -> -...

...e_str with + | "primary" -> PrimaryPartition + | "extended" -> ExtendedPartition + | "logical" -> LogicalPartition + | str -> NoTypePartition + in { p_name = name; p_part = part; p_bootable = bootable; p_id = id; p_type = typ; - p_label = label; p_guid = guid; + p_label = label; p_guid = guid; p_mbr_p_type = mbr_part_type; p_operation = OpCopy; p_target_partnum = 0; p_target_start = 0L; p_target_end = 0L } ) parts in + (* Fi...

Hi Rich, This is v2 series to add support for resizing MBR logical partitions. I found the reason of problem in v1 that parted reports error when adding logical partitions, is that logical partitions are not aligned to 2 sectors. This problem doesn't appear in v2. This is for early review, because of: 1. I'm not sure the splitting of patches is appropriate or not, but it's much

...rt.G.part_end /^ sectsize) + ((p.p_part.G.part_end -^ p.p_part.G.part_start) /^ sectsize +^ 1L); + printf "\ttarget partition sector data: %Ld-%Ld (%Ld sectors)\n" + p.p_target_start p.p_target_end (p.p_target_end -^ p.p_target_start +^ 1L); printf "\tbootable: %b\n" p.p_bootable; printf "\tpartition ID: %s\n" (match p.p_id with -- 2.1.0

On Tue, Jul 15, 2014 at 09:01:47AM +0100, Richard W.M. Jones wrote: > The answer is I don't know. But there are a few things you can try: > > (1) Most importantly, enable tracing (export LIBGUESTFS_TRACE=1) and > get a list of operations that are performed in the order they are > performed. This is vital for debugging this. > > (2) When the error happens, run

...ead the man page virt-resize(1). > *) > p_name = ""; > p_part = { G.part_num = 0l; part_start = 0L; part_end = 0L; > - part_size = 0L }; > + part_size = 0L; part_type = "" }; > p_bootable = false; p_id = No_ID; p_type = ContentUnknown; > p_label = None; p_guid = None; Better add this information directly in the type partition, possibly also making use of type partition_type. Also this could go in a different patch than the above changes to get the primary/extended/e...