search for: p2v_config

These are a prelude to fixing https://bugzilla.redhat.com/show_bug.cgi?id=1590220 A lot of the virt-p2v configuration code was duplicated manually. These changes make sure that most of it is generated. Rich.

...Fedora) - create an own .gitignore for p2v This is still not complete, although it does a number of important changes, and it still makes p2v usable within libguestfs. Pino Toscano (6): p2v: move kernel config to perl script p2v: move kernel config POD docs to perl script generator: remove p2v_config p2v: split gitignore p2v: tests: switch windows image with local fedora one p2v: tests: use a local blank-part disk image .gitignore | 37 -- configure.ac | 5 + docs/C_SOURCE_FILES | 3 - generator/Makefile.am | 3 - generator/main.ml...

...pt to do this job, mostly at build time. This is done to rely less on the generator for p2v, and because the generation of these sources is quick enough that it can be done at build time (instead of shipping the generated sources in dist tarballs). The generate-p2v-config.pl mimics what generator/p2v_config.ml -- namings, and general structure are kept close to that for comparison. The two C sources are created at build time by the script; however, the p2v-config.h header is generated at configure time: this is done because p2v-config.h is included by p2v.h (another header), which in turn is included...

On Mon, Jul 01, 2019 at 06:10:48PM +0200, Pino Toscano wrote: > On Monday, 10 June 2019 17:35:52 CEST Richard W.M. Jones wrote: > > So while I'm not a massive fan of git submodules, now that I have used > > them a few times with riscv stuff, they do solve a certain problem as > > long as they are managed carefully. I think the common code and the > > generator are

...Makefile sparsify/Makefile sysprep/Makefile test-data/Makefile diff --git a/generator/Makefile.am b/generator/Makefile.am index 07872d49c..676c08ce5 100644 --- a/generator/Makefile.am +++ b/generator/Makefile.am @@ -105,6 +105,8 @@ sources = \ p2v_config.mli \ ruby.ml \ ruby.mli \ + rust.ml \ + rust.mli \ structs.ml \ structs.mli \ tests_c_api.ml \ @@ -163,6 +165,7 @@ objects = \ lua.cmo \ GObject.cmo \ golang.cmo \ + rust.cmo \ bindtests.cmo \ errnostring.cmo \ customize.cmo \ diff --git a/generator/bindtests.ml b/generator/b...

...d to be generated in virt-p2v. > > > > I'm actually solving in a different way, i.e. avoiding altogether the > > generator for p2v stuff. > > Hmm. There are parts of the current generator that apply to virt-p2v. Which ones? As I explained already, I found only two: - p2v_config.ml, which is entirely p2v-specific; when converted to another way, it can be dropped without affecting the rest of the generated sources of libguestfs - authors.ml, shared with libguestfs to generate the top-level AUTHORS file; I did not work on that yet -- my idea for it is to simply provi...

...UP_FREE, CLEANUP_FREE_STRING_LIST, CLEANUP_PCLOSE, CLEANUP_FCLOSE, and CLEANUP_XMLFREETEXTWRITER) 4) other internal macros, i.e. guestfs-utils.h 5) the list of credits generated by the generator (i.e. generator/authors.ml) 6) the p2v configuration generated by the generator (i.e. generator/p2v_config.ml) 7) test images/data (phony images, and virt-tools) 8) the miniexpect module, right now out of the p2v subdirectory Possible solutions may/might be: 1) add own submodule (use its own set of modules) 2) copy/implement them them locally: luckly they are not many, so inlining them in configure....

...E, and CLEANUP_XMLFREETEXTWRITER) > 4) other internal macros, i.e. guestfs-utils.h Common code is a bit tricker, as is ... > 5) the list of credits generated by the generator > (i.e. generator/authors.ml) > 6) the p2v configuration generated by the generator > (i.e. generator/p2v_config.ml) ... the generator and ... > 7) test images/data (phony images, and virt-tools) test data. > 8) the miniexpect module, right now out of the p2v subdirectory This is only used by virt-p2v I think, so it could go with virt-p2v or be made into a separate project. > Possible solutions...

...opied, with ~9K more of straight copies of libxml2-cleanups.c + libxml2-writer-macros.h from common/utils. > > 5) the list of credits generated by the generator > > (i.e. generator/authors.ml) > > 6) the p2v configuration generated by the generator > > (i.e. generator/p2v_config.ml) > > ... the generator and ... (5) is more shared with the rest, while (6) is basically p2v-only material. > > 7) test images/data (phony images, and virt-tools) > > test data. Luckly this is easy to recreate locally. > > 8) the miniexpect module, right now out of t...

My contention is that the libguestfs git repository is too large and unwieldy. There are too many separate, unrelated projects and as a result of that the source has too many dependencies and takes too long to build and test. The project divides (sort of) naturally into layers -- the library, the bindings, the various virt tools -- and could be split along those lines into separate projects

...> > > > I'm actually solving in a different way, i.e. avoiding altogether the > > > generator for p2v stuff. > > > > Hmm. There are parts of the current generator that apply to virt-p2v. > > Which ones? As I explained already, I found only two: > - p2v_config.ml, which is entirely p2v-specific; when converted to > another way, it can be dropped without affecting the rest of the > generated sources of libguestfs > - authors.ml, shared with libguestfs to generate the top-level AUTHORS > file; I did not work on that yet -- my idea for it...

On Mon, Jul 08, 2019 at 10:04:57AM +0100, Richard W.M. Jones wrote: >On Mon, Jul 08, 2019 at 10:49:55AM +0200, Martin Kletzander wrote: >> On Mon, Jul 08, 2019 at 10:10:10AM +0200, Pino Toscano wrote: >> >On Saturday, 6 July 2019 13:03:24 CEST Martin Kletzander wrote: >> >>Just one thing, the Cargo.toml includes a version under which the crate would be >>

...d 'no' when you expected 'yes'" echo "then you should check the preceding messages." diff --git a/generator/Makefile.am b/generator/Makefile.am index 07872d49c..676c08ce5 100644 --- a/generator/Makefile.am +++ b/generator/Makefile.am @@ -105,6 +105,8 @@ sources = \ p2v_config.mli \ ruby.ml \ ruby.mli \ + rust.ml \ + rust.mli \ structs.ml \ structs.mli \ tests_c_api.ml \ @@ -163,6 +165,7 @@ objects = \ lua.cmo \ GObject.cmo \ golang.cmo \ + rust.cmo \ bindtests.cmo \ errnostring.cmo \ customize.cmo \ diff --git a/generator/bindtests.ml b/generator/b...

I fixed the patch I submitted before based on comments, and there are some commits which are merged or divided. So, I will re-send all the patches. Regards, Hiroyuki Katsura

...Makefile sparsify/Makefile sysprep/Makefile test-data/Makefile diff --git a/generator/Makefile.am b/generator/Makefile.am index 07872d49c..676c08ce5 100644 --- a/generator/Makefile.am +++ b/generator/Makefile.am @@ -105,6 +105,8 @@ sources = \ p2v_config.mli \ ruby.ml \ ruby.mli \ + rust.ml \ + rust.mli \ structs.ml \ structs.mli \ tests_c_api.ml \ @@ -163,6 +165,7 @@ objects = \ lua.cmo \ GObject.cmo \ golang.cmo \ + rust.cmo \ bindtests.cmo \ errnostring.cmo \ customize.cmo \ diff --git a/generator/bindtests.ml b/generator/b...