Displaying 3 results from an estimated 3 matches for "ownwriter".
2010 Jul 21
0
[LLVMdev] MC-JIT
...iter_ and Writer? I don't know of any rules against
modifying parameters.
...
- llvm::OwningPtr<MCObjectWriter> Writer(getBackend().createObjectWriter(OS));
- if (!Writer)
- report_fatal_error("unable to create object writer!");
+
+ llvm::OwningPtr<MCObjectWriter> OwnWriter(0);
+ MCObjectWriter *Writer = Writer_;
+ if (Writer == 0) {
+ //no custom Writer_ : create the default one life-managed by OwningPtr
+ OwnWriter.reset(getBackend().createObjectWriter(OS));
+ Writer = OwnWriter.get();
+ if (!Writer)
+ report_fatal_error("unable to create obj...
2010 Jul 20
2
[LLVMdev] MC-JIT
New patch taking Eli's comments into account.
Olivier.
On Tue, Jul 20, 2010 at 11:09 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Tue, Jul 20, 2010 at 1:36 PM, Olivier Meurant
> <meurant.olivier at gmail.com> wrote:
>>> Seems reasonable, but I haven't looked at the code yet. I would
>>> suggest trying to split your work up into separate
2010 Jul 21
1
[LLVMdev] MC-JIT
...rules against
> modifying parameters.
>
> ...
>
> - llvm::OwningPtr<MCObjectWriter> Writer(getBackend().createObjectWriter(OS));
> - if (!Writer)
> - report_fatal_error("unable to create object writer!");
> +
> + llvm::OwningPtr<MCObjectWriter> OwnWriter(0);
> + MCObjectWriter *Writer = Writer_;
> + if (Writer == 0) {
> + //no custom Writer_ : create the default one life-managed by OwningPtr
> + OwnWriter.reset(getBackend().createObjectWriter(OS));
> + Writer = OwnWriter.get();
> + if (!Writer)
> + report_fat...