search for: owningmodulecontainer

...lpLogHeapFailure() Unknown ntdll.dll!string "Enabling heap debug options\n"() Unknown ucrtbase.dll!free() Unknown ConsoleEngine.exe!llvm::Function::`vector deleting destructor'(unsigned int) C++ ConsoleEngine.exe!llvm::Module::~Module(void) C++ ConsoleEngine.exe!llvm::MCJIT::OwningModuleContainer::freeModulePtrSet(class llvm::SmallPtrSet<class llvm::Module *,4> &) C++ ConsoleEngine.exe!llvm::MCJIT::~MCJIT(void) C++ ConsoleEngine.exe!llvm::MCJIT::`vector deleting destructor'(unsigned int) C++ -- Debug Mode stack trace ntdll.dll!RtlpBreakPointHeap() Unknown ntdll.dll!stri...

...; ntdll.dll!string "Enabling heap debug options\n"() Unknown > ucrtbase.dll!free() Unknown > ConsoleEngine.exe!llvm::Function::`vector deleting destructor'(unsigned > int) C++ > ConsoleEngine.exe!llvm::Module::~Module(void) C++ > ConsoleEngine.exe!llvm::MCJIT::OwningModuleContainer::freeModulePtrSet(class > llvm::SmallPtrSet<class llvm::Module *,4> &) C++ > ConsoleEngine.exe!llvm::MCJIT::~MCJIT(void) C++ > ConsoleEngine.exe!llvm::MCJIT::`vector deleting destructor'(unsigned > int) C++ > > -- Debug Mode stack trace > ntdll.dll!RtlpBreakPo...

...JIT inherits implementations of the FindFunctionNamed and runStaticConstructorsDestructors methods from ExecutionEngine which use the old Modules vector, so you'll need to override these in MCJIT. (The implementations are fairly trivial.) Beyond that I just have a couple of questions. First, OwningModuleContainer::hasModuleBeenAdded seems wrong. It seems to me that it should be equivalent to OwningModuleContain::ownsModule. That is, everything that has been loaded or finalized has also been added. Your implementation checks "has been added but not loaded" but it doesn't seem like that's...

..."Enabling heap debug options\n"() Unknown >> ucrtbase.dll!free() Unknown >> ConsoleEngine.exe!llvm::Function::`vector deleting >> destructor'(unsigned int) C++ >> ConsoleEngine.exe!llvm::Module::~Module(void) C++ >> ConsoleEngine.exe!llvm::MCJIT::OwningModuleContainer::freeModulePtrSet(class >> llvm::SmallPtrSet<class llvm::Module *,4> &) C++ >> ConsoleEngine.exe!llvm::MCJIT::~MCJIT(void) C++ >> ConsoleEngine.exe!llvm::MCJIT::`vector deleting destructor'(unsigned >> int) C++ >> >> -- Debug Mode stack trace &g...

Hi Andy, Here is the patch. it incorporates: 1) your latest patch to SVN. 2) mcjit-module-state-optimization.patch. 3) the PtrSet changes. Other than the OwnedModules implementation there were other differences between 1) and 2), especially in the Finalize* functions, so please review that I got the right code. I got bitten by subtle bugs arising from MCJIT inheriting from EE: First, MCJIT

...debug options\n"() Unknown >>> ucrtbase.dll!free() Unknown >>> ConsoleEngine.exe!llvm::Function::`vector deleting >>> destructor'(unsigned int) C++ >>> ConsoleEngine.exe!llvm::Module::~Module(void) C++ >>> ConsoleEngine.exe!llvm::MCJIT::OwningModuleContainer::freeModulePtrSet(class >>> llvm::SmallPtrSet<class llvm::Module *,4> &) C++ >>> ConsoleEngine.exe!llvm::MCJIT::~MCJIT(void) C++ >>> ConsoleEngine.exe!llvm::MCJIT::`vector deleting destructor'(unsigned >>> int) C++ >>> >>> -- D...

...ticConstructorsDestructors methods from ExecutionEngine which use the > old Modules vector, so you’ll need to override these in MCJIT. (The > implementations are fairly trivial.)**** > > ** ** > > Beyond that I just have a couple of questions.**** > > ** ** > > First, OwningModuleContainer::hasModuleBeenAdded seems wrong. It seems to > me that it should be equivalent to OwningModuleContain::ownsModule. That > is, everything that has been loaded or finalized has also been added. Your > implementation checks “has been added but not loaded” but it doesn’t seem > like that...

...t;() Unknown >>>> ucrtbase.dll!free() Unknown >>>> ConsoleEngine.exe!llvm::Function::`vector deleting >>>> destructor'(unsigned int) C++ >>>> ConsoleEngine.exe!llvm::Module::~Module(void) C++ >>>> ConsoleEngine.exe!llvm::MCJIT::OwningModuleContainer::freeModulePtrSet(class >>>> llvm::SmallPtrSet<class llvm::Module *,4> &) C++ >>>> ConsoleEngine.exe!llvm::MCJIT::~MCJIT(void) C++ >>>> ConsoleEngine.exe!llvm::MCJIT::`vector deleting destructor'(unsigned >>>> int) C++ >>>&g...