search for: ovirtsdk4

- add a no-op Connection.close(), as it called explicitly in the close() callback of the nbdkit plugin (rhv-upload-plugin.py) - fix the types of the 'id' variables, which are strings --- v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/__init__.py | 3 +++ v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/types.py | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/__init__.py b/v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/__init__.py index cc4224ccd..2ceb07c0c 100644 ---...

Check earlier whether the ovirtsdk4 Python can be imported correctly, to avoid errors later on during the migration. --- v2v/output_rhv_upload.ml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/v2v/output_rhv_upload.ml b/v2v/output_rhv_upload.ml index 0152b8d5a..63fa2411a 100644 --- a/v2v/output_rhv_upload.ml +++ b/v2v/o...

...ds", time.time() - > > start) > > > > Maybe this was the real error? (using , instead of %) I fixed this in a later build. However the error we're talking about here seems to be unrelated to it. ... > > ', ' File "/usr/lib64/python2.7/site-packages/ovirtsdk4/services.py", > > line 37334, in remove > > self._internal_remove(headers, query, wait) > > ', ' File "/usr/lib64/python2.7/site-packages/ovirtsdk4/service.py", line > > 271, in _internal_remove > > return future.wait() if wait else futu...

Add the missing objects, methods, variables, and relations among the various objects. Followup/fixes commit c49aa4fe01aac82d4776dd2a3524ce16e6deed06, and commit 8118f28b6ff93c11f92fd65873285c2eba10ea0a. --- .../ovirtsdk4/__init__.py | 25 +++++++++++++------ .../ovirtsdk4/types.py | 19 ++++++++++---- 2 files changed, 31 insertions(+), 13 deletions(-) diff --git a/v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/__init__.py b/v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/__init__....

...#39;Traceback (most recent call last): ', ' File "/var/tmp/v2v.sZm0my/rhv-upload-plugin.py", line 577, in close ', ' File "/var/tmp/v2v.sZm0my/rhv-upload-plugin.py", line 516, in delete_disk_on_failure ', ' File "/usr/lib64/python2.7/site-packages/ovirtsdk4/services.py", line 37334, in remove self._internal_remove(headers, query, wait) ', ' File "/usr/lib64/python2.7/site-packages/ovirtsdk4/service.py", line 271, in _internal_remove return future.wait() if wait else future ', ' File "/usr/lib64/python2.7/s...

...> From: "Richard W.M. Jones" <rjones@redhat.com> > Date: Mon, 15 Oct 2018 16:07:52 +0100 > Subject: [PATCH] v2v: -o rhv-upload: Test using HTTP/1.1 protocol. > > Fixes commit b54b58c44e3f1f54a05117c758eaa21d9f1085f0. > > Thanks: Nir Soffer. > --- > .../ovirtsdk4/__init__.py | 28 ++++++++++++++++--- > 1 file changed, 24 insertions(+), 4 deletions(-) > > diff --git a/v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/__init__.py b/v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/__init__.py > index b5f739471..84b9d56aa 100644 > --- a/v...

v1 was here: https://www.redhat.com/archives/libguestfs/2018-September/msg00121.html v2: - Rewrote patch 2 from scratch so it incorporates Nir's suggestions. - Add fake module to EXTRA_DIST. - Retested. Unfortunately I am no longer able to test the ordinary conversion path because ovirtsdk4 is incompatible with Fedora 29 / Python 3.7: https://bugzilla.redhat.com/show_bug.cgi?id=1622043 so I'm unable to verify that the changes (esp patch 2) don't break this. Rich.

Previously this output method was almost completely untested. This commit adds a fake ovirtsdk4 module so we can test the -o rhv-upload method fairly completely without needing an actual oVirt instance around. --- v2v/Makefile.am | 4 + .../ovirtsdk4/__init__.py | 146 ++++++++++++++++++ .../ovirtsdk4/types.py | 125 +...

...imports at the top PEP 8: adapt empty lines tests: find all the Python scripts for syntax checks -o rhv-upload: remove unused Python imports Revamp check for Python code style config.sh.in | 1 + m4/guestfs-progs.m4 | 3 + .../ovirtsdk4/__init__.py | 39 +++++-- .../ovirtsdk4/types.py | 40 ++++--- v2v/rhv-upload-createvm.py | 20 ++-- v2v/rhv-upload-deletedisks.py | 14 +-- v2v/rhv-upload-plugin.py | 105 ++++++++++++------ v2v/...

In the precheck script, check that the target cluster actually exists. This will avoid errors when creating the VM after the data copying. --- v2v/rhv-upload-precheck.py | 10 ++++++++++ v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/__init__.py | 7 +++++++ 2 files changed, 17 insertions(+) diff --git a/v2v/rhv-upload-precheck.py b/v2v/rhv-upload-precheck.py index 2798a29dd..b79f91b4a 100644 --- a/v2v/rhv-upload-precheck.py +++ b/v2v/rhv-upload-precheck.py @@ -70,4 +70,14 @@ if len(vms) > 0: raise RuntimeError("...

This adds a test of -o rhv-upload. Obviously for an upstream test we cannot require a working oVirt server. This test works by faking the ovirtsdk4 Python module, setting PYTHONPATH so that the fake module is picked up instead of the real module (if installed). However it's more complex than that because the nbdkit plugin also expects to talk to a working imageio HTTPS server. Therefore the fake ovirtsdk4 module also starts a web server...

On Thu, Sep 20, 2018 at 11:51 AM Richard W.M. Jones <rjones@redhat.com> wrote: > Previously this output method was almost completely untested. > > This commit adds a fake ovirtsdk4 module so we can test the > -o rhv-upload method fairly completely without needing an actual > oVirt instance around. > --- > v2v/Makefile.am | 4 + > .../ovirtsdk4/__init__.py | 146 ++++++++++++++++++ > .../ovirtsdk4/types.py...

Get the CPU architecture of the specified cluster, and error out in case the architecture of the guest is not the same as the cluster one. --- .../ovirtsdk4/types.py | 16 ++++++++++++++++ v2v/output_rhv_upload.ml | 18 +++++++++++++++++- v2v/rhv-upload-precheck.py | 5 +++++ 3 files changed, 38 insertions(+), 1 deletion(-) diff --git a/tests/test-v2v-o-rhv-upload-module/ovirtsdk4/type...

It will be used to do extra checks in the output before copying the disks. Partially revert commit 3bafec4e693a25ef1c84abc0fd1bc3251862c7de. --- v2v/output_glance.ml | 2 +- v2v/output_json.ml | 2 +- v2v/output_libvirt.ml | 2 +- v2v/output_local.ml | 2 +- v2v/output_null.ml | 2 +- v2v/output_openstack.ml | 2 +- v2v/output_qemu.ml | 2 +- v2v/output_rhv.ml

...is happens on RHEL 7.6 in particular. We can fix this by using an > alternate method to fetch the header, which will return None instead > of throwing an exception if the header doesn't exist. See: > https://stackoverflow.com/a/19255675 > --- > v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/__init__.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/__init__.py b/v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/__init__.py > index 84b9d56aa..8d1058d67 100644 > --- a/v2v/test-v2v-o-rhv-upload-module/ovirtsdk4...

On Thursday, 19 September 2019 08:23:46 CEST Pino Toscano wrote: > Add the missing objects, methods, variables, and relations among the > various objects. > > Followup/fixes commit c49aa4fe01aac82d4776dd2a3524ce16e6deed06, and > commit 8118f28b6ff93c11f92fd65873285c2eba10ea0a. > --- Consider the following change squashed to this commit: diff --git

On Fri, Dec 7, 2018, 10:34 Richard W.M. Jones <rjones@redhat.com wrote: > On Fri, Dec 07, 2018 at 02:44:21AM +0200, Nir Soffer wrote: > > Fix rhv-cafile option access, broken by commit 6694028f9827 (v2v: -o > > rhv-upload: Only set SSL context for https connections). > > Ugh yes indeed. Strong typing FTW _again_ "pylint -E" may detect such issues. ... >

...9; File "/var/tmp/v2v.sZm0my/rhv-upload-plugin.py", line 516, in > delete_disk_on_failure > This looks like failure flow - but there is no info here on the real failure. We need to understand what was that failure. > ', ' File "/usr/lib64/python2.7/site-packages/ovirtsdk4/services.py", > line 37334, in remove > self._internal_remove(headers, query, wait) > ', ' File "/usr/lib64/python2.7/site-packages/ovirtsdk4/service.py", line > 271, in _internal_remove > return future.wait() if wait else future > ', ' Fil...

On Sun, Mar 17, 2019 at 3:51 PM Daniel Erez <derez@redhat.com> wrote: > After invoking transfer_service.finalize, check operation > status by examining DiskStatus. > This is done instead of failing after a predefined timeout > regardless the status. > > * not verified * > > Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1680361 > --- >

On Mon, Oct 15, 2018 at 6:21 PM Richard W.M. Jones <rjones@redhat.com> wrote: > On Tue, Oct 09, 2018 at 02:28:10PM +0300, Nir Soffer wrote: > > > +# Create a background thread running a web server which is > > > +# simulating the imageio server. > > > > > > > This functionality should be separated from the fake SDK module, since > it is > >