search for: output_sparse

...g = function + | Some s -> JSON.String s + | None -> JSON.Null + class output_rhv_upload output_alloc output_conn output_password output_storage rhv_options = @@ -195,7 +197,7 @@ See also the virt-v2v-output-rhv(1) manual.") "output_sparse", JSON.Bool (match output_alloc with | Sparse -> true | Preallocated -> false); - "rhv_cafile", JSON.String rhv_options.rhv_cafile; + "rhv_cafile", json_optstring rhv_options.rhv_cafile; &quo...

Add support for qcow2 disk format, enabled by imageio NBD backend in RHV 4.3. To use this feature manually, you can run virt-v2v with "-of qcow2". Here is example run: Source disk: $ qemu-img info /var/tmp/fedora-30.img image: /var/tmp/fedora-30.img file format: raw virtual size: 6 GiB (6442450944 bytes) disk size: 1.15 GiB virt-v2v: $ ./run virt-v2v \ -v \ -i disk

...39;raw', 'disk_name': 'v2v-000', 'output_name': 'v2v', 'verbose': True, 'output_conn': 'https://engine/ovirt-engine/api', 'output_password': '/var/tmp/engine-password', 'output_storage': 'nfs1-export2', 'output_sparse': True, 'rhv_cafile': '/etc/pki/vdsm/certs/cacert.pem', 'rhv_cluster': 'fc30', 'rhv_direct': True, 'insecure': True} --- v2v/rhv-upload-plugin.py | 1 + 1 file changed, 1 insertion(+) diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin...

...+ # XXX For qcow2 disk on block storage, we should use the estimated + # size, based on qemu-img measure of the overlay. initial_size = params['disk_size'], provisioned_size = params['disk_size'], # XXX Ignores params['output_sparse']. @@ -489,11 +492,16 @@ def create_transfer(connection, disk, host): system_service = connection.system_service() transfers_service = system_service.image_transfers_service() + extra = {} + if transfer_supports_format(): + extra["format"] = types.DiskFormat.R...

...s @{$meta->{disks}} > 0; # Copy source storage to target +if (defined($verbose)) { + logmsg NOTICE, __x('Copying virtual machine storage to target '. + '({output})', output => $output_method) +} $source->copy_storage($target, $output_format, $output_sparse); # Open a libguestfs handle on the guest's storage devices +if (defined($verbose)) { logmsg NOTICE, __x('Starting guestfs') } my @disks = map { [ $_->{device}, $_->{dst}->get_path(), $_->{dst}->get_format() ] } @{$meta->{d...

On Sun, Mar 25, 2018 at 08:05:14PM +0000, Nir Soffer wrote: > > > > + sparse = params['output_sparse'], > > > > > > > The user cannot configure that. This must be based on the image > > > format. The current coded may create images in unsupported > > > combinations, e.g. raw/sparse on block storage, or fail validation > > > in engine. > > &...

...+ # XXX For qcow2 disk on block storage, we should use the estimated + # size, based on qemu-img measure of the overlay. initial_size = params['disk_size'], provisioned_size = params['disk_size'], # XXX Ignores params['output_sparse']. @@ -497,11 +500,16 @@ def create_transfer(connection, disk, host): system_service = connection.system_service() transfers_service = system_service.image_transfers_service() + extra = {} + if transfer_supports_format(): + extra["format"] = types.DiskFormat.R...

...virt-v2v", > + format = disk_format, > + provisioned_size = params['disk_size'], > This must be the virtual size. You don't specify initial_size - in this case you get 1G, and most images will fail to upload. > + sparse = params['output_sparse'], > The user cannot configure that. This must be based on the image format. The current coded may create images in unsupported combinations, e.g. raw/sparse on block storage, or fail validation in engine. [snipped] > +# Can we issue zero, trim or flush requests? > +def get_options(...

...now the virtual size (params['disk_size']). We cannot > know any other information because we're streaming the data, so > anything that requires us to know the final size of the image is a > non-starter. > Discussed above. > > > + sparse = params['output_sparse'], > > > > > The user cannot configure that. This must be based on the image > > format. The current coded may create images in unsupported > > combinations, e.g. raw/sparse on block storage, or fail validation > > in engine. > > In virt-v2v this can be co...

If a volume is not an exact multiple of 512 bytes, qemu-img will report its size rounded down to a 512 byte boundary. However, when copying, the file is still read until EOF, which will return more data than was expected. This change prevents that causing a failure in itself. The situation is still not resolved, however, as there are still situations where this will cause a failure. For example,

...are supposed to be, and note that we only know the virtual size (params['disk_size']). We cannot know any other information because we're streaming the data, so anything that requires us to know the final size of the image is a non-starter. > > + sparse = params['output_sparse'], > > > The user cannot configure that. This must be based on the image > format. The current coded may create images in unsupported > combinations, e.g. raw/sparse on block storage, or fail validation > in engine. In virt-v2v this can be configured using ‘-oa’. What are th...

...k_size']). We cannot >> know any other information because we're streaming the data, so >> anything that requires us to know the final size of the image is a >> non-starter. >> > > Discussed above. > > >> > > + sparse = params['output_sparse'], >> > > >> > The user cannot configure that. This must be based on the image >> > format. The current coded may create images in unsupported >> > combinations, e.g. raw/sparse on block storage, or fail validation >> > in engine. >> >&gt...

Mainly minor fixes and code cleanups over the v4 patch. There are still several problems with this patch, but it is in a reviewable state, especially the Python code. Rich.

...conversion.") + in + + (* JSON parameters which are invariant between disks. *) + let json_params = [ + "output_conn", JSON.String output_conn; + "output_password", JSON.String output_password; + "output_storage", JSON.String output_storage; + "output_sparse", JSON.Bool (match output_alloc with + | Sparse -> true + | Preallocated -> false); + "rhv_cafile", JSON.String rhv_cafile; + "rhv_direct", JSON.Bool rhv_direct; + ] in + + (* nbdkit command line ar...

This series extract oVirt SDK and imageio code to make it eaiser to follow the code and improve error handing in open() and close(). The first small patches can be consider as fixes for downstream. Tested based on libguestfs v1.41.5, since I had trouble building virt-v2v and libguestfs from master. Nir Soffer (18): rhv-upload: Remove unused exception class rhv-upload: Check status more

...; + (* JSON parameters which are invariant between disks. *) > + let json_params = [ > + "output_conn", JSON.String output_conn; > + "output_password", JSON.String output_password; > + "output_storage", JSON.String output_storage; > + "output_sparse", JSON.Bool (match output_alloc with > + | Sparse -> true > + | Preallocated -> false); > + "rhv_cafile", JSON.String rhv_cafile; > + "rhv_direct", JSON.Bool rhv_direct; > + ] in >...

...; + (* JSON parameters which are invariant between disks. *) > + let json_params = [ > + "output_conn", JSON.String output_conn; > + "output_password", JSON.String output_password; > + "output_storage", JSON.String output_storage; > + "output_sparse", JSON.Bool (match output_alloc with > + | Sparse -> true > + | Preallocated -> false); > + "rhv_cafile", JSON.String rhv_cafile; > + "rhv_direct", JSON.Bool rhv_direct; > + ] in >...

...ers which are invariant between disks. *) > +  let json_params = [ > +    "output_conn", JSON.String output_conn; > +    "output_password", JSON.String output_password; > +    "output_storage", JSON.String output_storage; > +    "output_sparse", JSON.Bool (match output_alloc with > +                                | Sparse -> true > +                                | Preallocated -> false); > +    "rhv_cafile", JSON.String rhv_cafile; > +    "rhv_direct", JSON.Bool rhv_direct; &g...

v5 was here: https://www.redhat.com/archives/libguestfs/2018-March/msg00032.html There is only a single patch in this version because the other patches went upstream. This patch adds the virt-v2v -o rhv-upload mode (https://bugzilla.redhat.com/show_bug.cgi?id=1557273). Compared to v5, this adds the ability to make zero, trim and flush requests to the oVirt imageio server

...conversion.") + in + + (* JSON parameters which are invariant between disks. *) + let json_params = [ + "output_conn", JSON.String output_conn; + "output_password", JSON.String output_password; + "output_storage", JSON.String output_storage; + "output_sparse", JSON.Bool (match output_alloc with + | Sparse -> true + | Preallocated -> false); + "rhv_cafile", JSON.String rhv_cafile; + "rhv_cluster", JSON.String (Option.default "Default" rhv_cluster...