search for: output_rhev

This makes them visible in the help text of -i and -o. --- v2v/input_disk.ml | 5 ++++- v2v/output_local.ml | 5 ++++- v2v/output_rhev.ml | 5 ++++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/v2v/input_disk.ml b/v2v/input_disk.ml index 17ad61d..508f16a 100644 --- a/v2v/input_disk.ml +++ b/v2v/input_disk.ml @@ -101,4 +101,7 @@ class input_disk input_format disk = object end let input_disk = new input_disk...

The first two patches implement the change discussed here: https://www.redhat.com/archives/libguestfs/2016-April/msg00178.html The third patch fixes the mapping of inspection data to OVF VmType which was inherited directly from old virt-v2v and had never been changed. It had a number of problems. The fourth patch is only slightly related to the others. It adds an extra slow test to ensure that

...n Guestfs handles, so we get debugging, tracing, and other common options set. --- v2v/convert_windows.ml | 4 +--- v2v/input_disk.ml | 2 +- v2v/input_libvirt_other.ml | 2 +- v2v/input_ova.ml | 2 +- v2v/output_glance.ml | 2 +- v2v/output_null.ml | 2 +- v2v/output_rhev.ml | 2 +- v2v/output_vdsm.ml | 2 +- v2v/types.ml | 2 +- v2v/v2v.ml | 4 ++-- 10 files changed, 11 insertions(+), 13 deletions(-) diff --git a/v2v/convert_windows.ml b/v2v/convert_windows.ml index 6402a63..099ced2 100644 --- a/v2v/convert_windows.ml...

...yle qcow2 compat=0.10 images. Since RHEV 3.6 GA, RHEL 6 has not been supported as a RHEV node type. There are significant downsides to using qcow2 compat=0.10 instead of the modern default (compat=1.1), so stop forcing compat=0.10 for these targets. Thanks: Yaniv Kaul, Michal Skrivanek. --- v2v/output_rhev.ml | 4 ---- v2v/output_vdsm.ml | 10 ---------- 2 files changed, 14 deletions(-) diff --git a/v2v/output_rhev.ml b/v2v/output_rhev.ml index e45043b..3280150 100644 --- a/v2v/output_rhev.ml +++ b/v2v/output_rhev.ml @@ -248,10 +248,6 @@ object Changeuid.func changeuid_t ( fun () ->...

Extend Modules_list to handle also aliases for input and output modules, and use this to register the existing aliases. --- v2v/input_disk.ml | 2 +- v2v/modules_list.ml | 25 +++++++++++++++++++++---- v2v/modules_list.mli | 8 ++++---- v2v/output_local.ml | 2 +- v2v/output_rhev.ml | 2 +- 5 files changed, 28 insertions(+), 11 deletions(-) diff --git a/v2v/input_disk.ml b/v2v/input_disk.ml index 17ad61d..d21815d 100644 --- a/v2v/input_disk.ml +++ b/v2v/input_disk.ml @@ -101,4 +101,4 @@ class input_disk input_format disk = object end let input_disk = new input_disk...

Extend open_guestfs to take an optional ?identifier parameter. Use this parameter in virt-v2v which is currently the only place where we use the handle identifier. --- mllib/common_utils.ml | 3 ++- mllib/common_utils.mli | 2 +- v2v/output_rhev.ml | 3 +-- v2v/output_vdsm.ml | 3 +-- v2v/v2v.ml | 3 +-- v2v/windows.ml | 3 +-- 6 files changed, 7 insertions(+), 10 deletions(-) diff --git a/mllib/common_utils.ml b/mllib/common_utils.ml index 52079d2..13e9256 100644 --- a/mllib/common_utils.ml +++ b/mllib/common_...

...8 +- v2v/OVF.ml | 30 +++---- v2v/OVF.mli | 2 +- v2v/changeuid.mli | 4 +- v2v/cmdline.ml | 12 +-- v2v/convert_windows.ml | 2 +- v2v/{output_rhev.ml => output_rhv.ml} | 26 +++--- v2v/{output_rhev.mli => output_rhv.mli} | 8 +- v2v/output_vdsm.ml | 4 +- v2v/test-harness/virt-v2v-test-harness.pod | 4 +- v2v/test-v2v-no-copy.sh | 6 +- v2v/{test-v2v-o-rhev.sh =&...

...8 +- v2v/OVF.ml | 30 +++---- v2v/OVF.mli | 2 +- v2v/changeuid.mli | 4 +- v2v/cmdline.ml | 12 +-- v2v/convert_windows.ml | 2 +- v2v/{output_rhev.ml => output_rhv.ml} | 26 +++--- v2v/{output_rhev.mli => output_rhv.mli} | 8 +- v2v/output_vdsm.ml | 4 +- v2v/test-harness/virt-v2v-test-harness.pod | 4 +- v2v/test-v2v-no-copy.sh | 6 +- v2v/{test-v2v-o-rhev.sh =&...

v2: - Fix virt-p2v messages too. Rich.

...tracing, and other common options set. > --- > v2v/convert_windows.ml | 4 +--- > v2v/input_disk.ml | 2 +- > v2v/input_libvirt_other.ml | 2 +- > v2v/input_ova.ml | 2 +- > v2v/output_glance.ml | 2 +- > v2v/output_null.ml | 2 +- > v2v/output_rhev.ml | 2 +- > v2v/output_vdsm.ml | 2 +- > v2v/types.ml | 2 +- > v2v/v2v.ml | 4 ++-- > 10 files changed, 11 insertions(+), 13 deletions(-) I guess it sets the network flag unnecessarily, but that doesn't matter much so ACK. Rich. &gt...

...previous behaviour. We can drop this flag later when all RHV instances have moved to 4.1. It also adds: vdsm-compat-11-option to the `virt-v2v --machine-readable' output to indicate that this flag can be used. Thanks: Yaniv Kaul, Michal Skrivanek. --- v2v/cmdline.ml | 5 +++++ v2v/output_rhev.ml | 4 ---- v2v/output_vdsm.ml | 11 ++++++++--- v2v/output_vdsm.mli | 1 + v2v/virt-v2v.pod | 11 ++++++++++- 5 files changed, 24 insertions(+), 8 deletions(-) diff --git a/v2v/cmdline.ml b/v2v/cmdline.ml index 2d0a10a..9a56d60 100644 --- a/v2v/cmdline.ml +++ b/v2v/cmdline.ml @@ -65,6 +65...

...e. We can make this the default later when all RHV instances have moved to 4.1. It also adds: vdsm-compat-option to the `virt-v2v --machine-readable' output to indicate that this flag can be used. Thanks: Yaniv Kaul, Michal Skrivanek. --- v2v/cmdline.ml | 7 +++++++ v2v/output_rhev.ml | 4 ---- v2v/output_vdsm.ml | 11 ++++++++--- v2v/output_vdsm.mli | 1 + v2v/test-v2v-o-vdsm-options.sh | 11 +++++++++-- v2v/virt-v2v.pod | 21 ++++++++++++++++++++- 6 files changed, 45 insertions(+), 10 deletions(-) diff --git a/v2v/cmdline....

The 'may' function is a higher-order function (HOF) that replaces: match x with | None -> () | Some x -> f x with: may f x The idea comes from lablgtk (OCaml Gtk bindings) where it is widely used. If this change is clearer than previous code, then this could be used in many more places. However I previously steered clear from using HOFs like this because they can be

v3: Change the flag from --vdsm-compat-11 to --vdsm-compat=1.1 Also the --machine-readable output has changed. I have also added a test. Rich.

...> --- resize/resize.ml | 10 +++++----- sparsify/copying.ml | 2 +- src/fuse.c | 2 +- src/launch-libvirt.c | 4 ++-- src/libvirt-domain.c | 2 +- v2v/convert_linux.ml | 6 +++--- v2v/input_libvirt.ml | 4 ++-- v2v/lib_ovf.ml | 2 +- v2v/output_glance.ml | 2 +- v2v/output_rhev.ml | 6 +++--- v2v/v2v.ml | 6 +++--- 11 files changed, 23 insertions(+), 23 deletions(-) diff --git a/resize/resize.ml b/resize/resize.ml index 81bb270..a3ea9be 100644 --- a/resize/resize.ml +++ b/resize/resize.ml @@ -310,7 +310,7 @@ read the man page virt-resize(1). let infile...

Add an optional parameter to disable this behaviour, so the Curl module in v2v won't print user-sensible data (like passwords). --- builder/checksums.ml | 1 - builder/downloader.ml | 1 - builder/sigchecker.ml | 1 - mllib/common_utils.ml | 4 +++- mllib/common_utils.mli | 7 +++++-- v2v/curl.ml | 2 +- 6 files changed, 9 insertions(+), 7 deletions(-) diff --git

...mllib/common_utils.mli | 6 ++++ v2v/copy_to_local.ml | 4 +-- v2v/input_libvirt_vcenter_https.ml | 7 ++--- v2v/input_ova.ml | 12 ++++---- v2v/output_glance.ml | 23 +++++++------- v2v/output_libvirt.ml | 15 ++++----- v2v/output_rhev.ml | 9 +++--- v2v/v2v.ml | 21 ++++++------- 15 files changed, 124 insertions(+), 129 deletions(-) diff --git a/builder/builder.ml b/builder/builder.ml index 6645e75..b7a1da0 100644 --- a/builder/builder.ml +++ b/builder/builder.ml @@ -118,18 +118,17 @@ le...

...mounted path. > * > * Note it's good to fail here (early) if there are any problems, since > * the next time we are called (in {!create_metadata}) we have already > @@ -79,7 +78,18 @@ object > (List.length targets); > > let mp, uuid = > - Output_rhev.mount_and_check_storage_domain verbose (s_"Data Domain") os in > + let fields = string_nsplit "/" os in (* ... "data-center" "UUID" *) > + let fields = List.rev fields in (* "UUID" "data-center" ... *) > + matc...

...utput_local.mli | 4 +- v2v/output_null.ml | 6 +-- v2v/output_null.mli | 4 +- v2v/output_qemu.ml | 4 +- v2v/output_qemu.mli | 4 +- v2v/output_rhev.ml | 28 +++++----- v2v/output_rhev.mli | 6 +-- v2v/output_vdsm.ml | 14 ++--- v2v/output_vdsm.mli | 4 +- v2v/types.ml | 4 +- v2v...

.. and a lot of refactoring. https://bugzilla.redhat.com/show_bug.cgi?id=1167623 Rich.