search for: output_openstack

In some cases we have observed the time taken for a Cinder volume to attach to the conversion appliance can be longer than the current 60 seconds. Increase the timeout to 5 minutes. Thanks: Ming Xie. --- v2v/output_openstack.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2v/output_openstack.ml b/v2v/output_openstack.ml index caaedf452..e395ccb37 100644 --- a/v2v/output_openstack.ml +++ b/v2v/output_openstack.ml @@ -38,7 +38,7 @@ let openstack_binary = "openstack" let available_timeou...

They can contain passwords or tokens if for example the ‘-oo os-password’ option is used. Thanks: Tomáš Golembiovský, Brett Thurber. --- v2v/output_openstack.ml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/v2v/output_openstack.ml b/v2v/output_openstack.ml index 95c42cbed..3ff1e1269 100644 --- a/v2v/output_openstack.ml +++ b/v2v/output_openstack.ml @@ -177,8 +177,10 @@ class output_openstack output_conn output_password...

The first patch restricts passthrough parameters to ones matching "os-*". This was how it was documented, but not how it was implemented. The second patch is the same as v2 here: https://www.redhat.com/archives/libguestfs/2018-November/msg00187.html Rich.

Improves the error message when openstack is not installed: $ virt-v2v -i disk fedora-28.img -o openstack virt-v2v: error: no binary called ‘openstack’ was found on the $PATH. We use this program to communicate with OpenStack so it must be installed to use this output mode. --- v2v/output_openstack.ml | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/v2v/output_openstack.ml b/v2v/output_openstack.ml index b5bbc9195..238ec99a9 100644 --- a/v2v/output_openstack.ml +++ b/v2v/output_openstack.ml @@ -28,6 +28,9 @@ open Common_gettext.Gettext open Types open U...

Random old patch that I had in my queue. Posting it as a backup, it is still untested. Rich.

If ‘virt-v2v -oo insecure’ is used then ‘openstack --insecure’ flag is added whenever we invoke the openstack command. This turns of SSL certificate validation. --- v2v/output_openstack.ml | 14 +++++++++++++- v2v/virt-v2v-output-openstack.pod | 1 + v2v/virt-v2v.pod | 7 +++++++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/v2v/output_openstack.ml b/v2v/output_openstack.ml index b901ab262..b5bbc9195 100644 --- a/v2v/output_openstack.m...

Since this output method was written the code has always been capable of adding the hw_firmware_type = uefi image property, and this property has been supported since at least OpenStack 12 which is years old. Interestingly now all of the output modes support both BIOS and UEFI. --- v2v/output_openstack.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2v/output_openstack.ml b/v2v/output_openstack.ml index 179b0edf63..fdc04b02f8 100644 --- a/v2v/output_openstack.ml +++ b/v2v/output_openstack.ml @@ -390,7 +390,7 @@ object | None -> "" | Some op -> &...

...e form. However a small modification to the matching rules would allow this. The effect of this change is that you can now use ‘virt-v2v -oo insecure’ to turn off SSL certificate validation. The default is to verify the server certificate (which is the default of the openstack command). --- v2v/output_openstack.ml | 11 +++++++---- v2v/test-v2v-o-openstack.sh | 2 ++ v2v/virt-v2v-output-openstack.pod | 7 +++++++ 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/v2v/output_openstack.ml b/v2v/output_openstack.ml index 22fac69bd..76e269c85 100644 --- a/v2v/output_openstack.ml...

If ‘virt-v2v -oo verify-server-certificate=false’ is used then ‘openstack --insecure’ flag is added whenever we invoke the openstack command. This turns off SSL certificate validation. The default is to verify the server certificate (which is the default of the openstack command). --- v2v/output_openstack.ml | 16 +++++++++++++++- v2v/test-v2v-o-openstack.sh | 2 ++ v2v/virt-v2v-output-openstack.pod | 8 ++++++++ v2v/virt-v2v.pod | 8 ++++++++ 4 files changed, 33 insertions(+), 1 deletion(-) diff --git a/v2v/output_openstack.ml b/v2v/output_openstack.ml index 22f...

A smaller change than v2, we simply generalize the ability to pass through flags to the underlying openstack command, allowing the --insecure flag to be specified directly. Rich.

This patch implements output to OpenStack Cinder volumes using OpenStack APIs. It has only been lightly tested, but appears to work. There are some important things to understand about how this works: (1) You must run virt-v2v in a conversion appliance running on top of OpenStack. And you must supply the name or UUID of this appliance to virt-v2v using the ‘-oo server-id=NAME|UUID’ parameter.

v1 was here: https://www.redhat.com/archives/libguestfs/2018-August/thread.html#00287 v2: - The -oa option now gives an error; apparently Cinder cannot generally control sparse/preallocated behaviour, although certain Cinder backends can. - The -os option maps to Cinder volume type; suggested by Matt Booth. - Add a simple test.

...ectories for removal when the application quits. --- v2v/input_ova.ml | 5 ++--- v2v/input_vmx.ml | 5 ----- v2v/measure_disk.ml | 5 +++-- v2v/output_glance.ml | 18 ++++++------------ v2v/output_libvirt.ml | 3 +++ v2v/output_null.ml | 14 ++------------ v2v/output_openstack.ml | 3 +-- v2v/output_rhv.ml | 2 +- v2v/output_rhv_upload.ml | 7 ------- v2v/parse_ova.ml | 30 ++++++++++++++---------------- v2v/utils.ml | 25 +++++++++++++++++++++++-- v2v/utils.mli | 7 +++++++ v2v/v2v.ml | 15 ++++++--------- 13 file...

...to do extra checks in the output before copying the disks. Partially revert commit 3bafec4e693a25ef1c84abc0fd1bc3251862c7de. --- v2v/output_glance.ml | 2 +- v2v/output_json.ml | 2 +- v2v/output_libvirt.ml | 2 +- v2v/output_local.ml | 2 +- v2v/output_null.ml | 2 +- v2v/output_openstack.ml | 2 +- v2v/output_qemu.ml | 2 +- v2v/output_rhv.ml | 2 +- v2v/output_rhv_upload.ml | 2 +- v2v/output_vdsm.ml | 2 +- v2v/types.ml | 2 +- v2v/types.mli | 2 +- v2v/v2v.ml | 3 ++- 13 files changed, 14 insertions(+), 13 deletions(-) di...

Since this new temporary directory will contain UNIX sockets for communicating with nbdkit, then its path must not be too long. Use the existing directory that libguestfs exposes for this, i.e. sockdir. --- v2v/nbdkit.ml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/v2v/nbdkit.ml b/v2v/nbdkit.ml index 65317f9b..46b20c9d 100644 --- a/v2v/nbdkit.ml +++ b/v2v/nbdkit.ml

...perties later. All of this work is upstream in libguestfs >= 1.39.8. The second part was adding the machinery for the new output mode. This is the extra commit that you see in the branch above. Note this commit does not actually do anything useful so far. The important file to look at is v2v/output_openstack.ml. Some other random notes: - Before you try to build from source, read this page carefully: http://libguestfs.org/guestfs-building.1.html - Upstream in virt-v2v we have settled on using Python 3 only. So all code submitted should be written in Python 3, you will have to install python3-...

Previously: $ virt-v2v -v -x -i disk fedora-28.img -o openstack -oo server-id=foo virt-v2v: libguestfs 1.39.11fedora=29,release=1.fc29,libvirt (x86_64) libvirt version: 4.5.0 virt-v2v: error: openstack: precheck failed, there may be a problem with authentication, see earlier error messages rm -rf '/var/tmp/null.dTxRFN' Notice there is no "earlier error message".

...> - Or 127 > + debug "%s: executable not found" app; > + Or 127 > + | Unix.Unix_error (errcode, fn, _) when errcode = Unix.ENOENT -> > + debug "%s: %s: executable not found" app fn; > + Or 127 This is OK. Though, in the specific case of output_openstack#precheck I'd still check for the existance of the "openstack" executable first, just like what Python_script.error_unless_python_interpreter_found does. This way there is a better error message to cover the case described in the commit message, even in case -v is not passed. -- Pin...

I think we should do this slightly differently for consistency with other classes. See here for example: https://github.com/libguestfs/libguestfs/blob/dea9636c596acd030c9955057863cf080bdd89fb/v2v/output_openstack.ml#L395-L398 (1) Declare a val mutable in the object: val mutable delete_disks_on_exit = true > @@ -275,6 +290,13 @@ object > if Python_script.run_command vmcheck_script json_params [] <> 0 then > error (f_"failed vmchecks, see earlier errors"); > >...

...gt; false to not break existing behaviour. The issue of cleaning up disks in general is a hard one to solve. With the OpenStack backend we try our best as long as virt-v2v exits on a normal failure path: https://github.com/libguestfs/libguestfs/blob/e2bafffce24cd8c0436bf887ee166a3ae2257bbb/v2v/output_openstack.ml#L370-L384 However there are always going to be cases where that is not possible (eg. virt-v2v segfaults or is kill -9'd or whatever), and in that case I envisaged for OpenStack some sort of external garbage collector. To this end, disks which have not been finalized are given a special des...