search for: output_null

...l-co qemu driver with a JSON URL syntax -- especially the latter is only available in newer versions of qemu. Even if this output mode is mostly for testing, check at runtime whether the null-co + JSON way is possible, falling back to the creation of thrown-away temporary files as before. --- v2v/output_null.ml | 60 +++++++++++++++++++++++++++++++++++++--------- 1 file changed, 49 insertions(+), 11 deletions(-) diff --git a/v2v/output_null.ml b/v2v/output_null.ml index b93d53dc5..5a5473c0d 100644 --- a/v2v/output_null.ml +++ b/v2v/output_null.ml @@ -42,7 +42,37 @@ open Utils * size instead. *)...

Instead of writing to a temporary file and deleting it, use the null block driver in qemu to throw it away. --- v2v/output_null.ml | 47 +++++++++++++++++++++++++++++++++-------------- v2v/virt-v2v.pod | 4 ---- 2 files changed, 33 insertions(+), 18 deletions(-) diff --git a/v2v/output_null.ml b/v2v/output_null.ml index d01f45654..4d06aa0de 100644 --- a/v2v/output_null.ml +++ b/v2v/output_null.ml @@ -26,16 +26,23 @@ ope...

Use the common open_guestfs to open Guestfs handles, so we get debugging, tracing, and other common options set. --- v2v/convert_windows.ml | 4 +--- v2v/input_disk.ml | 2 +- v2v/input_libvirt_other.ml | 2 +- v2v/input_ova.ml | 2 +- v2v/output_glance.ml | 2 +- v2v/output_null.ml | 2 +- v2v/output_rhev.ml | 2 +- v2v/output_vdsm.ml | 2 +- v2v/types.ml | 2 +- v2v/v2v.ml | 4 ++-- 10 files changed, 11 insertions(+), 13 deletions(-) diff --git a/v2v/convert_windows.ml b/v2v/convert_windows.ml index 6402a63..099ced2 1...

This changes the infrastructure to allow the target_file to be a QEMU URI. Rich.

...stfs handles, so we get > debugging, tracing, and other common options set. > --- > v2v/convert_windows.ml | 4 +--- > v2v/input_disk.ml | 2 +- > v2v/input_libvirt_other.ml | 2 +- > v2v/input_ova.ml | 2 +- > v2v/output_glance.ml | 2 +- > v2v/output_null.ml | 2 +- > v2v/output_rhev.ml | 2 +- > v2v/output_vdsm.ml | 2 +- > v2v/types.ml | 2 +- > v2v/v2v.ml | 4 ++-- > 10 files changed, 11 insertions(+), 13 deletions(-) I guess it sets the network flag unnecessarily, but that doe...

...annot be used in this output mode"); if output_storage <> None then error (f_"-o null: -os option cannot be used in this output mode"); if qemu_boot then error (f_"-o null: --qemu-boot option cannot be used in this output mode"); - Output_null.output_null () + Output_null.output_null (), + (* Force output format to raw sparse in -o null mode. *) + Some "raw", Sparse | `QEmu -> let os = @@ -389,7 +398,8 @@ read the man page virt-v2v(1). | Some d when not (is_directory d) ->...

...ually schedule all the temporary files and directories for removal when the application quits. --- v2v/input_ova.ml | 5 ++--- v2v/input_vmx.ml | 5 ----- v2v/measure_disk.ml | 5 +++-- v2v/output_glance.ml | 18 ++++++------------ v2v/output_libvirt.ml | 3 +++ v2v/output_null.ml | 14 ++------------ v2v/output_openstack.ml | 3 +-- v2v/output_rhv.ml | 2 +- v2v/output_rhv_upload.ml | 7 ------- v2v/parse_ova.ml | 30 ++++++++++++++---------------- v2v/utils.ml | 25 +++++++++++++++++++++++-- v2v/utils.mli | 7 +++++++ v2v...

...ually /tmp). I cleaned up some existing code which used /var/tmp for small temporaries. --- docs/virt-v2v.pod | 29 ++++++++++++++++++++--------- v2v/input_ova.ml | 4 ++-- v2v/input_vmx.ml | 3 +-- v2v/nbdkit.ml | 3 +-- v2v/output_glance.ml | 3 +-- v2v/output_null.ml | 3 +-- v2v/output_rhv_upload.ml | 29 ++++++++++++++++------------- v2v/parse_ova.ml | 6 ++---- v2v/python_script.ml | 12 +++--------- v2v/python_script.mli | 5 +---- v2v/utils.ml | 6 +++++- v2v/utils.mli | 5 +++++ v2v/v2v.ml...

It will be used to do extra checks in the output before copying the disks. Partially revert commit 3bafec4e693a25ef1c84abc0fd1bc3251862c7de. --- v2v/output_glance.ml | 2 +- v2v/output_json.ml | 2 +- v2v/output_libvirt.ml | 2 +- v2v/output_local.ml | 2 +- v2v/output_null.ml | 2 +- v2v/output_openstack.ml | 2 +- v2v/output_qemu.ml | 2 +- v2v/output_rhv.ml | 2 +- v2v/output_rhv_upload.ml | 2 +- v2v/output_vdsm.ml | 2 +- v2v/types.ml | 2 +- v2v/types.mli | 2 +- v2v/v2v.ml | 3 ++- 13 files changed,...

Since this new temporary directory will contain UNIX sockets for communicating with nbdkit, then its path must not be too long. Use the existing directory that libguestfs exposes for this, i.e. sockdir. --- v2v/nbdkit.ml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/v2v/nbdkit.ml b/v2v/nbdkit.ml index 65317f9b..46b20c9d 100644 --- a/v2v/nbdkit.ml +++ b/v2v/nbdkit.ml

v1 was here: https://www.redhat.com/archives/libguestfs/2020-April/msg00007.html There's a BZ for this now which I forgot to add to the commit message: https://bugzilla.redhat.com/show_bug.cgi?id=1814611 For v2: - Fix incorrect reference to $TMPDIR in existing manual. - Separate handling for small temporary files and large temporary files. Small temporary files go into $TMPDIR

...utput_glance.mli | 4 +- v2v/output_libvirt.ml | 8 +-- v2v/output_libvirt.mli | 4 +- v2v/output_local.ml | 4 +- v2v/output_local.mli | 4 +- v2v/output_null.ml | 6 +-- v2v/output_null.mli | 4 +- v2v/output_qemu.ml | 4 +- v2v/output_qemu.mli | 4 +- v2v/output_rhev.ml | 28 +++++----- v2v/ou...

...error_option_cannot_be_used_in_output_mode "null" "-os"; if qemu_boot then - error (f_"-o null: --qemu-boot option cannot be used in this output mode"); + error_option_cannot_be_used_in_output_mode "null" "--qemu-boot"; Output_null.output_null (), (* Force output format to raw sparse in -o null mode. *) Some "raw", Sparse @@ -408,7 +413,7 @@ read the man page virt-v2v(1). error (f_"-o rhv: output storage was not specified, use '-os'"); | Some d -> d in i...

...le cleanup of temporary files by an external process, as described in the updated documentation. --- docs/virt-v2v.pod | 21 +++++++++++++++++---- v2v/input_ova.ml | 4 ++-- v2v/input_vmx.ml | 3 +-- v2v/nbdkit.ml | 3 +-- v2v/output_glance.ml | 3 +-- v2v/output_null.ml | 5 ++--- v2v/output_rhv_upload.ml | 3 +-- v2v/parse_ova.ml | 5 ++--- v2v/python_script.ml | 3 +-- v2v/utils.ml | 8 ++++++-- v2v/utils.mli | 4 ++++ v2v/v2v.ml | 15 ++++++--------- 12 files changed, 44 insertions(+), 33 deletions...

.. and a lot of refactoring. https://bugzilla.redhat.com/show_bug.cgi?id=1167623 Rich.

https://bugzilla.redhat.com/show_bug.cgi?id=1167623

This patch series adds stable bus and slot numbers for removable drives (CDs and floppies) when the guest is converted using virt-v2v or virt-p2v. Previously we were a bit random about this. After this patch series, the bus and slot numbers and preserved if at all possible. BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1238053 Rich.

Fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1354507 Main explanation is in patch #3. Rich.

...er.ml | 2 +- common/mlutils/unix_utils.ml | 4 ++-- common/mlutils/unix_utils.mli | 4 ++-- dib/dib.ml | 2 +- sysprep/sysprep_operation_script.ml | 2 +- v2v/input_ova.ml | 2 +- v2v/output_glance.ml | 2 +- v2v/output_null.ml | 2 +- v2v/output_rhv.ml | 2 +- 10 files changed, 12 insertions(+), 12 deletions(-) diff --git a/builder/builder.ml b/builder/builder.ml index 0e02bab3b..3c1f04c77 100644 --- a/builder/builder.ml +++ b/builder/builder.ml @@ -181,7 +181,7 @@ let main () =...

...(+) diff --git a/v2v/Makefile.am b/v2v/Makefile.am index f36731750..2f6953463 100644 --- a/v2v/Makefile.am +++ b/v2v/Makefile.am @@ -66,6 +66,7 @@ SOURCES_MLI = \ modules_list.mli \ name_from_disk.mli \ output_glance.mli \ + output_kubevirt.mli \ output_libvirt.mli \ output_local.mli \ output_null.mli \ @@ -132,6 +133,7 @@ SOURCES_ML = \ output_rhv_upload_precheck_source.ml \ output_rhv_upload.ml \ output_vdsm.ml \ + output_kubevirt.ml \ inspect_source.ml \ target_bus_assignment.ml \ cmdline.ml \ diff --git a/v2v/cmdline.ml b/v2v/cmdline.ml index a8da63f71..a9608b330 100644 --- a...