search for: ounit2

...d, Jul 19, 2017 at 12:57:08PM +0200, Pino Toscano wrote: > > > > Would it be possible to use oUnit too? > > > > > > I'm not clear on what benefit oUnit gives us which is worth the extra > > > dependency it pulls in. > > > > I was referring to OUnit2, which we already have an optional dependency > > for almost all the OCaml tests. > > Sure, understood. But what would we lose by converting those to > simple programs that just ran a series of "assert"s? If a single > test fails we have to fix it anyway. The assert...

On Mon, May 11, 2015 at 07:22:58PM +0200, Pino Toscano wrote: > On Monday 11 May 2015 11:11:50 Richard W.M. Jones wrote: > > OUnit2 has an OUnit (v1) compatibility module. Unfortunately it > > is rather gravely broken: > > https://forge.ocamlcore.org/tracker/?func=detail&aid=1392&group_id=162&atid=730 > > > > Since there is no new release fixing this, it's easier to switch to > >...

...July 2017 14:21:51 CEST Richard W.M. Jones wrote: > On Wed, Jul 19, 2017 at 12:57:08PM +0200, Pino Toscano wrote: > > Would it be possible to use oUnit too? > > I'm not clear on what benefit oUnit gives us which is worth the extra > dependency it pulls in. I was referring to OUnit2, which we already have an optional dependency for almost all the OCaml tests. -- Pino Toscano

On Monday 11 May 2015 11:11:50 Richard W.M. Jones wrote: > OUnit2 has an OUnit (v1) compatibility module. Unfortunately it > is rather gravely broken: > https://forge.ocamlcore.org/tracker/?func=detail&aid=1392&group_id=162&atid=730 > > Since there is no new release fixing this, it's easier to switch to > using OUnit2 for unit tes...

On Thu, Aug 03, 2017 at 06:08:24PM +0200, Pino Toscano wrote: > But I guess I have no chance to change the current patch (even adding > a test using asserts, instead of oUnit, for which I still did not get > a reason why a new test using it would be unacceptable), so ... Fewer dependencies make the code easier for others to consume, and that's especially true when (like oUnit) those

...+0200, Pino Toscano wrote: > > > > > Would it be possible to use oUnit too? > > > > > > > > I'm not clear on what benefit oUnit gives us which is worth the extra > > > > dependency it pulls in. > > > > > > I was referring to OUnit2, which we already have an optional dependency > > > for almost all the OCaml tests. > > > > Sure, understood. But what would we lose by converting those to > > simple programs that just ran a series of "assert"s? If a single > > test fails we have to fi...

OUnit2 has an OUnit (v1) compatibility module. Unfortunately it is rather gravely broken: https://forge.ocamlcore.org/tracker/?func=detail&aid=1392&group_id=162&atid=730 Since there is no new release fixing this, it's easier to switch to using OUnit2 for unit tests. --- .gitignore...

You asked me to reply to some other points (copied from https://www.redhat.com/archives/libguestfs/2017-July/msg00189.html): > Sure. OTOH, we already do use oUnit2, so these reasonings were already > discussed in the past, and (considered we have tests based on oUnit2) > deemed not a problem. I don't think that every past decision should be unchangable. > What I still don't understand is why adding a new test based on oUnit2 > would be a...

Not actually useful, as TESTS defines the tests, and it breaks when oUnit is not available (as it tries to build an oUnit-based unit test). --- mllib/Makefile.am | 3 --- 1 file changed, 3 deletions(-) diff --git a/mllib/Makefile.am b/mllib/Makefile.am index 0b43684..e363f27 100644 --- a/mllib/Makefile.am +++ b/mllib/Makefile.am @@ -132,9 +132,6 @@ libdir.ml: Makefile # Tests.

On Friday, 4 August 2017 10:01:28 CEST Richard W.M. Jones wrote: > You asked me to reply to some other points (copied from > https://www.redhat.com/archives/libguestfs/2017-July/msg00189.html): > > > Sure. OTOH, we already do use oUnit2, so these reasonings were already > > discussed in the past, and (considered we have tests based on oUnit2) > > deemed not a problem. > > I don't think that every past decision should be unchangable. I agree, but there should be reasons to switch back, since we already inves...

Instead of parsing the version, try to look for the OUnit2 module within the oUnit package. Followup of commit 46bc79109bb51cfb656863da3635f1c8da5f6412. --- configure.ac | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index 5ff151b..7a609cb 100644 --- a/configure.ac +++ b/configure.ac @@ -1...

.... Jones wrote: > > On Wed, Jul 19, 2017 at 12:57:08PM +0200, Pino Toscano wrote: > > > Would it be possible to use oUnit too? > > > > I'm not clear on what benefit oUnit gives us which is worth the extra > > dependency it pulls in. > > I was referring to OUnit2, which we already have an optional dependency > for almost all the OCaml tests. Sure, understood. But what would we lose by converting those to simple programs that just ran a series of "assert"s? If a single test fails we have to fix it anyway. If the lack of oUnit2 means that oth...

...ding the balloon device with the memory stats; it's not a part of the driver per se but it's currently bundled with it. (I'm yet to figure out who's responsible for installing it). > It also causes the tests to fail, although only when you have > installed the optional ocaml oUnit2 package: That's a problem with the test then (and no I didn't have that package installed so my make -C v2v check passed). Roman.

This commit starts to split our massive, monolithic configure.ac file into smaller files, using the m4_include mechanism to combine them. I don't know if we should really do this, so I'm open to comments about it. However: - Our configure.ac script is 1800+ lines long, and that's pretty long. - configure.ac lacks structure; splitting it up might improve that. - From what I read,

Windows QXL drivers include also qxldd.dll which used to get filtered out and not copied over into the guest. As a result QXL driver failed to install due to a missing file. Correct that, and update the tests accordingly. Signed-off-by: Roman Kagan <rkagan@virtuozzo.com> --- v2v/fake-virtio-win/drivers/i386/Win7/qxldd.dll | 1 + v2v/test-v2v-in-place.sh | 1 +

..."; "sys"] in Actually no, this part is (may be) wrong. This causes WdfCoInstaller*.dll from the ISO to be copied in. It's not clear to me whether these files are needed - I suspect not. It also causes the tests to fail, although only when you have installed the optional ocaml oUnit2 package: ---------------------------------------------------------------------- Error: virt-v2v:3:Utils.virtio_iso_path_matches_guest_os. File "/home/rjones/d/libguestfs/v2v/oUnit-virt-v2v-choo.home.annexia.org#01.log", line 8, characters 1-1: Error: virt-v2v:3:Utils.virtio_iso_path_mat...

...ith the memory stats; it's not a part of the > driver per se but it's currently bundled with it. (I'm yet to figure > out who's responsible for installing it). > > > It also causes the tests to fail, although only when you have > > installed the optional ocaml oUnit2 package: > > That's a problem with the test then (and no I didn't have that package > installed so my make -C v2v check passed). > > Roman. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http:/...

Would it be possible to use oUnit too? -- Pino Toscano

...o have_Bytes_module=no @@ -158,7 +157,6 @@ AS_IF([test "x$OCAMLC" != "xno"],[ GUESTFS_CREATE_COMMON_GETTEXT_ML([common/mlgettext/common_gettext.ml]) - AC_CHECK_OCAML_PKG(libvirt) AC_CHECK_OCAML_PKG(oUnit) # oUnit >= 2 is required, so check that it has OUnit2. @@ -182,8 +180,6 @@ AS_IF([test "x$OCAMLC" != "xno"],[ ]) AM_CONDITIONAL([HAVE_OCAML_PKG_GETTEXT], [test "x$OCAML_PKG_gettext" != "xno"]) -AM_CONDITIONAL([HAVE_OCAML_PKG_LIBVIRT], - [test "x$OCAML_PKG_libvirt" != &qu...

OCaml 4.02 introduced the 'bytes' type, a mutable string intended to replace the existing 'string' type for those cases where the byte array can be mutated. In future the 'string' type will become immutable. This is not the default now, but it can be forced using the '-safe-string' compile option. I tested this on Fedora 24 (OCaml 4.02) & RHEL 7 (OCaml 4.01).