Displaying 8 results from an estimated 8 matches for "osandov".
2017 Jan 09
4
[PATCH] virtio_blk: fix panic in initialization error path
From: Omar Sandoval <osandov at fb.com>
If blk_mq_init_queue() returns an error, it gets assigned to
vblk->disk->queue. Then, when we call put_disk(), we end up calling
blk_put_queue() with the ERR_PTR, causing a bad dereference. Fix it by
only assigning to vblk->disk->queue on success.
Signed-off-by: Omar San...
2017 Jan 09
4
[PATCH] virtio_blk: fix panic in initialization error path
From: Omar Sandoval <osandov at fb.com>
If blk_mq_init_queue() returns an error, it gets assigned to
vblk->disk->queue. Then, when we call put_disk(), we end up calling
blk_put_queue() with the ERR_PTR, causing a bad dereference. Fix it by
only assigning to vblk->disk->queue on success.
Signed-off-by: Omar San...
2017 Feb 01
3
[PATCH] virtio-console: avoid DMA from stack
From: Omar Sandoval <osandov at fb.com>
put_chars() stuffs the buffer it gets into an sg, but that buffer may be
on the stack. This breaks with CONFIG_VMAP_STACK=y (for me, it
manifested as printks getting turned into NUL bytes).
Signed-off-by: Omar Sandoval <osandov at fb.com>
---
Patch based on v4.10-rc6.
driver...
2017 Feb 01
3
[PATCH] virtio-console: avoid DMA from stack
From: Omar Sandoval <osandov at fb.com>
put_chars() stuffs the buffer it gets into an sg, but that buffer may be
on the stack. This breaks with CONFIG_VMAP_STACK=y (for me, it
manifested as printks getting turned into NUL bytes).
Signed-off-by: Omar Sandoval <osandov at fb.com>
---
Patch based on v4.10-rc6.
driver...
2017 Jan 10
0
[PATCH] virtio_blk: fix panic in initialization error path
On Mon, Jan 09, 2017 at 11:44:12AM -0800, Omar Sandoval wrote:
> From: Omar Sandoval <osandov at fb.com>
>
> If blk_mq_init_queue() returns an error, it gets assigned to
> vblk->disk->queue. Then, when we call put_disk(), we end up calling
> blk_put_queue() with the ERR_PTR, causing a bad dereference. Fix it by
> only assigning to vblk->disk->queue on success....
2017 Mar 01
1
[PATCH] virtio-console: avoid DMA from stack
On Wed, Feb 01, 2017 at 07:17:12PM +0530, Amit Shah wrote:
> On (Wed) 01 Feb 2017 [00:02:27], Omar Sandoval wrote:
> > From: Omar Sandoval <osandov at fb.com>
> >
> > put_chars() stuffs the buffer it gets into an sg, but that buffer may be
> > on the stack. This breaks with CONFIG_VMAP_STACK=y (for me, it
> > manifested as printks getting turned into NUL bytes).
>
> Seems reasonable. I wonder since all imple...
2017 Mar 01
1
[PATCH] virtio-console: avoid DMA from stack
On Wed, Feb 01, 2017 at 07:17:12PM +0530, Amit Shah wrote:
> On (Wed) 01 Feb 2017 [00:02:27], Omar Sandoval wrote:
> > From: Omar Sandoval <osandov at fb.com>
> >
> > put_chars() stuffs the buffer it gets into an sg, but that buffer may be
> > on the stack. This breaks with CONFIG_VMAP_STACK=y (for me, it
> > manifested as printks getting turned into NUL bytes).
>
> Seems reasonable. I wonder since all imple...
2017 Feb 01
0
[PATCH] virtio-console: avoid DMA from stack
On (Wed) 01 Feb 2017 [00:02:27], Omar Sandoval wrote:
> From: Omar Sandoval <osandov at fb.com>
>
> put_chars() stuffs the buffer it gets into an sg, but that buffer may be
> on the stack. This breaks with CONFIG_VMAP_STACK=y (for me, it
> manifested as printks getting turned into NUL bytes).
Seems reasonable. I wonder since all implementations of hvc do a
memcpy,...