Displaying 3 results from an estimated 3 matches for "originallinkag".
Did you mean:
originallinkage
2018 May 09
0
lld + ThinLTO + fprofile-generate causes duplicate symbol errors
...vm/lib/LTO/LTO.cpp b/llvm/lib/LTO/LTO.cpp
index 7e8b9b3c6390..ee11d07d6b8e 100644
--- a/llvm/lib/LTO/LTO.cpp
+++ b/llvm/lib/LTO/LTO.cpp
@@ -287,7 +287,7 @@ static void thinLTOResolveWeakForLinkerGUID(
recordNewLinkage) {
for (auto &S : GVSummaryList) {
GlobalValue::LinkageTypes OriginalLinkage = S->linkage();
- if (!GlobalValue::isWeakForLinker(OriginalLinkage))
+ if (GlobalValue::isLocalLinkage(OriginalLinkage))
continue;
// We need to emit only one of these. The prevailing module will keep
it,
// but turned into a weak, while the others will drop it when poss...
2018 May 11
1
lld + ThinLTO + fprofile-generate causes duplicate symbol errors
...TO.cpp
> index 7e8b9b3c6390..ee11d07d6b8e 100644
> --- a/llvm/lib/LTO/LTO.cpp
> +++ b/llvm/lib/LTO/LTO.cpp
> @@ -287,7 +287,7 @@ static void thinLTOResolveWeakForLinkerGUID(
> recordNewLinkage) {
> for (auto &S : GVSummaryList) {
> GlobalValue::LinkageTypes OriginalLinkage = S->linkage();
> - if (!GlobalValue::isWeakForLinker(OriginalLinkage))
> + if (GlobalValue::isLocalLinkage(OriginalLinkage))
> continue;
> // We need to emit only one of these. The prevailing module will keep
> it,
> // but turned into a weak, while the...
2018 May 09
2
lld + ThinLTO + fprofile-generate causes duplicate symbol errors
Adding Peter to comment on the linker resolution issue.
>From adding save-temps, it looks like lld and gold are giving different
resolutions to the symbols, which is presumably creating this issue:
(first file is with lld and second is with gold)
$ diff a.out.resolution.txt gold/
4c4
< -r=a.o,__llvm_profile_raw_version,plx
---
> -r=a.o,__llvm_profile_raw_version,l
8,9c8,9
<