search for: order_plus_on

...t: demixing_matrix_size is in bytes but > is used as a parameter to ALLOC() which expects the number of > elements, so twice as much memory is allocated. > > Done. > 7) opus_projection_ambisonics_encoder_init: It appears that > uninitialized values are used from the matrices if order_plus_one is 1 > or 5 to 15. > I will rename the function that validates the correct order before this is called (It fails and hence the init() func fails if order_plus_one is < 2 or > 4.) > > 8) opus_projection_ambisonics_encoder_init: > mixing_matrix_size_in_bytes and demixing_matri...

..._get_size() then you'll also need to include the alignment padding after the matrix data separately from alignment padding on each of the two structs. > >> >> 7) opus_projection_ambisonics_encoder_init: It appears that >> uninitialized values are used from the matrices if order_plus_one is 1 >> or 5 to 15. > > I will rename the function that validates the correct order before this is > called (It fails and hence the init() func fails if order_plus_one is < 2 or >> 4.) Where does it check for order_plus_one < 2 or > 4? The draft allows order 0 and a...

...n bytes but > is used as a parameter to ALLOC() which expects the number of > elements, so twice as much memory is allocated. > > Done. >   > >  7) opus_projection_ambisonics_encoder_init: It appears that > uninitialized values are used from the matrices if order_plus_one is 1 > or 5 to 15. > > I will rename the function that validates the correct order before this > is called (It fails and hence the init() func fails if order_plus_one is > < 2 or > 4.) > > >  8) opus_projection_ambisonics_encoder_init: > mixing_matri...

...jection.c:273) > by 0x100001D06: main (test_opus_projection.c:396) > Uninitialised value was created by a stack allocation > at 0x100001330: test_creation_arguments (test_opus_projection.c:252) > > Additionally, the demixing_matrix appears to be used uninitialized > when order_plus_one is 1 (or greater than 4): > > Conditional jump or move depends on uninitialised value(s) > at 0x10006A6DF: opus_projection_encoder_init_impl > (opus_projection_encoder.c:125) > by 0x10006A9CA: opus_projection_ambisonics_encoder_init > (opus_projection_encoder.c:196) >...

...t32. 6) opus_projection_decoder_init: demixing_matrix_size is in bytes but is used as a parameter to ALLOC() which expects the number of elements, so twice as much memory is allocated. 7) opus_projection_ambisonics_encoder_init: It appears that uninitialized values are used from the matrices if order_plus_one is 1 or 5 to 15. 8) opus_projection_ambisonics_encoder_init: mixing_matrix_size_in_bytes and demixing_matrix_size_in_bytes should be opus_int32. - Mark

On 11/09/2017 01:58 PM, Drew Allen wrote: > Attached is a quick patch that addresses a bug when exporting the matrix > from the encoder. Actually, I don't see what your encoder change is supposed to do. Are there cases where demixing_matrix->rows != nb_output_streams ? Cheers, Jean-Marc > Cheers, > Drew > > On Wed, Nov 8, 2017 at 4:44 PM Drew Allen <bitllama at

Hello all, Attached is the initial proposed implementation for ch.mapping 253/3, based on the IETF proposal: https://tools.ietf.org/html/draft-ietf-codec-ambisonics-03 A brief overview of the patch, as it is slightly lengthy: After discussion with Jean-Marc, we determined that ch.253/3 will need the demixing matrix as part of the encoder/decoder struct stack and thus will require a new

...main (test_opus_projection.c:396) >>> Uninitialised value was created by a stack allocation >>> at 0x100001330: test_creation_arguments (test_opus_projection.c:252) >>> >>> Additionally, the demixing_matrix appears to be used uninitialized >>> when order_plus_one is 1 (or greater than 4): >>> >>> Conditional jump or move depends on uninitialised value(s) >>> at 0x10006A6DF: opus_projection_encoder_init_impl >>> (opus_projection_encoder.c:125) >>> by 0x10006A9CA: opus_projection_ambisonics_encoder_init &...

...tion_arguments (test_opus_projection.c:273) by 0x100001D06: main (test_opus_projection.c:396) Uninitialised value was created by a stack allocation at 0x100001330: test_creation_arguments (test_opus_projection.c:252) Additionally, the demixing_matrix appears to be used uninitialized when order_plus_one is 1 (or greater than 4): Conditional jump or move depends on uninitialised value(s) at 0x10006A6DF: opus_projection_encoder_init_impl (opus_projection_encoder.c:125) by 0x10006A9CA: opus_projection_ambisonics_encoder_init (opus_projection_encoder.c:196) by 0x10006AC7B: opus_projecti...

...by 0x100001D06: main (test_opus_projection.c:396) >> Uninitialised value was created by a stack allocation >> at 0x100001330: test_creation_arguments (test_opus_projection.c:252) >> >> Additionally, the demixing_matrix appears to be used uninitialized >> when order_plus_one is 1 (or greater than 4): >> >> Conditional jump or move depends on uninitialised value(s) >> at 0x10006A6DF: opus_projection_encoder_init_impl >> (opus_projection_encoder.c:125) >> by 0x10006A9CA: opus_projection_ambisonics_encoder_init >> (opus_projec...