Displaying 6 results from an estimated 6 matches for "opuspencod".
Did you mean:
opus_encode
2017 Oct 04
3
[PATCH] Support for Channel Mapping 253.
...know better than I do on that one, but for
the new _ctl_va_list() calls, I believe the convention is for va_start()
and va_end() to appear in the caller rather than in in the va_list()
function itself.
3) I'm not sure I understand why the opus_copy_channel_out*() functions
had to be moved.
4) OpusPEncoder: I'd prefer a more explicit name: OpusProjectionEncoder
5) Do you need to expose the "generic" opus_projection_encode() and
opus_projection_encode_float() in the API?
6) In mapping_matrix_multiply_float(), for the !FIXED_POINT case you're
multiplying by (1.f / 32768.f), but I...
2017 Oct 10
0
[PATCH] Support for Channel Mapping 253.
...to appear in the caller rather than in in the va_list()
function itself.
*My understanding is that it's impossible to pass ellipsis to another
function.*
3) I'm not sure I understand why the opus_copy_channel_out*() functions
had to be moved.
*Not sure how that happened. Reverted.*
4) OpusPEncoder: I'd prefer a more explicit name: OpusProjectionEncoder
*Done.*
5) Do you need to expose the "generic" opus_projection_encode() and
opus_projection_encode_float() in the API?
*I'm confused... How else would people be able to encode a packet of audio
using the projection enco...
2017 Oct 10
2
[PATCH] Support for Channel Mapping 253.
...then you need the endianness, but if you do (my_short>>8), you always
get the most significant byte. Similarly, (my_short&0xff) is always the
least significant byte. No need for an endianness check.
> 10) Please don't store pointers (MappingMatrix, OpusMSEncoder, ...) in
> the OpusPEncoder/OpusPDecoder structs. All the data should be in a
> single struct with no pointers (except to constant data) so that they
> can be shallow-copied.
>
> *Done.*
Well, I still see pointers in your OpusProjectionDecoder.
Cheers,
Jean-Marc
> On Wed, Oct 4, 2017 at 10:30 AM Jean-Ma...
2017 Oct 10
0
[PATCH] Support for Channel Mapping 253.
...nness, but if you do (my_short>>8), you always
> get the most significant byte. Similarly, (my_short&0xff) is always the
> least significant byte. No need for an endianness check.
>
> > 10) Please don't store pointers (MappingMatrix, OpusMSEncoder, ...) in
> > the OpusPEncoder/OpusPDecoder structs. All the data should be in a
> > single struct with no pointers (except to constant data) so that they
> > can be shallow-copied.
> >
> > *Done.*
>
> Well, I still see pointers in your OpusProjectionDecoder.
>
> Cheers,
>
> Je...
2017 Oct 11
2
[PATCH] Support for Channel Mapping 253.
...do (my_short>>8), you always
> get the most significant byte. Similarly, (my_short&0xff) is always the
> least significant byte. No need for an endianness check.
>
> > 10) Please don't store pointers (MappingMatrix, OpusMSEncoder, ...) in
> > the OpusPEncoder/OpusPDecoder structs. All the data should be in a
> > single struct with no pointers (except to constant data) so that they
> > can be shallow-copied.
> >
> > *Done.*
>
> Well, I still see pointers in your OpusProjectionDecoder.
>
> Ch...
2017 Sep 19
3
[PATCH] Support for Channel Mapping 253.
Hello all,
Attached is an up-to-date patch for supporting channel mapping 253. Please
advise and Thank you for your time.
Cheers,
Drew
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xiph.org/pipermail/opus/attachments/20170919/055d9034/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: