Displaying 6 results from an estimated 6 matches for "opuspdecoder".
Did you mean:
opus_decoder
2017 Oct 04
3
[PATCH] Support for Channel Mapping 253.
...n't have to even detect it. I
think something like this (untested) should work for both little-endian
and big endian:
for (i=0;i<...;i++)
short_ptr[i] = char_ptr[2*i] + (char_ptr[2*i] << 8);
10) Please don't store pointers (MappingMatrix, OpusMSEncoder, ...) in
the OpusPEncoder/OpusPDecoder structs. All the data should be in a
single struct with no pointers (except to constant data) so that they
can be shallow-copied.
Cheers,
Jean-Marc
On 27/09/17 03:19 PM, Drew Allen wrote:
> Hello all,
>
> Here is an updated patch for channel mapping 253 support using the
> proposed...
2017 Oct 10
2
[PATCH] Support for Channel Mapping 253.
...d the endianness, but if you do (my_short>>8), you always
get the most significant byte. Similarly, (my_short&0xff) is always the
least significant byte. No need for an endianness check.
> 10) Please don't store pointers (MappingMatrix, OpusMSEncoder, ...) in
> the OpusPEncoder/OpusPDecoder structs. All the data should be in a
> single struct with no pointers (except to constant data) so that they
> can be shallow-copied.
>
> *Done.*
Well, I still see pointers in your OpusProjectionDecoder.
Cheers,
Jean-Marc
> On Wed, Oct 4, 2017 at 10:30 AM Jean-Marc Valin <jm...
2017 Oct 10
0
[PATCH] Support for Channel Mapping 253.
...short_ptr[i] = char_ptr[2*i] + (char_ptr[2*i] << 8);
*Can you show how to go from short -> char as well? I'm alittle confused on
how this can be done without knowing the endianness first.*
10) Please don't store pointers (MappingMatrix, OpusMSEncoder, ...) in
the OpusPEncoder/OpusPDecoder structs. All the data should be in a
single struct with no pointers (except to constant data) so that they
can be shallow-copied.
*Done.*
On Wed, Oct 4, 2017 at 10:30 AM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote:
> Hi Drew,
>
> Here's some comments on your patch (in no par...
2017 Oct 10
0
[PATCH] Support for Channel Mapping 253.
...you do (my_short>>8), you always
> get the most significant byte. Similarly, (my_short&0xff) is always the
> least significant byte. No need for an endianness check.
>
> > 10) Please don't store pointers (MappingMatrix, OpusMSEncoder, ...) in
> > the OpusPEncoder/OpusPDecoder structs. All the data should be in a
> > single struct with no pointers (except to constant data) so that they
> > can be shallow-copied.
> >
> > *Done.*
>
> Well, I still see pointers in your OpusProjectionDecoder.
>
> Cheers,
>
> Jean-Marc
>
&g...
2017 Oct 11
2
[PATCH] Support for Channel Mapping 253.
...>>8), you always
> get the most significant byte. Similarly, (my_short&0xff) is always the
> least significant byte. No need for an endianness check.
>
> > 10) Please don't store pointers (MappingMatrix, OpusMSEncoder, ...) in
> > the OpusPEncoder/OpusPDecoder structs. All the data should be in a
> > single struct with no pointers (except to constant data) so that they
> > can be shallow-copied.
> >
> > *Done.*
>
> Well, I still see pointers in your OpusProjectionDecoder.
>
> Cheers,
>
>...
2017 Sep 19
3
[PATCH] Support for Channel Mapping 253.
Hello all,
Attached is an up-to-date patch for supporting channel mapping 253. Please
advise and Thank you for your time.
Cheers,
Drew
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xiph.org/pipermail/opus/attachments/20170919/055d9034/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: