search for: opusgenericencoder

...unctions in the libopusenc library. + if (_oge_use_projection(h->channel_mapping)) + { + len=27+(h->channels*(h->nb_streams+h->nb_coupled)*2); + } + else + { + len=27+h->channels; + } The fixed part of the header is 19 bytes; where does the 27 come from here? +struct OpusGenericEncoder { + OpusMSEncoder *ms; +#ifdef OPUS_HAVE_OPUS_PROJECTION_H + OpusProjectionEncoder *pr; +#endif + int family; +}; opus_multistream.h needs to be included for OpusMSEncoder. opus_projection.h can't be relied upon to include it since opus_projection.h may not be available. +OpusGenericEncod...

Hi Drew, I think the libopusenc patch is better, but there's still a few issues left: 1) The static MAX_PACKET_BUFFER_SIZE value is still problematic because if you link libopusenc with a new version of libopus that supports higher order projection or just more projection channels for order 3, then you will overflow the buffer. I think what you'd want is a _ope_opus_header_get_size() call

Just to confirm, I would use opeint_* for all the OpusGenericEncoder-related functions? On Tue, Mar 20, 2018 at 8:38 AM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote: > Hi Mark, Drew, > > On 03/20/2018 02:40 AM, Mark Harris wrote: > > + int _oge_use_projection(int channel_mapping); > > > > These functions are part of libopusenc, so...

Attached is an updated patch based on Jean-Marc and Mark's comments. :) Cheers, Drew On Tue, Mar 20, 2018 at 9:20 AM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote: > On 03/20/2018 11:51 AM, Drew Allen wrote: > > Just to confirm, I would use opeint_* for all the > > OpusGenericEncoder-related functions? > > Correct. Or you can also use oge_ if you like. Just don't use something > that starts with an underscore. > > > > On Tue, Mar 20, 2018 at 8:38 AM Jean-Marc Valin <jmvalin at jmvalin.ca > > <mailto:jmvalin at jmvalin.ca>> wrote: >...

...gt; > > On Tue, Mar 20, 2018 at 9:20 AM Jean-Marc Valin <jmvalin at jmvalin.ca > > <mailto:jmvalin at jmvalin.ca>> wrote: > > > > On 03/20/2018 11:51 AM, Drew Allen wrote: > > > Just to confirm, I would use opeint_* for all the > > > OpusGenericEncoder-related functions? > > > > Correct. Or you can also use oge_ if you like. Just don't use > something > > that starts with an underscore. > > > > > > > On Tue, Mar 20, 2018 at 8:38 AM Jean-Marc Valin > > <jmvalin at jmvalin.ca &l...

...20 AM Jean-Marc Valin <jmvalin at jmvalin.ca >>> > <mailto:jmvalin at jmvalin.ca>> wrote: >>> > >>> > On 03/20/2018 11:51 AM, Drew Allen wrote: >>> > > Just to confirm, I would use opeint_* for all the >>> > > OpusGenericEncoder-related functions? >>> > >>> > Correct. Or you can also use oge_ if you like. Just don't use >>> something >>> > that starts with an underscore. >>> > >>> > >>> > > On Tue, Mar 20, 2018 at 8:38 AM Je...

On 03/20/2018 11:51 AM, Drew Allen wrote: > Just to confirm, I would use opeint_* for all the > OpusGenericEncoder-related functions? Correct. Or you can also use oge_ if you like. Just don't use something that starts with an underscore. > On Tue, Mar 20, 2018 at 8:38 AM Jean-Marc Valin <jmvalin at jmvalin.ca > <mailto:jmvalin at jmvalin.ca>> wrote: > > Hi Mark, Drew, > &...

...t; > Cheers, > Drew > > On Tue, Mar 20, 2018 at 9:20 AM Jean-Marc Valin <jmvalin at jmvalin.ca > <mailto:jmvalin at jmvalin.ca>> wrote: > > On 03/20/2018 11:51 AM, Drew Allen wrote: > > Just to confirm, I would use opeint_* for all the > > OpusGenericEncoder-related functions? > > Correct. Or you can also use oge_ if you like. Just don't use something > that starts with an underscore. > > > > On Tue, Mar 20, 2018 at 8:38 AM Jean-Marc Valin > <jmvalin at jmvalin.ca <mailto:jmvalin at jmvalin.ca> &g...

..., Mar 20, 2018 at 9:20 AM Jean-Marc Valin <jmvalin at jmvalin.ca >> > <mailto:jmvalin at jmvalin.ca>> wrote: >> > >> > On 03/20/2018 11:51 AM, Drew Allen wrote: >> > > Just to confirm, I would use opeint_* for all the >> > > OpusGenericEncoder-related functions? >> > >> > Correct. Or you can also use oge_ if you like. Just don't use >> something >> > that starts with an underscore. >> > >> > >> > > On Tue, Mar 20, 2018 at 8:38 AM Jean-Marc Valin >> >...

...; <mailto:jmvalin at jmvalin.ca>> wrote: >>>>>>> > >>>>>>> > On 03/20/2018 11:51 AM, Drew Allen wrote: >>>>>>> > > Just to confirm, I would use opeint_* for all the >>>>>>> > > OpusGenericEncoder-related functions? >>>>>>> > >>>>>>> > Correct. Or you can also use oge_ if you like. Just don't use >>>>>>> something >>>>>>> > that starts with an underscore. >>>>>>> >...