search for: opus_uint32

...TDINT_H) || defined(_STDINT_H_)) || defined (HAVE_STDINT_H)) -#include <stdint.h> +# include <stdint.h> + typedef int8_t opus_int8; + typedef uint8_t opus_uint8; typedef int16_t opus_int16; typedef uint16_t opus_uint16; typedef int32_t opus_int32; typedef uint32_t opus_uint32; + typedef int64_t opus_int64; + typedef uint64_t opus_uint64; + #elif defined(_WIN32) # if defined(__CYGWIN__) -# include <_G_config.h> - typedef _G_int32_t opus_int32; - typedef _G_uint32_t opus_uint32; - typedef _G_int16 opus_int16; - typedef _G_uint16 opus_u...

...AMAGE. +*/ + +/* Original code from libtheora modified to suit to Opus */ + +#ifdef HAVE_CONFIG_H +#include "config.h" +#endif + +#include "armcpu.h" + +#if !defined(ARM_ASM) || \ + !defined(ARMv5E_ASM) && !defined(ARMv6_ASM) && \ + !defined(ARM_HAVE_NEON) +opus_uint32 opus_cpu_capa(void) +{ + return 0; +} +#elif defined(_MSC_VER) +/*For GetExceptionCode() and EXCEPTION_ILLEGAL_INSTRUCTION.*/ +# define WIN32_LEAN_AND_MEAN +# define WIN32_EXTRA_LEAN +# include <windows.h> + +opus_uint32 opus_cpu_capa(void){ + opus_uint32 flags; + flags=0; + /*MSVC has no...

...(int argc, char *argv[]) double bits=0.0, bits_max=0.0, bits_act=0.0, bits2=0.0, nrg; double tot_samples=0; opus_uint64 tot_in, tot_out; - int bandwidth=-1; + int bandwidth=OPUS_AUTO; const char *bandwidth_string; int lost = 0, lost_prev = 1; int toggle = 0; opus_uint32 enc_final_range[2]; opus_uint32 dec_final_range; int encode_only=0, decode_only=0; - int max_frame_size = 960*6; + int max_frame_size = 48000*2; int curr_read=0; int sweep_bps = 0; int random_framesize=0, newsize=0, delayed_celt=0; @@ -336,15 +336,12 @@ int main(int a...

...l fail anyway if a valid value is not found. --- tests/test_opus_common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/test_opus_common.h b/tests/test_opus_common.h index ff7f0142..8b878607 100644 --- a/tests/test_opus_common.h +++ b/tests/test_opus_common.h @@ -64,6 +64,8 @@ static opus_uint32 iseed; #ifdef __GNUC__ __attribute__((noreturn)) +#elif _MSC_VER +__declspec(noreturn) #endif static OPUS_INLINE void _test_failed(const char *file, int line) { -- 2.13.2.932.g7449e964c-goog

...celt/arm/armcpu.c | 19 +++++++++++++++---- celt/x86/x86cpu.c | 22 ++++++++++++++-------- 2 files changed, 29 insertions(+), 12 deletions(-) diff --git a/celt/arm/armcpu.c b/celt/arm/armcpu.c index 1768525..26aae09 100644 --- a/celt/arm/armcpu.c +++ b/celt/arm/armcpu.c @@ -151,24 +151,35 @@ opus_uint32 opus_cpu_capabilities(void) "your platform. Reconfigure with --disable-rtcd (or send patches)." #endif -int opus_select_arch(void) +static int detected = 0; +static int arch_arm = 0; + +static int opus_select_arch_real(void) { opus_uint32 flags = opus_cpu_capabilities(); in...

Attached small patch fixes a minor typo in return type of op_serialno() i.e. changes ogg_uint32_t to opus_uint32 to match the header. One doesn't usually hit this, but if one actually does (e.g. when using a differently configured config_types.h with a long vs int conflict in int32 typedef) it results in a build failure. -- O.S. -------------- next part -------------- A non-text attachment was scrubbed....

...pus_common.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tests/test_opus_common.h b/tests/test_opus_common.h >> index ff7f0142..8b878607 100644 >> --- a/tests/test_opus_common.h >> +++ b/tests/test_opus_common.h >> @@ -64,6 +64,8 @@ static opus_uint32 iseed; >> >> #ifdef __GNUC__ >> __attribute__((noreturn)) >> +#elif _MSC_VER > > defined(_MSC_VER) would avoid any new warnings from -Wundef. > >> +__declspec(noreturn) >> #endif >> static OPUS_INLINE void _test_failed(const char *file, int l...

Hi Jean-Marc, well spotted! The patch provided fixes the issue for me. Nevertheless, in my code (and I would suggest doing the same in libopus) I am going to replace the function with one that accumulates on 64 bits and then calculates the shift, for at least 4 reasons: - It is less and simpler code - The result is likely to be slightly more accurate in case big numbers come early in the

..., we were careful to avoid the undefined behaviour here. In fact, we are specifically running a clang test detecting undefined behaviour. If you look at the silk_SMLABB_ovflw() macro, you will see it is based on silk_ADD32_ovflw(), which is defined as: #define silk_ADD32_ovflw(a, b) ((opus_int32)((opus_uint32)(a) + (opus_uint32)(b))) By casting to unsigned, all the cases are well defined. The cast back to int is implementation-defined but we are already assuming two's complement behaviour every time we are shifting. As for using the 64-bit version anyway, I'm not sure of the impact since I'...

Following Tim's comments, here are my reworked patches for the Neon intrinsic function patches of of my Aarch64 patchset, i.e. replacing patches 5-8 of the v2 series. Patches 1-4 and 9-18 of the old series still apply unmodified. The one new (as opposed to changed) patch is the first one in this series, to add named constants for the ARM architecture variants. There are also some minor code

...id the undefined behaviour here. In > fact, we are specifically running a clang test detecting undefined > behaviour. If you look at the silk_SMLABB_ovflw() macro, you will see it > is based on silk_ADD32_ovflw(), which is defined as: > > #define silk_ADD32_ovflw(a, b) ((opus_int32)((opus_uint32)(a) + > (opus_uint32)(b))) > > By casting to unsigned, all the cases are well defined. The cast back to > int is implementation-defined but we are already assuming two's > complement behaviour every time we are shifting. > > As for using the 64-bit version anyway, I'm n...

...> --- > tests/test_opus_common.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/test_opus_common.h b/tests/test_opus_common.h > index ff7f0142..8b878607 100644 > --- a/tests/test_opus_common.h > +++ b/tests/test_opus_common.h > @@ -64,6 +64,8 @@ static opus_uint32 iseed; > > #ifdef __GNUC__ > __attribute__((noreturn)) > +#elif _MSC_VER defined(_MSC_VER) would avoid any new warnings from -Wundef. > +__declspec(noreturn) > #endif > static OPUS_INLINE void _test_failed(const char *file, int line) > { > -- > 2.13.2.932.g7449e...

...FLAGS) $(NE10_CFLAGS) + +$(CELT_ARM_NEON_INTR_OBJ) $(OPT_UNIT_TEST_OBJ): CFLAGS += $(OPUS_ARM_NEON_INTR_CFLAGS) $(NE10_CFLAGS) endif diff --git a/celt/arm/armcpu.c b/celt/arm/armcpu.c index 1768525..5e5d10c 100644 --- a/celt/arm/armcpu.c +++ b/celt/arm/armcpu.c @@ -73,7 +73,7 @@ static OPUS_INLINE opus_uint32 opus_cpu_capabilities(void){ __except(GetExceptionCode()==EXCEPTION_ILLEGAL_INSTRUCTION){ /*Ignore exception.*/ } -# if defined(OPUS_ARM_MAY_HAVE_NEON) +# if defined(OPUS_ARM_MAY_HAVE_NEON) || defined(OPUS_ARM_MAY_HAVE_NEON_INTR) __try{ /*VORR q0,q0,q0*/ __emit(0xF220015...

...FLAGS) $(NE10_CFLAGS) + +$(CELT_ARM_NEON_INTR_OBJ) $(OPT_UNIT_TEST_OBJ): CFLAGS += $(OPUS_ARM_NEON_INTR_CFLAGS) $(NE10_CFLAGS) endif diff --git a/celt/arm/armcpu.c b/celt/arm/armcpu.c index 1768525..5e5d10c 100644 --- a/celt/arm/armcpu.c +++ b/celt/arm/armcpu.c @@ -73,7 +73,7 @@ static OPUS_INLINE opus_uint32 opus_cpu_capabilities(void){ __except(GetExceptionCode()==EXCEPTION_ILLEGAL_INSTRUCTION){ /*Ignore exception.*/ } -# if defined(OPUS_ARM_MAY_HAVE_NEON) +# if defined(OPUS_ARM_MAY_HAVE_NEON) || defined(OPUS_ARM_MAY_HAVE_NEON_INTR) __try{ /*VORR q0,q0,q0*/ __emit(0xF220015...

The attached patch cleans up Opus's x86 intrinsics configury. It: * Makes ?enable-intrinsics work with clang and other non-GCC compilers * Enables RTCD for the floating-point-mode SSE code in Celt. * Disables use of RTCD in cases where the compiler targets an instruction set by default. * Enables the SSE4.1 Silk optimizations that apply to the common parts of Silk when Opus is built in

Hi All, Since I continue to base my work on top of Jonathan's patch, and my previous Ne10 fft/ifft/mdct_forward/backward patches, I thought it would be better to just post all new patches as a patch series. Please let me know if anyone disagrees with this approach. You can see wip branch of all latest patches at https://git.linaro.org/people/viswanath.puttagunta/opus.git Branch:

Hi Timothy, As I mentioned earlier [1], I now fixed compile issues with fixed point and resubmitting the patch. I also have new patch that does intrinsics optimizations for celt_pitch_xcorr targetting aarch64. You can find my latest work-in-progress branch at [2] For reference, you can use the Ne10 pre-built libraries at [3] Note that I am working with Phil at ARM to get my patch at [4]

Hello opus-dev, I've been cooking up this patchset to integrate NE10 library into opus. Current patchset focuses on encode use case mainly effecting performance of clt_mdct_forward() and opus_fft() (for float only) Glad to report the following on Encode use case: (Measured on my Beaglebone Black Cortex-A8 board) - Performance improvement for encode use case ~= 12.34% (Based on time -p

Hi All, As per Timothy's suggestion, disabling mdct_forward for fixed point. Only effects armv7,armv8: Extend fixed fft NE10 optimizations to mdct Rest of patches are same as in [1] For reference, latest wip code for opus is at [2] Still working with NE10 team at ARM to get corner cases of mdct_forward. Will update with another patch when issue in NE10 gets fixed. Regards, Vish [1]:

Hi All, Changes from RFC v2 [1] armv7,armv8: Extend fixed fft NE10 optimizations to mdct - Overflow issue fixed by Phil at ARM. Ne10 wip at [2]. Should be upstream soon. - So, re-enabled using fixed fft for mdct_forward which was disabled in RFCv2 armv7,armv8: Optimize fixed point fft using NE10 library - Thanks to Jonathan Lennox, fixed some build fixes on iOS and some copy-paste errors Rest