Displaying 16 results from an estimated 16 matches for "opus_projection_encode_float".
2017 Oct 04
3
[PATCH] Support for Channel Mapping 253.
...rather than in in the va_list()
function itself.
3) I'm not sure I understand why the opus_copy_channel_out*() functions
had to be moved.
4) OpusPEncoder: I'd prefer a more explicit name: OpusProjectionEncoder
5) Do you need to expose the "generic" opus_projection_encode() and
opus_projection_encode_float() in the API?
6) In mapping_matrix_multiply_float(), for the !FIXED_POINT case you're
multiplying by (1.f / 32768.f), but I think in the FIXED_POINT case, you
should instead >>15
7) In mapping_matrix_multiply_short(), I would prefer >>15 instead of
/32768 even though most compiler...
2017 Oct 10
2
[PATCH] Support for Channel Mapping 253.
...mean is that I *think* you should remove the calls to
va_end() from _ctl_va_list() calls and instead have the regular _ctl()
functions call va_end(). That appears to be how functions like vprintf()
are called.
> 5) Do you need to expose the "generic" opus_projection_encode() and
> opus_projection_encode_float() in the API?
>
> *I'm confused... How else would people be able to encode a packet of
> audio using the projection encoder? *
Sorry, I got confused when reviewing. Forget about that point!
> 6) In mapping_matrix_multiply_float(), for the !FIXED_POINT case you're
> multipl...
2017 Oct 10
0
[PATCH] Support for Channel Mapping 253.
...) I'm not sure I understand why the opus_copy_channel_out*() functions
had to be moved.
*Not sure how that happened. Reverted.*
4) OpusPEncoder: I'd prefer a more explicit name: OpusProjectionEncoder
*Done.*
5) Do you need to expose the "generic" opus_projection_encode() and
opus_projection_encode_float() in the API?
*I'm confused... How else would people be able to encode a packet of audio
using the projection encoder? *
6) In mapping_matrix_multiply_float(), for the !FIXED_POINT case you're
multiplying by (1.f / 32768.f), but I think in the FIXED_POINT case, you
should instead >>...
2017 Oct 10
0
[PATCH] Support for Channel Mapping 253.
...hould remove the calls to
> va_end() from _ctl_va_list() calls and instead have the regular _ctl()
> functions call va_end(). That appears to be how functions like vprintf()
> are called.
>
> > 5) Do you need to expose the "generic" opus_projection_encode() and
> > opus_projection_encode_float() in the API?
> >
> > *I'm confused... How else would people be able to encode a packet of
> > audio using the projection encoder? *
>
> Sorry, I got confused when reviewing. Forget about that point!
>
> > 6) In mapping_matrix_multiply_float(), for the !FIXED_PO...
2017 Oct 31
7
[PATCH] Support for Channel Mapping 253.
...ose
> values. If you don't have them, then you have no way of knowing what
> mapping the encoder used, so no way of decoding. Instead, I would just
> return OPUS_BAD_ARG if they're NULL.
>
Done.
>
> 11) So one issue I just noticed is that opus_projection_encode() and
> opus_projection_encode_float() (same for the decoder) use arbitrarily
> large amounts of stack memory for "buf". In opus_multistream_encode()
> that's avoided by converting just two channels at a time, but here it's
> not quite clear how to do that without duplicating a lot of the
> multistream co...
2017 Oct 11
2
[PATCH] Support for Channel Mapping 253.
...s to
> va_end() from _ctl_va_list() calls and instead have the regular _ctl()
> functions call va_end(). That appears to be how functions like vprintf()
> are called.
>
> > 5) Do you need to expose the "generic" opus_projection_encode() and
> > opus_projection_encode_float() in the API?
> >
> > *I'm confused... How else would people be able to encode a packet of
> > audio using the projection encoder? *
>
> Sorry, I got confused when reviewing. Forget about that point!
>
> > 6) In mapping_matrix_multiply_floa...
2017 Oct 12
2
[PATCH] Support for Channel Mapping 253.
thanks for all your feedback. here's the revised patch:
On Wed, Oct 11, 2017 at 2:20 PM Timothy B. Terriberry <tterribe at xiph.org>
wrote:
> Jean-Marc Valin wrote:
> > I think you'll want something like:
> > (opus_int16)((unsigned)demixing_matrix[2*i+1] << 8)
> > (though you might want to check it too)
>
> FWIW, we use the construct
> int s =
2017 Nov 03
1
[PATCH] Support for Channel Mapping 253.
...nowing what
> > mapping the encoder used, so no way of decoding. Instead, I would
> just
> > return OPUS_BAD_ARG if they're NULL.
> >
> > Done.
> >
> >
> > 11) So one issue I just noticed is that opus_projection_encode() and
> > opus_projection_encode_float() (same for the decoder) use arbitrarily
> > large amounts of stack memory for "buf". In opus_multistream_encode()
> > that's avoided by converting just two channels at a time, but here
> it's
> > not quite clear how to do that without duplicating...
2017 Oct 31
0
[PATCH] Support for Channel Mapping 253.
...ase where you wouldn't want to get those
values. If you don't have them, then you have no way of knowing what
mapping the encoder used, so no way of decoding. Instead, I would just
return OPUS_BAD_ARG if they're NULL.
11) So one issue I just noticed is that opus_projection_encode() and
opus_projection_encode_float() (same for the decoder) use arbitrarily
large amounts of stack memory for "buf". In opus_multistream_encode()
that's avoided by converting just two channels at a time, but here it's
not quite clear how to do that without duplicating a lot of the
multistream code. If we can't...
2017 Sep 19
3
[PATCH] Support for Channel Mapping 253.
Hello all,
Attached is an up-to-date patch for supporting channel mapping 253. Please
advise and Thank you for your time.
Cheers,
Drew
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xiph.org/pipermail/opus/attachments/20170919/055d9034/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name:
2017 Nov 02
0
[PATCH] Support for Channel Mapping 253.
...39;t have them, then you have no way of knowing what
> mapping the encoder used, so no way of decoding. Instead, I would just
> return OPUS_BAD_ARG if they're NULL.
>
> Done.
>
>
> 11) So one issue I just noticed is that opus_projection_encode() and
> opus_projection_encode_float() (same for the decoder) use arbitrarily
> large amounts of stack memory for "buf". In opus_multistream_encode()
> that's avoided by converting just two channels at a time, but here it's
> not quite clear how to do that without duplicating a lot of the
>...
2017 Nov 07
0
[PATCH] Support for Channel Mapping 253.
...US_BAD_ARG if they're NULL.
> > >
> > > Done.
> > >
> > >
> > > 11) So one issue I just noticed is that
> > opus_projection_encode() and
> > > opus_projection_encode_float() (same for the
> decoder) use
> > arbitrarily
> > > large amounts of stack memory for "buf". In
> > opus_multistream_encode()
> > > that's avoided by converting just two channels at a
>...
2017 Nov 09
2
[PATCH] Support for Channel Mapping 253.
...e.
> > > > >
> > > > >
> > > > > 11) So one issue I just noticed is that
> > > > opus_projection_encode() and
> > > > > opus_projection_encode_float() (same for
> the
> > > decoder) use
> > > > arbitrarily
> > > > > large amounts of stack memory for "buf". In
> > > > opus_multistream_encode()
> >...
2017 Nov 09
0
[PATCH] Support for Channel Mapping 253.
... > > Done.
> > > >
> > > >
> > > > 11) So one issue I just noticed is that
> > > opus_projection_encode() and
> > > > opus_projection_encode_float() (same for the
> > decoder) use
> > > arbitrarily
> > > > large amounts of stack memory for "buf". In
> > > opus_multistream_encode()
> > > >...
2017 Nov 09
0
[PATCH] Support for Channel Mapping 253.
...> > >
>> > > > >
>> > > > > 11) So one issue I just noticed is that
>> > > > opus_projection_encode() and
>> > > > > opus_projection_encode_float() (same for
>> the
>> > > decoder) use
>> > > > arbitrarily
>> > > > > large amounts of stack memory for "buf".
>> In
>> > > > opus_multi...
2017 Nov 10
2
[PATCH] Support for Channel Mapping 253.
...t;
> > > > >
> > > > > 11) So one issue I just noticed
> is that
> > > > opus_projection_encode() and
> > > > > opus_projection_encode_float()
> (same for the
> > > decoder) use
> > > > arbitrarily
> > > > > large amounts of stack memory
> for "buf". In
> > > ...