search for: opus_projection_decoder_ctl

thanks for all your feedback. here's the revised patch: On Wed, Oct 11, 2017 at 2:20 PM Timothy B. Terriberry <tterribe at xiph.org> wrote: > Jean-Marc Valin wrote: > > I think you'll want something like: > > (opus_int16)((unsigned)demixing_matrix[2*i+1] << 8) > > (though you might want to check it too) > > FWIW, we use the construct > int s =

...hout duplicating a lot of the > multistream code. If we can't address the issue with this patch, the > least would be to abort when trying to use these calls with > NONTHREADSAFE_PSEUDOSTACK > Done. Let me know if we should try designing something around this. > > 12) I think opus_projection_decoder_ctl() is missing a va_end() call. > Done. > > > Cheers, > > Jean-Marc > > > > On 10/12/2017 05:44 PM, Drew Allen wrote: > > thanks for all your feedback. here's the revised patch: > > > > On Wed, Oct 11, 2017 at 2:20 PM Timothy B. Terriberry...

...we can't address the issue with this patch, the > > least would be to abort when trying to use these calls with > > NONTHREADSAFE_PSEUDOSTACK > > > > Done. Let me know if we should try designing something around this. > > > > > > 12) I think opus_projection_decoder_ctl() is missing a va_end() call. > > > > > > Done. > > > > > > > > Cheers, > > > > Jean-Marc > > > > > > > > On 10/12/2017 05:44 PM, Drew Allen wrote: > > > thanks for all your feedback. here...

...ed by converting just two channels at a time, but here it's not quite clear how to do that without duplicating a lot of the multistream code. If we can't address the issue with this patch, the least would be to abort when trying to use these calls with NONTHREADSAFE_PSEUDOSTACK 12) I think opus_projection_decoder_ctl() is missing a va_end() call. Cheers, Jean-Marc On 10/12/2017 05:44 PM, Drew Allen wrote: > thanks for all your feedback. here's the revised patch: > > On Wed, Oct 11, 2017 at 2:20 PM Timothy B. Terriberry <tterribe at xiph.org > <mailto:tterribe at xiph.org>> wr...

...> multistream code. If we can't address the issue with this patch, the > least would be to abort when trying to use these calls with > NONTHREADSAFE_PSEUDOSTACK > > Done. Let me know if we should try designing something around this.  > > > 12) I think opus_projection_decoder_ctl() is missing a va_end() call. > > > Done.  > > > > Cheers, > >         Jean-Marc > > > > On 10/12/2017 05:44 PM, Drew Allen wrote: > > thanks for all your feedback. here's the revised patch: > > > > On Wed...

...alls with > >     >     NONTHREADSAFE_PSEUDOSTACK > >     > > >     > Done. Let me know if we should try designing something > around this.  > >     > > >     > > >     >     12) I think opus_projection_decoder_ctl() is missing a > >     va_end() call. > >     > > >     > > >     > Done.  > >     > > >     > > >     > > >     >     Cheers, > >     > >...

...> > > Done. Let me know if we should try designing > > something > > > around this. > > > > > > > > > > > > > > > 12) I think opus_projection_decoder_ctl() > > is missing a > > > > va_end() call. > > > > > > > > > > > > > > > Done. > > > > > > > >...

... >     > > >         >     > Done. Let me know if we should try designing > something > >         around this.  > >         >     > > >         >     > > >         >     >     12) I think opus_projection_decoder_ctl() > is missing a > >         >     va_end() call. > >         >     > > >         >     > > >         >     > Done.  > >         >     > > >         >     > > &...

...t; > Done. Let me know if we should try designing >> > something >> > > around this. >> > > > > >> > > > > >> > > > > 12) I think opus_projection_decoder_ctl() >> > is missing a >> > > > va_end() call. >> > > > > >> > > > > >> > > > > Done. >> > > > > &...

...> designing > >         something > >         >         around this.  > >         >         >     > > >         >         >     > > >         >         >     >     12) I think > opus_projection_decoder_ctl() > >         is missing a > >         >         >     va_end() call. > >         >         >     > > >         >         >     > > >         >         >     > Done.  > >         &gt...