search for: opus_projection_decode

...If this isn't desired, we should make those changes separately. > > > > 2) See above. > > Just noticed the code will actually work because opus_val16 is defined > to the right thing, but I still think it's a bad idea. For example, if > you look at the public header, opus_projection_decode() has a pcm > argument of type opus_int16*, so it's a bit confusing for the C file to > define pcm as opus_val16*, even if the two map to the same. > > > 3) I only zero out initially. For the matrix_multiply_out functions, we > > need to be able to take a single decoded str...

...ntation issues though. > > 1) In opus_multi_stream_decode_float(), you changed the pcm argument > from float* to opus_val16*. That's a mistake and will fail for > fixed-point. This should have shown up as an error on a fixed-point > build. Make sure you test that. > > 2) In opus_projection_decode(), you also changed the pcm argument to an > opus_val16*, which again will cause problems for the same reasons as 1). > Please check you haven't made that same mistake elsewhere. > > 3) In opus_projection_copy_channel_out_float() and > opus_projection_copy_channel_out_short(), yo...

...arately. > > > > > > 2) See above. > > > > Just noticed the code will actually work because opus_val16 is > defined > > to the right thing, but I still think it's a bad idea. For example, > if > > you look at the public header, opus_projection_decode() has a pcm > > argument of type opus_int16*, so it's a bit confusing for the C file > to > > define pcm as opus_val16*, even if the two map to the same. > > > > > 3) I only zero out initially. For the matrix_multiply_out > > functions, we &gt...

...st_creation_arguments(). > opus_projection_ambisonics_encoder_create() is intentionally called > with invalid arguments (initially, channels=0), which causes an error > to be returned and streams and coupled_streams are left uninitialized. > These uninitialized values are passed to > opus_projection_decoder_create(), which does not check that the > arguments are not too large before using them to attempt allocation of > a ridiculous amount of memory. Results may vary depending on the > uninitialized values of streams and coupled_streams. Valgrind reports > several uses of uninitialized...

...above. > > > > > > Just noticed the code will actually work because opus_val16 is > > defined > > > to the right thing, but I still think it's a bad idea. For > > example, if > > > you look at the public header, opus_projection_decode() has a > pcm > > > argument of type opus_int16*, so it's a bit confusing for the > > C file to > > > define pcm as opus_val16*, even if the two map to the same. > > > > > > > 3) I only zero out initially. For the m...

Hello all, Attached is the initial proposed implementation for ch.mapping 253/3, based on the IETF proposal: https://tools.ietf.org/html/draft-ietf-codec-ambisonics-03 A brief overview of the patch, as it is slightly lengthy: After discussion with Jean-Marc, we determined that ch.253/3 will need the demixing matrix as part of the encoder/decoder struct stack and thus will require a new

...us_projection_ambisonics_encoder_create() is intentionally called >>> with invalid arguments (initially, channels=0), which causes an error >>> to be returned and streams and coupled_streams are left uninitialized. >>> These uninitialized values are passed to >>> opus_projection_decoder_create(), which does not check that the >>> arguments are not too large before using them to attempt allocation of >>> a ridiculous amount of memory. Results may vary depending on the >>> uninitialized values of streams and coupled_streams. Valgrind reports >>&gt...

...projection API as well. > If this isn't desired, we should make those changes separately. > > 2) See above. Just noticed the code will actually work because opus_val16 is defined to the right thing, but I still think it's a bad idea. For example, if you look at the public header, opus_projection_decode() has a pcm argument of type opus_int16*, so it's a bit confusing for the C file to define pcm as opus_val16*, even if the two map to the same. > 3) I only zero out initially. For the matrix_multiply_out functions, we > need to be able to take a single decoded stream and add weighted &gt...

...oticed the code will actually work because > > opus_val16 is > > > defined > > > > to the right thing, but I still think it's a bad idea. > For > > > example, if > > > > you look at the public header, opus_projection_decode() > > has a pcm > > > > argument of type opus_int16*, so it's a bit confusing > > for the > > > C file to > > > > define pcm as opus_val16*, even if the two map to the > same. > > > > &gt...

...oticed the code will actually work because > > opus_val16 is > > > defined > > > > to the right thing, but I still think it's a bad idea. > For > > > example, if > > > > you look at the public header, opus_projection_decode() > > has a pcm > > > > argument of type opus_int16*, so it's a bit confusing > > for the > > > C file to > > > > define pcm as opus_val16*, even if the two map to the > same. > > > > &gt...

...sired, we should make those changes separately. > > > > 2) See above. > > Just noticed the code will actually work because opus_val16 is defined > to the right thing, but I still think it's a bad idea. For example, if > you look at the public header, opus_projection_decode() has a pcm > argument of type opus_int16*, so it's a bit confusing for the C file to > define pcm as opus_val16*, even if the two map to the same. > > > 3) I only zero out initially. For the matrix_multiply_out > functions, we > > need to be able to...

...st, an issue occurs in test_creation_arguments(). opus_projection_ambisonics_encoder_create() is intentionally called with invalid arguments (initially, channels=0), which causes an error to be returned and streams and coupled_streams are left uninitialized. These uninitialized values are passed to opus_projection_decoder_create(), which does not check that the arguments are not too large before using them to attempt allocation of a ridiculous amount of memory. Results may vary depending on the uninitialized values of streams and coupled_streams. Valgrind reports several uses of uninitialized values such as: Co...

Hello, Attached is a patch to resolve a memory issue using the Projection API when compiling using a psuedo-stack / limited memory. Please let me any ?s you might have. Cheers, Drew -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20171120/84e36e1b/attachment-0001.html> -------------- next part --------------

...> >     > 2) See above. > > > >     Just noticed the code will actually work because opus_val16 is > defined > >     to the right thing, but I still think it's a bad idea. For > example, if > >     you look at the public header, opus_projection_decode() has a pcm > >     argument of type opus_int16*, so it's a bit confusing for the > C file to > >     define pcm as opus_val16*, even if the two map to the same. > > > >     > 3) I only zero out initially. For the matrix_multiply_out > &g...

...s(). >> opus_projection_ambisonics_encoder_create() is intentionally called >> with invalid arguments (initially, channels=0), which causes an error >> to be returned and streams and coupled_streams are left uninitialized. >> These uninitialized values are passed to >> opus_projection_decoder_create(), which does not check that the >> arguments are not too large before using them to attempt allocation of >> a ridiculous amount of memory. Results may vary depending on the >> uninitialized values of streams and coupled_streams. Valgrind reports >> several uses o...

...; >     >     Just noticed the code will actually work because > opus_val16 is > >     defined > >     >     to the right thing, but I still think it's a bad idea. For > >     example, if > >     >     you look at the public header, opus_projection_decode() > has a pcm > >     >     argument of type opus_int16*, so it's a bit confusing > for the > >     C file to > >     >     define pcm as opus_val16*, even if the two map to the same. > >     > > >     >     > 3) I o...

...   opus_val16 is > >     >     defined > >     >     >     to the right thing, but I still think it's a > bad idea. For > >     >     example, if > >     >     >     you look at the public header, > opus_projection_decode() > >     has a pcm > >     >     >     argument of type opus_int16*, so it's a bit > confusing > >     for the > >     >     C file to > >     >     >     define pcm as opus_val16*, even if the two...

...ually work because >> > opus_val16 is >> > > defined >> > > > to the right thing, but I still think it's a bad idea. >> For >> > > example, if >> > > > you look at the public header, opus_projection_decode() >> > has a pcm >> > > > argument of type opus_int16*, so it's a bit confusing >> > for the >> > > C file to >> > > > define pcm as opus_val16*, even if the two map to the >> same. >&gt...

...k because > >     opus_val16 is > >     >     defined > >     >     >     to the right thing, but I still think it's a bad > idea. For > >     >     example, if > >     >     >     you look at the public header, > opus_projection_decode() > >     has a pcm > >     >     >     argument of type opus_int16*, so it's a bit confusing > >     for the > >     >     C file to > >     >     >     define pcm as opus_val16*, even if the two map to > the same. >...

...> > defined > > > > > to the right thing, but I still think it's a > > bad idea. For > > > > example, if > > > > > you look at the public header, > > opus_projection_decode() > > > has a pcm > > > > > argument of type opus_int16*, so it's a bit > > confusing > > > for the > > > > C file to > > > > > define pcm as...