search for: opus_multistream_encod

Change-Id: I16bd4cd990d8ad5888c9e30016218ac25242ecb5 --- src/opus_multistream_encoder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/opus_multistream_encoder.c b/src/opus_multistream_encoder.c index 30cafe1..c07132f 100644 --- a/src/opus_multistream_encoder.c +++ b/src/opus_multistream_encoder.c @@ -747,7 +747,8 @@ static void ambisonics_rate_allocatio...

Hello, for your consideration. The following patch moves the channel_pos() function from within the #if !defined(DISABLE_FLOAT_API). This change is required when compiling with FIXED_POINT and DISABLE_FLOAT_API defined. #### ### diff --git a/src/opus_multistream_encoder.c b/src/opus_multistream_encoder.c index 3efab53..6f3eb53 100644 --- a/src/opus_multistream_encoder.c +++ b/src/opus_multistream_encoder.c @@ -454,7 +454,9 @@ static int opus_multistream_encode_native unsigned char tmp_data[MS_FRAME_TMP]; OpusRepacketizer rp; opus_int32 complexity;...

Hello, I'm confused as to whether opus_multistream_encode creates a frame or a packet. The function summary says this: Encodes a multistream Opus *frame*. But later on it says: The length of the encoded *packet* (in bytes) on success or a negative > error code (see Error codes<http://www.opus-codec.org/docs/html_api-1.0.2/group__opus__errorcod...

--- src/opus_multistream_encoder.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/opus_multistream_encoder.c b/src/opus_multistream_encoder.c index 6e87337..7163d14 100644 --- a/src/opus_multistream_encoder.c +++ b/src/opus_multistream_encoder.c @@ -98,7 +98,8 @@ static opus_val32 *ms_get_preemph_m...

This fixes the build error here: https://mf4.xiph.org/jenkins/job/opus-pedantic-makefile/886/

Fixes issue #95 on GitHub. --- src/opus_multistream_encoder.c | 57 ++++------------------------------ 1 file changed, 6 insertions(+), 51 deletions(-) diff --git a/src/opus_multistream_encoder.c b/src/opus_multistream_encoder.c index 6cc1f432..9cb9bf34 100644 --- a/src/opus_multistream_encoder.c +++ b/src/opus_multistream_encoder.c @@ -742,20 +742,9 @@...

thanks for all your feedback. here's the revised patch: On Wed, Oct 11, 2017 at 2:20 PM Timothy B. Terriberry <tterribe at xiph.org> wrote: > Jean-Marc Valin wrote: > > I think you'll want something like: > > (opus_int16)((unsigned)demixing_matrix[2*i+1] << 8) > > (though you might want to check it too) > > FWIW, we use the construct > int s =

...5:48 PM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote: > Hi Drew, > > I've had some time to dig more deeply into your patch. Here's some more > in-depth comments: > > 1) I note that your OpusMSEncoder struct in private.h adds a > subframe_mem[] that's not in opus_multistream_encoder.c. I assume it's > due to a merge problem (that field was removed some time ago), but can > you confirm/fix the issue? > Done. Yes, this is a merge conflict. > > 2) I noticed your patch adds many OPUS_EXPORT declarations. OPUS_EXPORT > is only meant for functions exposed to...

...t; > > Hi Drew, > > > > I've had some time to dig more deeply into your patch. Here's some > more > > in-depth comments: > > > > 1) I note that your OpusMSEncoder struct in private.h adds a > > subframe_mem[] that's not in opus_multistream_encoder.c. I assume > it's > > due to a merge problem (that field was removed some time ago), but > can > > you confirm/fix the issue? > > > > Done. Yes, this is a merge conflict. > > > > > > 2) I noticed your patch adds many OPUS_EXPORT dec...

Hi Drew, I've had some time to dig more deeply into your patch. Here's some more in-depth comments: 1) I note that your OpusMSEncoder struct in private.h adds a subframe_mem[] that's not in opus_multistream_encoder.c. I assume it's due to a merge problem (that field was removed some time ago), but can you confirm/fix the issue? 2) I noticed your patch adds many OPUS_EXPORT declarations. OPUS_EXPORT is only meant for functions exposed to the API (and in the include/ directory), but I see several of thes...

Should call celt_inner_prod(). --- celt/bands.c | 7 ++++--- celt/bands.h | 2 +- celt/celt_encoder.c | 6 +++--- celt/pitch.c | 2 +- src/opus_multistream_encoder.c | 2 +- 5 files changed, 10 insertions(+), 9 deletions(-) diff --git a/celt/bands.c b/celt/bands.c index bbe8a4c..1ab24aa 100644 --- a/celt/bands.c +++ b/celt/bands.c @@ -92,10 +92,11 @@ static int bitexact_log2tan(int isin,int icos) #ifdef FIXED_POINT /* Compute the amplitude (sqrt energy...

On Wed, Jun 4, 2014 at 4:31 PM, Timothy B. Terriberry <tterribe at xiph.org> wrote: > Alpha Thinktink wrote: >> max_data_bytes=-11 > > That value is passed in by you. I also don't think passing such a value > would have worked in earlier releases. It indicates the size of the > buffer you are passing to the encoder to receive the encoded output. Actually, I'm

...valin at jmvalin.ca>> wrote: > > Hi Drew, > > I've had some time to dig more deeply into your patch. Here's some more > in-depth comments: > > 1) I note that your OpusMSEncoder struct in private.h adds a > subframe_mem[] that's not in opus_multistream_encoder.c. I assume it's > due to a merge problem (that field was removed some time ago), but can > you confirm/fix the issue? > > Done. Yes, this is a merge conflict.  > > > 2) I noticed your patch adds many OPUS_EXPORT declarations. OPUS_EXPORT > is only m...

...re's > >     some more > >     >     in-depth comments: > >     > > >     >     1) I note that your OpusMSEncoder struct in > private.h adds a > >     >     subframe_mem[] that's not in > opus_multistream_encoder.c. I > >     assume it's > >     >     due to a merge problem (that field was removed some > time ago), > >     but can > >     >     you confirm/fix the issue? > >     > > >     > Done....

...> > > > > > > > > > 1) I note that your OpusMSEncoder struct in > > > private.h adds a > > > > > subframe_mem[] that's not in > > > opus_multistream_encoder.c. I > > > > assume it's > > > > > due to a merge problem (that field was > > removed some > > > time ago), > > > > but can > > >...

...t;     in-depth comments: > >         >     > > >         >     >     1) I note that your OpusMSEncoder struct in > >         private.h adds a > >         >     >     subframe_mem[] that's not in > >         opus_multistream_encoder.c. I > >         >     assume it's > >         >     >     due to a merge problem (that field was > removed some > >         time ago), > >         >     but can > >         >     >     you conf...

...> > >> > > > > 1) I note that your OpusMSEncoder struct >> in >> > > private.h adds a >> > > > > subframe_mem[] that's not in >> > > opus_multistream_encoder.c. I >> > > > assume it's >> > > > > due to a merge problem (that field was >> > removed some >> > > time ago), >> > > > but can >&gt...

Hi folks, This patch will fix the issue. Thanks, Taihei Momma -------------- next part -------------- A non-text attachment was scrubbed... Name: opus_multistream_encoder.diff Type: application/octet-stream Size: 482 bytes Desc: not available Url : http://lists.xiph.org/pipermail/opus/attachments/20130309/5f8d3d1d/attachment.obj

Hello, is the following a valid build option? ./configure CFLAGS="-g -O2 -DDISABLE_FLOAT_API" \ --enable-assertions --enable-fixed-point src/opus_multistream_encoder.c does not compile with that configuration. -- Pedro Becerra

When encoding using the Opus multistream API, is it possible for opus_multistream_encode() to return 0? For example, what happens if multiple streams are being encoded, each with DTX enabled and all streams emit DTX packets at the same time? What about the case of a single stream with DTX enabled? Thanks Kevin O'Connor -------------- next part -------------- An HTML attachment w...