search for: opus_multistream

Hi all! When compiling the program using opusfile the #include <opus/opusfile.h> generates error that # include <opus_multistream.h> is not found. Actually it should be included as # include <opus/opus_multistream.h> just like the ogg.h in the previous line. A small patch attached. -- Best regards, Alexander -------------- next part -------------- A non-text attachment was scrubbed... Name: patch.diff Type: te...

...Felicia -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20170324/1afee1e1/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Fix-OPUS_ARG_NONNULL-indices-in-opus_multistream.h.patch Type: text/x-patch Size: 1284 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/opus/attachments/20170324/1afee1e1/attachment.bin>

On Fri, Mar 24, 2017 at 1:58 PM, Felicia Lim <flim at google.com> wrote: > Hi all, > > The attached patch adds/fixes a few null argument checks in the multistream > API. Do these changes make sense? This looks good except that I think the 5th argument should remain NONNULL on line 276. - Mark

...<ClCompile Include="opus.c" /> <ClCompile Include="opus_decoder.c" /> <ClCompile Include="opus_encoder.c" /> @@ -210,6 +213,8 @@ <ClInclude Include="..\include\opus_types.h" /> <ClInclude Include="..\include\opus_multistream.h" /> <ClInclude Include="..\win32\config.h" /> + <ClInclude Include="analysis.h" /> + <ClInclude Include="mlp.h" /> <ClInclude Include="opus_private.h" /> </ItemGroup> <Import Project="$(VCT...

Hi Drew, Here's some comments on your patch (in no particular order): 1) I see that it's adding an #include of stdarg.h to opus_multistream.h Is that left over from the previous version? 2) Someone on this list might know better than I do on that one, but for the new _ctl_va_list() calls, I believe the convention is for va_start() and va_end() to appear in the caller rather than in in the va_list() function itself. 3) I'm not sur...

...s why the includes don't have the "opus/" prefix. Cheers, Jean-Marc On 31/08/17 05:20 AM, Alexander Panchenko wrote: > Hi all! > When compiling the program using opusfile the > > #include <opus/opusfile.h> > > generates error that > > # include <opus_multistream.h> > > is not found. Actually it should be included as > > # include <opus/opus_multistream.h> > > just like the ogg.h in the previous line. > > A small patch attached. > > > > _______________________________________________ > opus mailing list...

...om> schrieb am 10.10.2017 um 20:29 in Nachricht <CABQ9DctQ0+gBgUif7BBJpjjKR7_V_H5OC1JM47w50oaaLXL4Tg at mail.gmail.com>: > Hi Jean-Marc, > > Thanks for the feedback. Attached are my comments and an updated patch. > > 1) I see that it's adding an #include of stdarg.h to opus_multistream.h > Is that left over from the previous version? > > > *That was a typo. Fixed.* > > 2) Someone on this list might know better than I do on that one, but for > the new _ctl_va_list() calls, I believe the convention is for va_start() > and va_end() to appear in the caller...

...> > Cheers, > > Jean-Marc > > On 31/08/17 05:20 AM, Alexander Panchenko wrote: >> Hi all! >> When compiling the program using opusfile the >> >> #include <opus/opusfile.h> >> >> generates error that >> >> # include <opus_multistream.h> >> >> is not found. Actually it should be included as >> >> # include <opus/opus_multistream.h> >> >> just like the ogg.h in the previous line. >> >> A small patch attached. >> >> >> >> ______________________...

Hi Jean-Marc, Thanks for the feedback. Attached are my comments and an updated patch. 1) I see that it's adding an #include of stdarg.h to opus_multistream.h Is that left over from the previous version? *That was a typo. Fixed.* 2) Someone on this list might know better than I do on that one, but for the new _ctl_va_list() calls, I believe the convention is for va_start() and va_end() to appear in the caller rather than in in the va_list() function...

...Wed, Oct 4, 2017 at 10:30 AM Jean-Marc Valin <jmvalin at jmvalin.ca > <mailto:jmvalin at jmvalin.ca>> wrote: > > Hi Drew, > > Here's some comments on your patch (in no particular order): > > 1) I see that it's adding an #include of stdarg.h to opus_multistream.h > Is that left over from the previous version? > > 2) Someone on this list might know better than I do on that one, but for > the new _ctl_va_list() calls, I believe the convention is for va_start() > and va_end() to appear in the caller rather than in in the va_li...

Hello all, Attached is an up-to-date patch for supporting channel mapping 253. Please advise and Thank you for your time. Cheers, Drew -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20170919/055d9034/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name:

...c Valin <jmvalin at jmvalin.ca > > <mailto:jmvalin at jmvalin.ca>> wrote: > > > > Hi Drew, > > > > Here's some comments on your patch (in no particular order): > > > > 1) I see that it's adding an #include of stdarg.h to > opus_multistream.h > > Is that left over from the previous version? > > > > 2) Someone on this list might know better than I do on that one, but > for > > the new _ctl_va_list() calls, I believe the convention is for > va_start() > > and va_end() to appear in the...

...jmvalin.ca <mailto:jmvalin at jmvalin.ca>>> wrote: > > > > Hi Drew, > > > > Here's some comments on your patch (in no particular order): > > > > 1) I see that it's adding an #include of stdarg.h to > opus_multistream.h > > Is that left over from the previous version? > > > > 2) Someone on this list might know better than I do on that > one, but for > > the new _ctl_va_list() calls, I believe the convention is for > va_start() > > an...

...AS_ASM_ARM_EDSP([ARMv5E_ASM=1],[ARMv5E_ASM=0]) if test "x${ARMv5E_ASM}" = "x1" ; then diff --git a/opus_headers.mk b/opus_headers.mk index 43a978c..2c7c077 100644 --- a/opus_headers.mk +++ b/opus_headers.mk @@ -2,6 +2,7 @@ OPUS_HEAD = \ include/opus.h \ include/opus_multistream.h \ src/opus_private.h \ +src/cpu_support.h \ src/analysis.h \ src/mlp.h \ src/tansig_table.h diff --git a/opus_sources.mk b/opus_sources.mk index e4eeb91..1e9791b 100644 --- a/opus_sources.mk +++ b/opus_sources.mk @@ -4,7 +4,8 @@ src/opus_encoder.c \ src/opus_multistream.c \ src/opus_multist...

...() call that would return how large the header *actually* is. Then you can use that value instead of MAX_PACKET_BUFFER_SIZE in init_stream() 2) I think the remaining if()s in ope_encoder_ctl() can also be removed by adding another ctl() macro (like _oge_ctl()) with an extra argument. In the case of OPUS_MULTISTREAM_GET_ENCODER_STATE_REQUEST, you can simply use _oge_ctl(enc->st, OPUS_MULTISTREAM_GET_ENCODER_STATE(stream_id, value)) 3) On libopus itself, why "#define OPUS_HAVE_OPUS_PROJECTION_H 9000" instead of just "#define OPUS_HAVE_OPUS_PROJECTION_H"? Cheers, Jean-Marc On 03/19/201...

...(CELT_SOURCES) $(SILK_SOURCES) $(OPUS_SOURCES) libopus_la_LDFLAGS = -no-undefined -version-info @OPUS_LT_CURRENT@:@OPUS_LT_REVISION@:@OPUS_LT_AGE@ libopus_la_LIBADD = $(LIBM) +if ARMv7_NEON_INTRINSICS_FLOAT +libopus_la_LIBADD += ./libneon.la +endif + pkginclude_HEADERS = include/opus.h include/opus_multistream.h include/opus_types.h include/opus_defines.h noinst_HEADERS = $(OPUS_HEAD) $(SILK_HEAD) $(CELT_HEAD) @@ -97,6 +107,9 @@ celt_tests_test_unit_cwrs32_LDADD = $(LIBM) celt_tests_test_unit_dft_SOURCES = celt/tests/test_unit_dft.c celt_tests_test_unit_dft_LDADD = $(LIBM) +if ARMv7_NEON_INTRINSIC...

...RCES = $(CELT_SOURCES) $(SILK_SOURCES) $(OPUS_SOURCES) libopus_la_LDFLAGS = -no-undefined -version-info @OPUS_LT_CURRENT@:@OPUS_LT_REVISION@:@OPUS_LT_AGE@ libopus_la_LIBADD = $(LIBM) +if OPUS_ARM_NEON_INTR +libopus_la_LIBADD += ./libarmneon.la +endif pkginclude_HEADERS = include/opus.h include/opus_multistream.h include/opus_types.h include/opus_defines.h @@ -97,6 +106,11 @@ celt_tests_test_unit_cwrs32_LDADD = $(LIBM) celt_tests_test_unit_dft_SOURCES = celt/tests/test_unit_dft.c celt_tests_test_unit_dft_LDADD = $(LIBM) +if OPUS_ARM_NEON_INTR +celt_tests_test_unit_dft_LDADD += ./libarmneon.la +endif...

...ms+h->nb_coupled)*2); + } + else + { + len=27+h->channels; + } The fixed part of the header is 19 bytes; where does the 27 come from here? +struct OpusGenericEncoder { + OpusMSEncoder *ms; +#ifdef OPUS_HAVE_OPUS_PROJECTION_H + OpusProjectionEncoder *pr; +#endif + int family; +}; opus_multistream.h needs to be included for OpusMSEncoder. opus_projection.h can't be relied upon to include it since opus_projection.h may not be available. +OpusGenericEncoder *_oge_surround_create( + int Fs, int channels, int channel_mapping, int *nb_streams, + int *nb_coupled, unsigned char *stream_...

Hello, This patch introduces ARM NEON Intrinsics to optimize kf_bfly4 routine in celt part of libopus. Using NEON optimized kf_bfly4(_neon) routine helped improve performance of opus_fft_impl function by about 21.4%. The end use case was decoding a music opus ogg file. The end use case saw performance improvement of about 4.47%. This patch has 2 components i. Actual neon code to improve

...tests/test_opus_padding +tests/test_unit_optimization celt/arm/armopts.s celt/dump_modes/dump_modes celt/tests/test_unit_cwrs32 diff --git a/Makefile.am b/Makefile.am index 7a69114..2bfb923 100644 --- a/Makefile.am +++ b/Makefile.am @@ -84,9 +84,36 @@ pkginclude_HEADERS = include/opus.h include/opus_multistream.h include/opus_type noinst_HEADERS = $(OPUS_HEAD) $(SILK_HEAD) $(CELT_HEAD) if EXTRA_PROGRAMS -noinst_PROGRAMS = opus_demo repacketizer_demo opus_compare tests/test_opus_api tests/test_opus_encode tests/test_opus_decode tests/test_opus_padding celt/tests/test_unit_cwrs32 celt/tests/test_unit_df...