search for: opus_multi_stream_decode_float

Hello, Attached is a patch to resolve a memory issue using the Projection API when compiling using a psuedo-stack / limited memory. Please let me any ?s you might have. Cheers, Drew -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20171120/84e36e1b/attachment-0001.html> -------------- next part --------------

...21, 2017 at 7:39 PM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote: > Hi Drew, > > Had a look at your patch. I think it's on the right track -- there's no > fundamental issue with it as far as I can tell. There's a few > implementation issues though. > > 1) In opus_multi_stream_decode_float(), you changed the pcm argument > from float* to opus_val16*. That's a mistake and will fail for > fixed-point. This should have shown up as an error on a fixed-point > build. Make sure you test that. > > 2) In opus_projection_decode(), you also changed the pcm argument to an &gt...

...te: > > > > Hi Drew, > > > > Had a look at your patch. I think it's on the right track -- there's > no > > fundamental issue with it as far as I can tell. There's a few > > implementation issues though. > > > > 1) In opus_multi_stream_decode_float(), you changed the pcm argument > > from float* to opus_val16*. That's a mistake and will fail for > > fixed-point. This should have shown up as an error on a fixed-point > > build. Make sure you test that. > > > > 2) In opus_projection_decode(), yo...

...t; > Had a look at your patch. I think it's on the right track -- > > there's no > > > fundamental issue with it as far as I can tell. There's a few > > > implementation issues though. > > > > > > 1) In opus_multi_stream_decode_float(), you changed the pcm > > argument > > > from float* to opus_val16*. That's a mistake and will fail for > > > fixed-point. This should have shown up as an error on a > > fixed-point > > > build. Make sure you test that. &gt...

...e right > track -- > > > there's no > > > > fundamental issue with it as far as I can tell. There's > > a few > > > > implementation issues though. > > > > > > > > 1) In opus_multi_stream_decode_float(), you changed the > pcm > > > argument > > > > from float* to opus_val16*. That's a mistake and will > > fail for > > > > fixed-point. This should have shown up as an error on a > > > fixed-point &gt...

Hi Drew, Had a look at your patch. I think it's on the right track -- there's no fundamental issue with it as far as I can tell. There's a few implementation issues though. 1) In opus_multi_stream_decode_float(), you changed the pcm argument from float* to opus_val16*. That's a mistake and will fail for fixed-point. This should have shown up as an error on a fixed-point build. Make sure you test that. 2) In opus_projection_decode(), you also changed the pcm argument to an opus_val16*, which again wi...

...t;mailto:jmvalin at jmvalin.ca>> wrote: > > Hi Drew, > > Had a look at your patch. I think it's on the right track -- there's no > fundamental issue with it as far as I can tell. There's a few > implementation issues though. > > 1) In opus_multi_stream_decode_float(), you changed the pcm argument > from float* to opus_val16*. That's a mistake and will fail for > fixed-point. This should have shown up as an error on a fixed-point > build. Make sure you test that. > > 2) In opus_projection_decode(), you also changed the pcm a...

...> > > > > fundamental issue with it as far as I can tell. > > There's > > > a few > > > > > implementation issues though. > > > > > > > > > > 1) In opus_multi_stream_decode_float(), you > > changed the pcm > > > > argument > > > > > from float* to opus_val16*. That's a mistake and > will > > > fail for > > > > > fixed-point. This should have shown up as an...

...> > > > > fundamental issue with it as far as I can tell. > > There's > > > a few > > > > > implementation issues though. > > > > > > > > > > 1) In opus_multi_stream_decode_float(), you > > changed the pcm > > > > argument > > > > > from float* to opus_val16*. That's a mistake and > will > > > fail for > > > > > fixed-point. This should have shown up as an...

...Hi Drew, > > > >     Had a look at your patch. I think it's on the right track -- > there's no > >     fundamental issue with it as far as I can tell. There's a few > >     implementation issues though. > > > >     1) In opus_multi_stream_decode_float(), you changed the pcm > argument > >     from float* to opus_val16*. That's a mistake and will fail for > >     fixed-point. This should have shown up as an error on a > fixed-point > >     build. Make sure you test that. > > > > ...

...your patch. I think it's on the right track -- > >     there's no > >     >     fundamental issue with it as far as I can tell. There's > a few > >     >     implementation issues though. > >     > > >     >     1) In opus_multi_stream_decode_float(), you changed the pcm > >     argument > >     >     from float* to opus_val16*. That's a mistake and will > fail for > >     >     fixed-point. This should have shown up as an error on a > >     fixed-point > >     >     build....

...t;     >     there's no > >     >     >     fundamental issue with it as far as I can tell. > There's > >     a few > >     >     >     implementation issues though. > >     >     > > >     >     >     1) In opus_multi_stream_decode_float(), you > changed the pcm > >     >     argument > >     >     >     from float* to opus_val16*. That's a mistake and will > >     fail for > >     >     >     fixed-point. This should have shown up as an error > on a >...

...issue with it as far as I > can tell. > >     There's > >     >     a few > >     >     >     >     implementation issues though. > >     >     >     > > >     >     >     >     1) In opus_multi_stream_decode_float(), you > >     changed the pcm > >     >     >     argument > >     >     >     >     from float* to opus_val16*. That's a > mistake and will > >     >     fail for > >     >     >     > ...

...> > fundamental issue with it as far as I can tell. >> > There's >> > > a few >> > > > > implementation issues though. >> > > > > >> > > > > 1) In opus_multi_stream_decode_float(), you >> > changed the pcm >> > > > argument >> > > > > from float* to opus_val16*. That's a mistake and >> will >> > > fail for >> > > > > fixed-point. This sh...

...   >     >     fundamental issue with it as far as I can tell. > >     There's > >     >     a few > >     >     >     >     implementation issues though. > >     >     >     > > >     >     >     >     1) In opus_multi_stream_decode_float(), you > >     changed the pcm > >     >     >     argument > >     >     >     >     from float* to opus_val16*. That's a mistake > and will > >     >     fail for > >     >     >     >     fixed-point. This sh...

...; > can tell. > > > There's > > > > a few > > > > > > implementation issues though. > > > > > > > > > > > > 1) In opus_multi_stream_decode_float(), > you > > > changed the pcm > > > > > argument > > > > > > from float* to opus_val16*. That's a > > mistake and will > > > > fail for > >...

...>         >     There's > >         >     >     a few > >         >     >     >     >     implementation issues though. > >         >     >     >     > > >         >     >     >     >     1) In > opus_multi_stream_decode_float(), you > >         >     changed the pcm > >         >     >     >     argument > >         >     >     >     >     from float* to opus_val16*. That's a > >         mistake and will > >         >     >     fail for...

...t; There's >> > > > a few >> > > > > > implementation issues though. >> > > > > > >> > > > > > 1) In >> opus_multi_stream_decode_float(), you >> > > changed the pcm >> > > > > argument >> > > > > > from float* to opus_val16*. That's a >> > mistake and will >> > >...

... >     a few > >>>     >         >     >     >     >     implementation issues though. > >>>     >         >     >     >     > > >>>     >         >     >     >     >     1) In > >>>     opus_multi_stream_decode_float(), you > >>>     >         >     changed the pcm > >>>     >         >     >     >     argument > >>>     >         >     >     >     >     from float* to > opus_val16*. That's a > >>>     &g...