search for: opus_fft

...00..5bb7b5f Please put these tables (and the ones in arm_celt_ne10_mdct_map) in arm_celt_map.c... the goal was to have them all in the same place, so that if we changed the architectures supported or something, we did not have to hunt all over the codebase to update them all. > +int (*const OPUS_FFT_ALLOC_ARCH[OPUS_ARCHMASK+1])(kiss_fft_state *st) = { Please follow the naming convention used in arm_celt_map, e.g., <all_caps_function_name>_IMPL instead of _ARCH (on this and all the other tables). > +void (*const OPUS_FFT[OPUS_ARCHMASK+1])(const kiss_fft_state *cfg, > +...

..._unit_dft.c | 2 +- celt/tests/test_unit_mdct.c | 2 +- 13 files changed, 214 insertions(+), 20 deletions(-) diff --git a/celt/arm/arm_celt_map.c b/celt/arm/arm_celt_map.c index 3b49f90..f132fe1 100644 --- a/celt/arm/arm_celt_map.c +++ b/celt/arm/arm_celt_map.c @@ -79,6 +79,15 @@ void (*const OPUS_FFT[OPUS_ARCHMASK+1])(const kiss_fft_state *cfg, opus_fft_float_neon /* Neon with NE10 */ }; +void (*const OPUS_IFFT[OPUS_ARCHMASK+1])(const kiss_fft_state *cfg, + const kiss_fft_cpx *fin, + kiss_fft_cpx *f...

..._unit_dft.c | 2 +- celt/tests/test_unit_mdct.c | 2 +- 13 files changed, 214 insertions(+), 20 deletions(-) diff --git a/celt/arm/arm_celt_map.c b/celt/arm/arm_celt_map.c index 3b49f90..f132fe1 100644 --- a/celt/arm/arm_celt_map.c +++ b/celt/arm/arm_celt_map.c @@ -79,6 +79,15 @@ void (*const OPUS_FFT[OPUS_ARCHMASK+1])(const kiss_fft_state *cfg, opus_fft_float_neon /* Neon with NE10 */ }; +void (*const OPUS_IFFT[OPUS_ARCHMASK+1])(const kiss_fft_state *cfg, + const kiss_fft_cpx *fin, + kiss_fft_cpx *f...

Hello All, I extended the libNE10 optimizations for float towards mdct_backwards/opus_ifft. I am able to get about 14.26% improvement for Decode use case now on my Beaglebone Black. Please see [1] for measurements. Questions 1. Since this patch needs to go in after Encode [2] patch) should I submit this as patch series? 2. Since Jonathan Lennox posted intrinsics cleanup [3] patch, should

Hello opus-dev, I've been cooking up this patchset to integrate NE10 library into opus. Current patchset focuses on encode use case mainly effecting performance of clt_mdct_forward() and opus_fft() (for float only) Glad to report the following on Encode use case: (Measured on my Beaglebone Black Cortex-A8 board) - Performance improvement for encode use case ~= 12.34% (Based on time -p data) - Performance improvement in opus_fft() ~= 350% - 400% (Based on perf data) Please see the...

...omething like typedef ne10_fft_cpx_float32 ne10_fft_cpx_float32_t typedef ne10_fft_cpx_float32 ne10_fft_cpx_float32_t Then from opus side, I can instead use ne10_fft_cfg_float32 cfg = (ne10_fft_cfg_float32)st->priv; VARDECL(ne10_fft_cpx_float32, temp); VARDECL(ne10_fft_cpx_float32, tempin); 2. opus_fft_float_neon: Remove at least one additional buffer that is currently needed (on stack) - Currently, we have to use 2 additional buffers on stack. - One for scaling (ALLOC(tempin, st->nfft, ne10_fft_cpx_float32_t);) - Another as temp buffer (cfg->buffer) - Is there any reason the scaling cannot...

Optimize opus encode (float only) usecase using ARM NE10 library. Mainly effects opus_fft and ctl_mdct_forward and related functions. This optimization can be used for ARM CPUs that have NEON VFP unit. This patch only enables optimizations for ARMv7. Official ARM NE10 library page available at http://projectne10.github.io/Ne10/ To enable this optimization, use --enable-intrinsics --w...

...arch64 patches pending ? mine are entirely for > > fixed-point though. Are yours all floating-point? > Yes, so far they are floating point. Can you post your fixed-point > optimizations? Also, are any of your patches using NE10 library? > > So far, what I submitted is to optimize opus_fft using NE10 (float > only). I also modified mdct_forward to take advantage of this > optimization. > > My next action plan: > - use opus_ifft to optimize mdct_backwards (float via Ne10) > - Re-work/add opus_fft and opus_ifft for fixed (again via Ne10) > - Enable for Aarch64 and...

...nings coming out of Ne10 library? You can find my working Ne10 repo at [1] You can find my working opus repo at [2] Commands I used to build opus: Download code $ git clone git://git.linaro.org/people/viswanath.puttagunta/opus.git $ cd opus $ git checkout -b local_rfcv2 remotes/origin/rfcv2_final_opus_fft_ne10 Compile code $ ./autogen.sh $ mkdir ../build $ cd ../build $ export PATH=$PATH:<path_to_arm-linux-gnueabihf_bin_dir> $ ../opus/configure --host=arm-linux-gnueabihf --enable-intrinsics --with-NE10-libraries=<path_to_Ne10_libraries> --with-NE10-includes=<path_to_Ne10_includes>...

Optimize opus encode (float only) usecase using ARM NE10 library. Mainly effects opus_fft and ctl_mdct_forward and related functions. This optimization can be used for ARM CPUs that have NEON VFP unit. This patch only enables optimizations for ARMv7. Official ARM NE10 library page available at http://projectne10.github.io/Ne10/ To enable this optimization, use --enable-intrinsics --w...

Optimize opus encode (float only) usecase using ARM NE10 library. Mainly effects opus_fft and ctl_mdct_forward and related functions. This optimization can be used for ARM CPUs that have NEON VFP unit. This patch only enables optimizations for ARMv7. Official ARM NE10 library page available at http://projectne10.github.io/Ne10/ To enable this optimization, use --enable-intrinsics --w...

Optimize opus encode (float only) usecase using ARM NE10 library. Mainly effects opus_fft and ctl_mdct_forward and related functions. This optimization can be used for ARM CPUs that have NEON VFP unit. This patch only enables optimizations for ARMv7. Official ARM NE10 library page available at http://projectne10.github.io/Ne10/ To enable this optimization, use --enable-intrinsics --w...

Changes from RFC PATCH v3 - Just rebased on tip - For all else, please see notes from RFC PATCH v3 at http://lists.xiph.org/pipermail/opus/2015-March/002902.html - latest wip opus tree/branch https://git.linaro.org/people/viswanath.puttagunta/Ne10.git branch: rfcv4_final_fft_ne10 Viswanath Puttagunta (1): armv7(float): Optimize encode usecase using NE10 library Makefile.am

...7 targets performance will not be improved. - For my performance testing, see my wip Ne10 branch below that applies -funsafe-math-optimizations - For references below are my wip trees for this RFCv3 patch https://git.linaro.org/people/viswanath.puttagunta/opus.git Branch: rfcv3_final_opus_fft_ne10 https://git.linaro.org/people/viswanath.puttagunta/Ne10.git rfcv3_final_ne10_fft Viswanath Puttagunta (1): armv7(float): Optimize encode usecase using NE10 library Makefile.am | 34 +-- celt/arm/arm_celt_map.c | 47 +++- celt/arm/celt_ne10_f...

On Mar 3, 2015, at 11:08 PM, Viswanath Puttagunta <viswanath.puttagunta at linaro.org<mailto:viswanath.puttagunta at linaro.org>> wrote: On 3 March 2015 at 21:59, Jonathan Lennox <jonathan at vidyo.com<mailto:jonathan at vidyo.com>> wrote: Viswenath, My patch should be against the tip, but it?s the very recent tip, including some changes this past Friday (27 Feb). I

...also have a number of aarch64 patches pending ? mine are entirely for > fixed-point though. Are yours all floating-point? Yes, so far they are floating point. Can you post your fixed-point optimizations? Also, are any of your patches using NE10 library? So far, what I submitted is to optimize opus_fft using NE10 (float only). I also modified mdct_forward to take advantage of this optimization. My next action plan: - use opus_ifft to optimize mdct_backwards (float via Ne10) - Re-work/add opus_fft and opus_ifft for fixed (again via Ne10) - Enable for Aarch64 and test (I'm hoping your patch al...

Hi All, Since I continue to base my work on top of Jonathan's patch, and my previous Ne10 fft/ifft/mdct_forward/backward patches, I thought it would be better to just post all new patches as a patch series. Please let me know if anyone disagrees with this approach. You can see wip branch of all latest patches at https://git.linaro.org/people/viswanath.puttagunta/opus.git Branch:

Hi Timothy, As I mentioned earlier [1], I now fixed compile issues with fixed point and resubmitting the patch. I also have new patch that does intrinsics optimizations for celt_pitch_xcorr targetting aarch64. You can find my latest work-in-progress branch at [2] For reference, you can use the Ne10 pre-built libraries at [3] Note that I am working with Phil at ARM to get my patch at [4]

Hi All, As per Timothy's suggestion, disabling mdct_forward for fixed point. Only effects armv7,armv8: Extend fixed fft NE10 optimizations to mdct Rest of patches are same as in [1] For reference, latest wip code for opus is at [2] Still working with NE10 team at ARM to get corner cases of mdct_forward. Will update with another patch when issue in NE10 gets fixed. Regards, Vish [1]:

Hi All, Changes from RFC v2 [1] armv7,armv8: Extend fixed fft NE10 optimizations to mdct - Overflow issue fixed by Phil at ARM. Ne10 wip at [2]. Should be upstream soon. - So, re-enabled using fixed fft for mdct_forward which was disabled in RFCv2 armv7,armv8: Optimize fixed point fft using NE10 library - Thanks to Jonathan Lennox, fixed some build fixes on iOS and some copy-paste errors Rest