search for: opus_export

thanks for all your feedback. here's the revised patch: On Wed, Oct 11, 2017 at 2:20 PM Timothy B. Terriberry <tterribe at xiph.org> wrote: > Jean-Marc Valin wrote: > > I think you'll want something like: > > (opus_int16)((unsigned)demixing_matrix[2*i+1] << 8) > > (though you might want to check it too) > > FWIW, we use the construct > int s =

...in private.h adds a > subframe_mem[] that's not in opus_multistream_encoder.c. I assume it's > due to a merge problem (that field was removed some time ago), but can > you confirm/fix the issue? > Done. Yes, this is a merge conflict. > > 2) I noticed your patch adds many OPUS_EXPORT declarations. OPUS_EXPORT > is only meant for functions exposed to the API (and in the include/ > directory), but I see several of these in mapping_matrix.h, which I > think is incorrect. > > Done. > 3) opus_projection_ambisonics_encoder_init() (which should be > OPUS_EXPORT)...

...ltistream_encoder.c. I assume > it's > > due to a merge problem (that field was removed some time ago), but > can > > you confirm/fix the issue? > > > > Done. Yes, this is a merge conflict. > > > > > > 2) I noticed your patch adds many OPUS_EXPORT declarations. > OPUS_EXPORT > > is only meant for functions exposed to the API (and in the include/ > > directory), but I see several of these in mapping_matrix.h, which I > > think is incorrect. > > > > Done. > > > > > > 3) opus_pr...

...e more in-depth comments: 1) I note that your OpusMSEncoder struct in private.h adds a subframe_mem[] that's not in opus_multistream_encoder.c. I assume it's due to a merge problem (that field was removed some time ago), but can you confirm/fix the issue? 2) I noticed your patch adds many OPUS_EXPORT declarations. OPUS_EXPORT is only meant for functions exposed to the API (and in the include/ directory), but I see several of these in mapping_matrix.h, which I think is incorrect. 3) opus_projection_ambisonics_encoder_init() (which should be OPUS_EXPORT) is missing from opus_projection.h 4) I b...

...) in that case. --- include/opus_defines.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/opus_defines.h b/include/opus_defines.h index 10ff838..11b172d 100644 --- a/include/opus_defines.h +++ b/include/opus_defines.h @@ -65,7 +65,7 @@ extern "C" { #ifndef OPUS_EXPORT # if defined(WIN32) -# ifdef OPUS_BUILD +# if defined(OPUS_BUILD) && defined(DLL_EXPORT) # define OPUS_EXPORT __declspec(dllexport) # else # define OPUS_EXPORT -- 2.1.4

...subframe_mem[] that's not in opus_multistream_encoder.c. I assume it's > due to a merge problem (that field was removed some time ago), but can > you confirm/fix the issue? > > Done. Yes, this is a merge conflict.  > > > 2) I noticed your patch adds many OPUS_EXPORT declarations. OPUS_EXPORT > is only meant for functions exposed to the API (and in the include/ > directory), but I see several of these in mapping_matrix.h, which I > think is incorrect. > > Done. >   > > 3) opus_projection_ambisonics_encoder_init() (which...

...> >     but can > >     >     you confirm/fix the issue? > >     > > >     > Done. Yes, this is a merge conflict.  > >     > > >     > > >     >     2) I noticed your patch adds many OPUS_EXPORT > declarations. > >     OPUS_EXPORT > >     >     is only meant for functions exposed to the API (and > in the > >     include/ > >     >     directory), but I see several of these in > mapping_matrix.h,...

...> > > > > > > > > Done. Yes, this is a merge conflict. > > > > > > > > > > > > > > > 2) I noticed your patch adds many > OPUS_EXPORT > > > declarations. > > > > OPUS_EXPORT > > > > > is only meant for functions exposed to the > > API (and > > > in the > > > > inclu...

...confirm/fix the issue? > >         >     > > >         >     > Done. Yes, this is a merge conflict.  > >         >     > > >         >     > > >         >     >     2) I noticed your patch adds many OPUS_EXPORT > >         declarations. > >         >     OPUS_EXPORT > >         >     >     is only meant for functions exposed to the > API (and > >         in the > >         >     include/ > >         ...

...> > >> > > > > Done. Yes, this is a merge conflict. >> > > > > >> > > > > >> > > > > 2) I noticed your patch adds many >> OPUS_EXPORT >> > > declarations. >> > > > OPUS_EXPORT >> > > > > is only meant for functions exposed to the >> > API (and >> > > in the >> > &gt...

...h #pragma visibility push(hidden), which is stronger than the command line flag, however, only libopus functions that are actually used in firefox code are affected, and others are still exported. It would be great if Opus provided some macro (like OPUS_STATIC_BUILD) that, when set, would make OPUS_EXPORT empty even when OPUS_BUILD is set. Can it be provided in future versions? -- Alexey Izbyshev

...gt; >         >         >     > Done. Yes, this is a merge conflict.  > >         >         >     > > >         >         >     > > >         >         >     >     2) I noticed your patch adds > many OPUS_EXPORT > >         >         declarations. > >         >         >     OPUS_EXPORT > >         >         >     >     is only meant for functions > exposed to the > >         API (and > >         >       ...

Hi all! What is the right way to report bugs in libopus? I couldn't find any publicly available bugtracker. Anyway, the problem I need to report is that some source files in libopus are missing copyright headers. This breaks license check script that we use in chromium to validate licenses for third-party dependencies. Specifically the following files don't have copyright header: