search for: optimize_http

...t; diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py > index a2d09458..b9b9e967 100644 > --- a/v2v/rhv-upload-plugin.py > +++ b/v2v/rhv-upload-plugin.py > @@ -93,7 +93,7 @@ def open(readonly): > options = get_options(http, destination_url) > http = optimize_http(http, host, options) > except: > - transfer_service.cancel() > + cancel_transfer(connection, transfer) > raise > > debug("imageio features: flush=%(can_flush)r trim=%(can_trim)r " > @@ -531,6 +531,16 @@ def create_transfer(connection,...

...rhv-upload: Don't keep transfer_service in handle rhv-upload: Get host before creating disk rhv-upload: Extract create_transfer() function rhv-upload: Show transfer id in error message rhv-upload: Extract imageio helpers rhv-upload: Extract get_options() helper rhv-upload: Extract optimize_http() helper rhv-upload: Clean up username and password v2v/rhv-upload-plugin.py | 325 ++++++++++++++++++++++----------------- 1 file changed, 184 insertions(+), 141 deletions(-) -- 2.21.0

...e > > rhv-upload: Get host before creating disk > > rhv-upload: Extract create_transfer() function > > rhv-upload: Show transfer id in error message > > rhv-upload: Extract imageio helpers > > rhv-upload: Extract get_options() helper > > rhv-upload: Extract optimize_http() helper > > rhv-upload: Clean up username and password > > > > I'm not sure which one of these is causing it, it sounds like the first one, but > basically the cleanup path is probably not checked well. I'm facing a > completely different issue currently, but when...

...disk_id in handle > rhv-upload: Don't keep transfer_service in handle > rhv-upload: Get host before creating disk > rhv-upload: Extract create_transfer() function > rhv-upload: Extract imageio helpers > rhv-upload: Extract get_options() helper > rhv-upload: Extract optimize_http() helper > rhv-upload: Clean up username and password > > v2v/rhv-upload-plugin.py | 550 +++++++++++++++++++++------------------ > 1 file changed, 295 insertions(+), 255 deletions(-) > > -- > 2.21.0 >

...11 insertions(+), 1 deletion(-) diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index a2d09458..b9b9e967 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -93,7 +93,7 @@ def open(readonly): options = get_options(http, destination_url) http = optimize_http(http, host, options) except: - transfer_service.cancel() + cancel_transfer(connection, transfer) raise debug("imageio features: flush=%(can_flush)r trim=%(can_trim)r " @@ -531,6 +531,16 @@ def create_transfer(connection, disk, host): return transf...

...keep transfer_service in handle > rhv-upload: Get host before creating disk > rhv-upload: Extract create_transfer() function > rhv-upload: Show transfer id in error message > rhv-upload: Extract imageio helpers > rhv-upload: Extract get_options() helper > rhv-upload: Extract optimize_http() helper > rhv-upload: Clean up username and password > I'm not sure which one of these is causing it, it sounds like the first one, but basically the cleanup path is probably not checked well. I'm facing a completely different issue currently, but when updated to your version (in...

...ting disk > >> > rhv-upload: Extract create_transfer() function > >> > rhv-upload: Show transfer id in error message > >> > rhv-upload: Extract imageio helpers > >> > rhv-upload: Extract get_options() helper > >> > rhv-upload: Extract optimize_http() helper > >> > rhv-upload: Clean up username and password > >> > > >> > >> I'm not sure which one of these is causing it, it sounds like the first > one, but > >> basically the cleanup path is probably not checked well. I'm facing a &...

...oad: Get host before creating disk >> > rhv-upload: Extract create_transfer() function >> > rhv-upload: Show transfer id in error message >> > rhv-upload: Extract imageio helpers >> > rhv-upload: Extract get_options() helper >> > rhv-upload: Extract optimize_http() helper >> > rhv-upload: Clean up username and password >> > >> >> I'm not sure which one of these is causing it, it sounds like the first one, but >> basically the cleanup path is probably not checked well. I'm facing a >> completely different i...

...gt;> > rhv-upload: Extract create_transfer() function >> >> > rhv-upload: Show transfer id in error message >> >> > rhv-upload: Extract imageio helpers >> >> > rhv-upload: Extract get_options() helper >> >> > rhv-upload: Extract optimize_http() helper >> >> > rhv-upload: Clean up username and password >> >> > >> >> >> >> I'm not sure which one of these is causing it, it sounds like the first >> one, but >> >> basically the cleanup path is probably not checked w...

Fix NameError introduced by inocomplete change to extract create_transfer() by extracting cancel_transfer() function. Finally extract finallize_transfer() function, dealing with the poorly documented and over complicated oVirt SDK. Tested with: libguestfs-1.40.2-4.fc30.x86_64 nbdkit-1.12.8-1.fc30.x86_64 Tested flows: - Successful import - Error in close() - by injecting long sleep in vdsm

...on timeout rhv-upload: Keep disk_id in handle rhv-upload: Don't keep transfer_service in handle rhv-upload: Get host before creating disk rhv-upload: Extract create_transfer() function rhv-upload: Extract imageio helpers rhv-upload: Extract get_options() helper rhv-upload: Extract optimize_http() helper rhv-upload: Clean up username and password v2v/rhv-upload-plugin.py | 550 +++++++++++++++++++++------------------ 1 file changed, 295 insertions(+), 255 deletions(-) -- 2.21.0

...timeout = 5 * 60 @@ -114,67 +119,61 @@ def open(readonly): transfer = create_transfer(connection, disk, host) try: - destination_url = parse_transfer_url(transfer) - http = create_http(destination_url) - options = get_options(http, destination_url) - http = optimize_http(http, host, options) + # ImageioClient uses transfer_url if possible, and proxy_url if not. + # TODO: How to handle params['rhv_direct']? + client = ImageioClient( + transfer.transfer_url, + cafile=params['rhv_cafile'], + secure=...

Fixes the majority of the pycodestyle issues in the Python scripts, and fix the existing test-v2v-python-syntax.sh to use pycodestyle to actually perform style checks. Pino Toscano (6): PEP 8: adapt whitespaces in lines PEP 8: move imports at the top PEP 8: adapt empty lines tests: find all the Python scripts for syntax checks -o rhv-upload: remove unused Python imports Revamp check