search for: optgroups_retir

On Tue, May 20, 2014 at 07:54:45PM +0200, Pino Toscano wrote: > Support the possibility to have optional groups always enabled (e.g. > because they were present in the past, and they need to be kept for > users). > Add and use few helper optgroups-related functions to deal also with > them. What do you think about the attached addition to this patch? (It is meant to be squashed

...ml +++ b/generator/daemon.ml @@ -732,19 +732,15 @@ and generate_daemon_optgroups_c () = pr " return 1;\n"; pr "}\n"; pr "\n"; - - List.iter ( - fun group -> - pr "#define optgroup_%s_available dummy_available\n" group; - ) optgroups_retired; - - pr "\n"; ); pr "struct optgroup optgroups[] = {\n"; List.iter ( fun group -> - pr " { \"%s\", optgroup_%s_available },\n" group group + if List.mem group optgroups_retired then + pr " { \"%s\", du...

On Tuesday 20 May 2014 15:56:16 Richard W.M. Jones wrote: > On Tue, May 20, 2014 at 03:33:31PM +0200, Pino Toscano wrote: > > Resolve the given path within the chroot, so scrub can be invoked > > outside the chroot on an already-resolved path. > > Given that realpath is used, its availability is checked manually, > > since scrub-file already depends on the

...str_mkswap, "--help", NULL)); > - > - av = strstr (err, "-U") != NULL; > - return av; > + return 1; > } If the "linuxfsuuid" is now always available, then it could be retired: - remove its dependency in actions (there are 5) - adding it to the optgroups_retired list in generator/optgroups.ml > diff --git a/generator/ruby.ml b/generator/ruby.ml > index 87bb34a..cb187b0 100644 > --- a/generator/ruby.ml > +++ b/generator/ruby.ml > @@ -84,20 +84,6 @@ let rec generate_ruby_c () = > #define RSTRING_PTR(r) (RSTRING((r))->ptr) > #endi...

...t; group group ) optgroups_names_all; pr " { NULL, NULL }\n"; - pr "};\n" + pr "};\n"; + pr "\n"; + pr "/* Wrappers so these functions can be called from OCaml code. */\n"; + List.iter ( + fun group -> + if not (List.mem group optgroups_retired) then ( + pr "extern value guestfs_int_daemon_optgroup_%s_available (value);\n" + group; + pr "\n"; + pr "/* NB: This is a \"noalloc\" call. */\n"; + pr "value\n"; + pr "guestfs_int_daemon_optgroup...

We don't support RHEL 5 upstream (see the 'oldlinux' branch for a version that works with RHEL 5). Therefore remove a bunch of hacks that were only needed on RHEL 5. --- appliance/packagelist.in | 2 - common-rules.mk | 8 - daemon/parted.c | 455 +++++++++++----------------------------- daemon/swap.c | 18 +-

...for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + *) + +val optgroups : (string * Types.action list) list +val optgroups_retired : string list +val optgroups_names : string list +val optgroups_names_all : string list diff --git a/generator/perl.mli b/generator/perl.mli new file mode 100644 index 0000000..b6e6fdb --- /dev/null +++ b/generator/perl.mli @@ -0,0 +1,20 @@ +(* libguestfs + * Copyright (C) 2009-2016 Red Hat Inc....

Use interfaces files (*.mli files) instead of exporting all symbols randomly. Change the 'file is generated' warnings at the top of generated files so they accurately describe which source file generates each output file. Rich.

Previously posted as part of the mega utilities/inspection series here: https://www.redhat.com/archives/libguestfs/2017-June/msg00232.html What I've done is to extract just the parts related to rewriting daemon APIs in OCaml, rebase them on top of the current master, fix a few things, and recompile and test everything. Rich.

v2 was here: https://www.redhat.com/archives/libguestfs/2017-June/msg00008.html This series gets as far as a working (and faster) reimplementation of ‘guestfs_list_filesystems’. I also have another patch series on top of this one which reimplements the inspection APIs inside the daemon, but that needs a bit more work still, since inspection turns out to be a very large piece of code. Rich.

This is a combination of: https://www.redhat.com/archives/libguestfs/2017-June/msg00046.html [PATCH 00/12] Refactor utility functions. plus: https://www.redhat.com/archives/libguestfs/2017-June/msg00023.html [PATCH v3 00/19] Allow APIs to be implemented in OCaml. with the second patches rebased on top of the utility refactoring, and some other adjustments and extensions. This passes

v6 was posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html and this requires the utilities refactoring posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html Inspection is now complete[*], although not very well tested. I'm intending to compare the output of many guests using old & new virt-inspector to see if I can find any

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.

v7 was: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html https://www.redhat.com/archives/libguestfs/2017-June/msg00184.html I believe this addresses all comments received so far. Also it now passes a test where I compared about 100 disk images processed with old and new virt-inspector binaries. The output is identical in all cases except one which is caused by a bug in blkid