search for: optgroups_names

On Tue, May 20, 2014 at 07:54:45PM +0200, Pino Toscano wrote: > Support the possibility to have optional groups always enabled (e.g. > because they were present in the past, and they need to be kept for > users). > Add and use few helper optgroups-related functions to deal also with > them. What do you think about the attached addition to this patch? (It is meant to be squashed

On Tuesday 20 May 2014 15:56:16 Richard W.M. Jones wrote: > On Tue, May 20, 2014 at 03:33:31PM +0200, Pino Toscano wrote: > > Resolve the given path within the chroot, so scrub can be invoked > > outside the chroot on an already-resolved path. > > Given that realpath is used, its availability is checked manually, > > since scrub-file already depends on the

...have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + *) + +val optgroups : (string * Types.action list) list +val optgroups_retired : string list +val optgroups_names : string list +val optgroups_names_all : string list diff --git a/generator/perl.mli b/generator/perl.mli new file mode 100644 index 0000000..b6e6fdb --- /dev/null +++ b/generator/perl.mli @@ -0,0 +1,20 @@ +(* libguestfs + * Copyright (C) 2009-2016 Red Hat Inc. + * + * This program is free software...

v1 -> v2: - Fixed everything mentioned in patch review. - Libdir module is removed as a separate commit. Rich.

...pr "\n"; pr "#include \"daemon.h\"\n"; pr "#include \"optgroups.h\"\n"; pr "\n"; @@ -752,7 +1072,22 @@ let generate_daemon_optgroups_c () = pr " { \"%s\", optgroup_%s_available },\n" group group ) optgroups_names_all; pr " { NULL, NULL }\n"; - pr "};\n" + pr "};\n"; + pr "\n"; + pr "/* Wrappers so these functions can be called from OCaml code. */\n"; + List.iter ( + fun group -> + pr "extern value guestfs_int_daemon_optgroup_%s_avail...

Use interfaces files (*.mli files) instead of exporting all symbols randomly. Change the 'file is generated' warnings at the top of generated files so they accurately describe which source file generates each output file. Rich.

...erator/daemon.ml b/generator/daemon.ml index 5f726cafe..089ef509c 100644 --- a/generator/daemon.ml +++ b/generator/daemon.ml @@ -1152,6 +1152,14 @@ let generate_daemon_optgroups_ml () = pr " \"guestfs_int_daemon_optgroup_%s_available\" \"noalloc\"\n" group ) optgroups_names +let generate_daemon_optgroups_mli () = + generate_header OCamlStyle GPLv2plus; + + List.iter ( + fun group -> + pr "val %s_available : unit -> bool\n" group + ) optgroups_names + (* Generate structs-cleanups.c file. *) let generate_daemon_structs_cleanups_c () = g...

This works reliably for me ... Rich.

I think this fixes everything mentioned: - Added the Optgroups module as suggested. - Remove command temporary files. - Replace command ~flags with ?fold_stdout_on_stderr. - Nest _with_mounted function. - Rebase & retest. Rich.

v1 was posted here: https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html This series now depends on two small patches which I posted separately: https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html v1 -> v2: - Previously changes to generator/daemon.ml were made incrementally through the patch

Previously posted as part of the mega utilities/inspection series here: https://www.redhat.com/archives/libguestfs/2017-June/msg00232.html What I've done is to extract just the parts related to rewriting daemon APIs in OCaml, rebase them on top of the current master, fix a few things, and recompile and test everything. Rich.