search for: optargt

This is the first iteration of the GObject bindings. I have 'kicked the tyres' on these, meaning I have ensured that a bunch of basic manual tests work as expected. I'm in the process of adding more comprehensive tests. Here's an example simple javascript program which uses these bindings: === const Guestfs = imports.gi.Guestfs; print('Starting'); var g = new

https://bugzilla.redhat.com/show_bug.cgi?id=847880 https://bugzilla.redhat.com/show_bug.cgi?id=847881 This patch series adds various optional arguments to the tar-in and tar-out commands. Firstly (1/7) an optional "compress" flag is added to select compression. This makes the calls tgz-in/tgz-out/txz-in/txz-out deprecated, and expands the range of compression types available.

...let generate_gobject_optargs_source name optargs flags () = pr "G_DEFINE_TYPE(%s, guestfs_%s, G_TYPE_OBJECT);\n\n" camel_name name; pr "enum {\n"; - pr "PROP_GUESTFS_%s_PROP0" uc_name; + pr " PROP_GUESTFS_%s_PROP0" uc_name; List.iter ( fun optargt -> let uc_optname = String.uppercase (name_of_optargt optargt) in -- 1.7.10

This reverts commit 3f6ca541c7b24d4c86688a509582cb41a7e0078c. The original commit was reverted prematurely. --- generator/generator_actions.ml | 10 +++++----- generator/generator_checks.ml | 5 +++++ generator/generator_types.ml | 3 +++ 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/generator/generator_actions.ml b/generator/generator_actions.ml index

--- generator/generator_actions.ml | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/generator/generator_actions.ml b/generator/generator_actions.ml index 68a7bf6..fcf363f 100644 --- a/generator/generator_actions.ml +++ b/generator/generator_actions.ml @@ -4664,7 +4664,7 @@ This creates an ext2/3/4 filesystem on C<device> with an external journal on

...ix + 2 in - pr ",\n%s%s" indent (spaces namelen) + pr ",\n%s%s" indent (String.spaces namelen) ) ); comma := true @@ -230,7 +231,8 @@ and generate_actions_pod_entry ({ c_name = c_name; List.iter ( fun argt -> let n = name_of_optargt argt in - pr " GUESTFS_%s_%s, " (String.uppercase c_name) (String.uppercase n); + pr " GUESTFS_%s_%s, " (String.uppercase_ascii c_name) + (String.uppercase_ascii n); match argt with | OBool n -> pr "int %s,\n" n | O...

This map was originally included just for the java bindings, but is generally useful to any binding which uses camel case by requirement or convention. --- generator/generator_haskell.ml | 4 ++-- generator/generator_java.ml | 10 +++++----- generator/generator_main.ml | 2 +- generator/generator_structs.ml | 12 +++++------- generator/generator_structs.mli | 8 ++++---- 5

v1 -> v2: - Fixed everything mentioned in patch review. - Libdir module is removed as a separate commit. Rich.

Use interfaces files (*.mli files) instead of exporting all symbols randomly. Change the 'file is generated' warnings at the top of generated files so they accurately describe which source file generates each output file. Rich.

...imple file name. - *) | Filename - - (* The following two are DEPRECATED and must not be used in - * any new APIs. - *) - | Dev_or_Path (* Device or Pathname. *) - | Mountable_or_Path (* Mountable or Pathname. *) + | Dev_or_Path + | Mountable_or_Path and optargs = optargt list and optargt = - | OBool of string (* boolean *) - | OInt of string (* int (smallish ints, signed, <= 31 bits) *) - | OInt64 of string (* any 64 bit int *) - | OString of string (* const char *name, cannot be NULL *) - | OStringList of string (* char **strings, neither the list nor a...

This works reliably for me ... Rich.

Hi, this patch serie adds a new GUID type in the generator, which would do the same as String, but also validating (just in the C output) the passed GUID string. This allows to reject invalid GUIDs before passing them to low-level tools. Pino Toscano (4): utils: add a function to validate a GUID string generator: add a GUID parameter type generator: generate code for parameter validation

...e : unit -> unit +val generate_gobject_header : unit -> unit +val generate_gobject_makefile : unit -> unit +val generate_gobject_optargs_header : string -> string -> 'a -> Types.action -> unit -> unit +val generate_gobject_optargs_source : string -> string -> Types.optargt list -> Types.action -> unit -> unit +val generate_gobject_session_header : unit -> unit +val generate_gobject_session_source : unit -> unit +val generate_gobject_struct_header : string -> string -> (string * Types.field) list -> unit -> unit +val generate_gobject_struct_...

...tor/types.ml @@ -190,6 +190,10 @@ and argt = * guestfs_int_validate_guid. *) | GUID of string + (* List of file names, where the list cannot be NULL, and each + * filename cannot be NULL, empty, or an absolute path. + *) + | RelativePathnameList of string and optargs = optargt list diff --git a/generator/utils.ml b/generator/utils.ml index 1b00ce5..5b97b2b 100644 --- a/generator/utils.ml +++ b/generator/utils.ml @@ -254,7 +254,7 @@ let name_of_argt = function | Mountable_or_Path n | String n | OptString n | StringList n | DeviceList n | Bool n | Int n | Int64 n...

..._guid. *) | GUID of string + (* List of file names only, where the list cannot be NULL, + * and each element cannot be NULL, empty, or anything different than + * a simple file name (i.e. neither absolute nor relative paths). + *) + | FilenameList of string and optargs = optargt list diff --git a/generator/utils.ml b/generator/utils.ml index 1b00ce5..7d47430 100644 --- a/generator/utils.ml +++ b/generator/utils.ml @@ -254,7 +254,7 @@ let name_of_argt = function | Mountable_or_Path n | String n | OptString n | StringList n | DeviceList n | Bool n | Int n | Int64 n...

These are my thoughts on adding a test harness to run tests instead of using automake. The aim of this exercise is to allow us to run the full test suite on an installed copy of libguestfs. Another aim is to allow us to work around all the limitations and problems of automake. The first patch makes an observation that since the ./run script sets up $PATH to contain all the directories

...ent than a simple file name. + *) + | Filename + + (* The following two are DEPRECATED and must not be used in + * any new APIs. *) - | FilenameList of string + | Dev_or_Path (* Device or Pathname. *) + | Mountable_or_Path (* Mountable or Pathname. *) and optargs = optargt list diff --git a/generator/utils.ml b/generator/utils.ml index 7034065c9..a745a02b7 100644 --- a/generator/utils.ml +++ b/generator/utils.ml @@ -139,11 +139,10 @@ let files_equal n1 n2 = | i -> failwithf "%s: failed with error code %d" cmd i let name_of_argt = function - | Pa...

Very large but mechanical change to the generator. Rich.