search for: ops_create_fail

...Parent device operation structure to be registered. > + * @id: class id. > * > * Add device to list of registered parent devices. > * Returns a negative value on error, otherwise 0. > @@ -324,6 +331,9 @@ int mdev_device_create(struct kobject *kobj, > if (ret) > goto ops_create_fail; > > + if (!mdev->class_id) This is a sanity test failure of the parent driver on a privileged path, I think it's fair to print a warning when this occurs rather than only return an errno to the user. In fact, ret is not set to an error value here, so it looks like this fails to cr...

...presenting parent device. * @ops: Parent device operation structure to be registered. + * @id: class id. * * Add device to list of registered parent devices. * Returns a negative value on error, otherwise 0. @@ -324,6 +331,9 @@ int mdev_device_create(struct kobject *kobj, if (ret) goto ops_create_fail; + if (!mdev->class_id) + goto class_id_fail; + ret = device_add(&mdev->dev); if (ret) goto add_fail; @@ -340,6 +350,7 @@ int mdev_device_create(struct kobject *kobj, sysfs_fail: device_del(&mdev->dev); +class_id_fail: add_fail: parent->ops->remove(mdev); o...

...e to be registered. >> + * @id: class id. >> * >> * Add device to list of registered parent devices. >> * Returns a negative value on error, otherwise 0. >> @@ -324,6 +331,9 @@ int mdev_device_create(struct kobject *kobj, >> if (ret) >> goto ops_create_fail; >> >> + if (!mdev->class_id) >> + goto class_id_fail; >> + >> ret = device_add(&mdev->dev); >> if (ret) >> goto add_fail; >> @@ -340,6 +350,7 @@ int mdev_device_create(struct kobject *kobj, >> >> sysfs_fail: >&gt...

...* @id: class id. > >> * > >> * Add device to list of registered parent devices. > >> * Returns a negative value on error, otherwise 0. > >> @@ -324,6 +335,13 @@ int mdev_device_create(struct kobject *kobj, > >> if (ret) > >> goto ops_create_fail; > >> > >> + if (!mdev->class_id) { > >> + ret = -EINVAL; > >> + WARN(1, "class id must be specified for device %s\n", > >> + dev_name(dev)); > > Nit, dev_warn(dev, "mdev vendor driver failed to specify device class\n...

...* @id: class id. > >> * > >> * Add device to list of registered parent devices. > >> * Returns a negative value on error, otherwise 0. > >> @@ -324,6 +335,13 @@ int mdev_device_create(struct kobject *kobj, > >> if (ret) > >> goto ops_create_fail; > >> > >> + if (!mdev->class_id) { > >> + ret = -EINVAL; > >> + WARN(1, "class id must be specified for device %s\n", > >> + dev_name(dev)); > > Nit, dev_warn(dev, "mdev vendor driver failed to specify device class\n...

...Parent device operation structure to be registered. > + * @id: class id. > * > * Add device to list of registered parent devices. > * Returns a negative value on error, otherwise 0. > @@ -324,6 +335,13 @@ int mdev_device_create(struct kobject *kobj, > if (ret) > goto ops_create_fail; > > + if (!mdev->class_id) { > + ret = -EINVAL; > + WARN(1, "class id must be specified for device %s\n", > + dev_name(dev)); Nit, dev_warn(dev, "mdev vendor driver failed to specify device class\n"); > + goto add_fail; > + } > + > r...

...Parent device operation structure to be registered. > + * @id: class id. > * > * Add device to list of registered parent devices. > * Returns a negative value on error, otherwise 0. > @@ -324,6 +335,13 @@ int mdev_device_create(struct kobject *kobj, > if (ret) > goto ops_create_fail; > > + if (!mdev->class_id) { > + ret = -EINVAL; > + WARN(1, "class id must be specified for device %s\n", > + dev_name(dev)); Nit, dev_warn(dev, "mdev vendor driver failed to specify device class\n"); > + goto add_fail; > + } > + > r...

...;> * > > >> * Add device to list of registered parent devices. > > >> * Returns a negative value on error, otherwise 0. > > >> @@ -324,6 +335,13 @@ int mdev_device_create(struct kobject *kobj, > > >> if (ret) > > >> goto ops_create_fail; > > >> > > >> + if (!mdev->class_id) { > > >> + ret = -EINVAL; > > >> + WARN(1, "class id must be specified for device %s\n", > > >> + dev_name(dev)); > > > Nit, dev_warn(dev, "mdev vendor driver...

...ss(struct mdev_device *mdev, u16 id) +{ + WARN_ON(mdev->class_id); + mdev->class_id = id; +} +EXPORT_SYMBOL(mdev_set_class); + struct device *mdev_dev(struct mdev_device *mdev) { return &mdev->dev; @@ -324,6 +335,12 @@ int mdev_device_create(struct kobject *kobj, if (ret) goto ops_create_fail; + if (!mdev->class_id) { + ret = -EINVAL; + dev_warn(dev, "mdev vendor driver failed to specify device class\n"); + goto add_fail; + } + ret = device_add(&mdev->dev); if (ret) goto add_fail; diff --git a/drivers/vfio/mdev/mdev_driver.c b/drivers/vfio/mdev/mdev_drive...

...ss(struct mdev_device *mdev, u16 id) +{ + WARN_ON(mdev->class_id); + mdev->class_id = id; +} +EXPORT_SYMBOL(mdev_set_class); + struct device *mdev_dev(struct mdev_device *mdev) { return &mdev->dev; @@ -324,6 +334,12 @@ int mdev_device_create(struct kobject *kobj, if (ret) goto ops_create_fail; + if (!mdev->class_id) { + ret = -EINVAL; + dev_warn(dev, "mdev vendor driver failed to specify device class\n"); + goto add_fail; + } + ret = device_add(&mdev->dev); if (ret) goto add_fail; diff --git a/drivers/vfio/mdev/mdev_driver.c b/drivers/vfio/mdev/mdev_drive...

...resenting parent device. * @ops: Parent device operation structure to be registered. + * @id: class id. * * Add device to list of registered parent devices. * Returns a negative value on error, otherwise 0. @@ -324,6 +335,13 @@ int mdev_device_create(struct kobject *kobj, if (ret) goto ops_create_fail; + if (!mdev->class_id) { + ret = -EINVAL; + WARN(1, "class id must be specified for device %s\n", + dev_name(dev)); + goto add_fail; + } + ret = device_add(&mdev->dev); if (ret) goto add_fail; diff --git a/drivers/vfio/mdev/mdev_driver.c b/drivers/vfio/mdev/md...

...to be registered. >> + * @id: class id. >> * >> * Add device to list of registered parent devices. >> * Returns a negative value on error, otherwise 0. >> @@ -324,6 +335,13 @@ int mdev_device_create(struct kobject *kobj, >> if (ret) >> goto ops_create_fail; >> >> + if (!mdev->class_id) { >> + ret = -EINVAL; >> + WARN(1, "class id must be specified for device %s\n", >> + dev_name(dev)); > Nit, dev_warn(dev, "mdev vendor driver failed to specify device class\n"); Will fix. > >...

Hi all: There are hardware that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and register itself as a new kind of mdev driver. Then it provides a unified way for kernel virtio driver to

Hi all: There are hardware that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and register itself as a new kind of mdev driver. Then it provides a unified way for kernel virtio driver to

...mdev->class_id); > + mdev->class_id = id; > +} > +EXPORT_SYMBOL(mdev_set_class); > + > struct device *mdev_dev(struct mdev_device *mdev) > { > return &mdev->dev; > @@ -324,6 +334,12 @@ int mdev_device_create(struct kobject *kobj, > if (ret) > goto ops_create_fail; > > + if (!mdev->class_id) { > + ret = -EINVAL; > + dev_warn(dev, "mdev vendor driver failed to specify device class\n"); > + goto add_fail; > + } > + > ret = device_add(&mdev->dev); > if (ret) > goto add_fail; > diff --git a/drivers...

Hi all: There are hardwares that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and register itself as a new kind of mdev driver. Then it provides a unified way for kernel virtio driver

Hi all: There are hardwares that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and register itself as a new kind of mdev driver. Then it provides a unified way for kernel virtio driver

Hi all: There are hardwares that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and register itself as a new kind of mdev driver. Then it provides a unified way for kernel virtio driver

Hi all: There are hardwares that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and register itself as a new kind of mdev driver. Then it provides a unified way for kernel virtio driver

Hi all: There are hardwares that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and register itself as a new kind of mdev driver. Then it provides a unified way for kernel virtio driver