search for: operations_shorthand_vorbiscomment

...f(" type: %u (%s)\n", (unsigned)block->type, block->type < FLAC__METADATA_TYPE_UNDEFINED? FLAC__MetadataTypeString[block->type] : "UNKNOWN"); PPR; printf(" is last: %s\n", block->is_last? "true":"false"); diff --git a/src/metaflac/operations_shorthand_vorbiscomment.c b/src/metaflac/operations_shorthand_vorbiscomment.c index 3d381a5..19f9602 100644 --- a/src/metaflac/operations_shorthand_vorbiscomment.c +++ b/src/metaflac/operations_shorthand_vorbiscomment.c @@ -96,7 +96,11 @@ FLAC__bool do_shorthand_operation__vorbis_comment(const char *filename, FLAC__bo...

This is 1.3.1 on OpenBSD/amd64. The --no-utf8-convert option of metaflac(1) does not work for me: $ metaflac --no-utf8-convert --set-tag="Artist=?ou?l??ek" aladin.flac aladin.flac: ERROR: tag value for 'Artist' is not valid UTF-8 (You probably can't see the Czech letters properly in my mail, but that's beside the point.) Indeed, it is not valid UTF8 (it's LATIN2),

..._argv() that do some things and sets win_utf8_io_codepage to CP_UTF8 on success. This is the only way to set this flag to CP_UTF8. The programs continue to work only if get_utf8_argv() succeeds, so we know that win_utf8_io_codepage is always set to CP_UTF8. Actually, there's a code in metaflac/operations_shorthand_vorbiscomment.c and flac/vorbiscomment.c that won't work if get_utf8_argv() failed: ... #ifdef _WIN32 /* everything in UTF-8 already. Must not alter */ ... So, flac.exe calls get_utf8_argv(), then calls encode_file() which uses flac_fopen() itself, and then indirectly calls FLAC__stream_encoder_ini...

Brian Willoughby wrote: > Jan Stary wrote: >>> This is 1.3.1 on OpenBSD/amd64. >>> The --no-utf8-convert option of metaflac(1) does not work for me: ... >> The problem seems to be in >> src/metaflac/operations_shorthand_vorbiscomment.c >> in the set_vc_field() function. > By the way, I've never used FLAC inside Ogg Vorbis. > Instead, I use pure FLAC format files. Is there any > difference between the way this option works on a > straight FLAC file versus how it works on FLAC data > in an Ogg Vorbis con...

...properly in my mail, > but that's beside the point.) > > Indeed, it is not valid UTF8 (it's LATIN2), but isn't metaflac > supposed to just write it as specified, with this option? On Dec 06 09:54:55, hans at stare.cz wrote: > The problem seems to be in > src/metaflac/operations_shorthand_vorbiscomment.c > in the set_vc_field() function. > > It does check whether utf conversion is required, > > /* move 'data' into 'converted', converting to UTF-8 if necessary */ > if(raw) { > converted = data; > } > } > but later checks...

...LAC/metadata.h" #include <string.h> +#include "operations_shorthand.h" FLAC__bool do_shorthand_operation__streaminfo(const char *filename, FLAC__bool prefix_with_filename, FLAC__Metadata_Chain *chain, const Operation *operation, FLAC__bool *needs_write) { --- src/metaflac/operations_shorthand_vorbiscomment.c 2007-07-14 08:45:49 +0000 +++ src/metaflac/operations_shorthand_vorbiscomment.c 2007-07-15 01:18:12 +0000 @@ -28,6 +28,7 @@ #include <errno.h> #include <stdlib.h> #include <string.h> +#include "operations_shorthand.h" static FLAC__bool remove_vc_all(const char *f...

...f 'strerror' 10> Message: 'This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_DEPRECATE. See online help for details.' 10>operations_shorthand_seektable.c 10>operations_shorthand_streaminfo.c 10>operations_shorthand_vorbiscomment.c 10>c:\greenhouse\workspace\soundio\tool\flac_1.1.3\main\flac-1.1.3\src\metaflac\operations_shorthand_vorbiscomment.c(202) : warning C4996: 'fopen' was declared deprecated 10> c:\program files\microsoft visual studio 8\vc\include\stdio.h(234) : see declaration of 'fopen&...

...tions_shorthand.h | 6 +-- src/metaflac/operations_shorthand_cuesheet.c | 6 +-- src/metaflac/operations_shorthand_picture.c | 6 +-- src/metaflac/operations_shorthand_seektable.c | 6 +-- src/metaflac/operations_shorthand_streaminfo.c | 6 +-- src/metaflac/operations_shorthand_vorbiscomment.c | 6 +-- src/metaflac/options.c | 6 +-- src/metaflac/options.h | 6 +-- src/metaflac/usage.c | 12 +++--- src/metaflac/usage.h | 6 +-- src/metaflac/utils.c...