search for: opennativefile

...setting the executable bit on all source files it modifies when using the -i parameter. I spent some time troubleshooting this issue today, and I found that clang-format create a new temporary file, writes the formatted source into that file, then copies it over the old file. Deep in the bowels of openNativeFile in lib/Support/Windows/Path.inc, in openNativeFileInternal, CreateFileW is called with a SECURITY_ATTRIBUTES with lpSecurityDescriptor = nullptr. The result of this is you get a new file with the default permissions based on whatever NTFS decides to do. On my machine, this ends up being a file with...

...ault via cfe-dev > *Sent:* Monday, April 20, 2020 12:32 PM > *To:* Adrian McCarthy <amccarth at google.com> > *Cc:* LLVM Dev <llvm-dev at lists.llvm.org>; cfe-dev at lists.llvm.org > *Subject:* Re: [cfe-dev] [llvm-dev] clang-format sets executable > permission on windows (openNativeFile ignores mode on Windows) > > > > I’m using Cygwin to interact with the source tree. My sources (I’m working > on LLVM itself) were created by other developers (and by extension, created > by git.exe on my machine), but a quick expirement of trying “touch foo” > shows that Cygwi...

...From: Adrian McCarthy <amccarth at google.com> Sent: Monday, April 20, 2020 8:36 AM To: Chris Tetreault <ctetreau at quicinc.com> Cc: LLVM Dev <llvm-dev at lists.llvm.org>; cfe-dev at lists.llvm.org Subject: [EXT] Re: [llvm-dev] clang-format sets executable permission on windows (openNativeFile ignores mode on Windows) I don't claim to understand NTFS permissions fully, but this mostly sounds like a problem of how the NTFS permissions are presented as a Unix-style mode. When you create a new file without specifying explicit permissions (as most tools do), Windows (or NTFS) grants th...