Displaying 10 results from an estimated 10 matches for "opeint_".
2018 Mar 20
2
[PATCH] Support for Ambisonics
Just to confirm, I would use opeint_* for all the
OpusGenericEncoder-related functions?
On Tue, Mar 20, 2018 at 8:38 AM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote:
> Hi Mark, Drew,
>
> On 03/20/2018 02:40 AM, Mark Harris wrote:
> > + int _oge_use_projection(int channel_mapping);
> >
> > These func...
2018 Mar 20
2
[PATCH] Support for Ambisonics
Attached is an updated patch based on Jean-Marc and Mark's comments. :)
Cheers,
Drew
On Tue, Mar 20, 2018 at 9:20 AM Jean-Marc Valin <jmvalin at jmvalin.ca> wrote:
> On 03/20/2018 11:51 AM, Drew Allen wrote:
> > Just to confirm, I would use opeint_* for all the
> > OpusGenericEncoder-related functions?
>
> Correct. Or you can also use oge_ if you like. Just don't use something
> that starts with an underscore.
>
>
> > On Tue, Mar 20, 2018 at 8:38 AM Jean-Marc Valin <jmvalin at jmvalin.ca
> > <mailto:...
2018 Mar 22
2
[PATCH] Support for Ambisonics
...> > Cheers,
> > Drew
> >
> > On Tue, Mar 20, 2018 at 9:20 AM Jean-Marc Valin <jmvalin at jmvalin.ca
> > <mailto:jmvalin at jmvalin.ca>> wrote:
> >
> > On 03/20/2018 11:51 AM, Drew Allen wrote:
> > > Just to confirm, I would use opeint_* for all the
> > > OpusGenericEncoder-related functions?
> >
> > Correct. Or you can also use oge_ if you like. Just don't use
> something
> > that starts with an underscore.
> >
> >
> > > On Tue, Mar 20, 2018 at 8:38 AM Jean-Ma...
2018 Mar 26
3
[PATCH] Support for Ambisonics
...gt;
>>> > On Tue, Mar 20, 2018 at 9:20 AM Jean-Marc Valin <jmvalin at jmvalin.ca
>>> > <mailto:jmvalin at jmvalin.ca>> wrote:
>>> >
>>> > On 03/20/2018 11:51 AM, Drew Allen wrote:
>>> > > Just to confirm, I would use opeint_* for all the
>>> > > OpusGenericEncoder-related functions?
>>> >
>>> > Correct. Or you can also use oge_ if you like. Just don't use
>>> something
>>> > that starts with an underscore.
>>> >
>>> >
&g...
2018 Mar 20
0
[PATCH] Support for Ambisonics
On 03/20/2018 11:51 AM, Drew Allen wrote:
> Just to confirm, I would use opeint_* for all the
> OpusGenericEncoder-related functions?
Correct. Or you can also use oge_ if you like. Just don't use something
that starts with an underscore.
> On Tue, Mar 20, 2018 at 8:38 AM Jean-Marc Valin <jmvalin at jmvalin.ca
> <mailto:jmvalin at jmvalin.ca>> wrote:...
2018 Mar 22
0
[PATCH] Support for Ambisonics
...Marc and Mark's comments. :)
>
> Cheers,
> Drew
>
> On Tue, Mar 20, 2018 at 9:20 AM Jean-Marc Valin <jmvalin at jmvalin.ca
> <mailto:jmvalin at jmvalin.ca>> wrote:
>
> On 03/20/2018 11:51 AM, Drew Allen wrote:
> > Just to confirm, I would use opeint_* for all the
> > OpusGenericEncoder-related functions?
>
> Correct. Or you can also use oge_ if you like. Just don't use something
> that starts with an underscore.
>
>
> > On Tue, Mar 20, 2018 at 8:38 AM Jean-Marc Valin
> <jmvalin at jmva...
2018 Mar 26
0
[PATCH] Support for Ambisonics
...> Drew
>> >
>> > On Tue, Mar 20, 2018 at 9:20 AM Jean-Marc Valin <jmvalin at jmvalin.ca
>> > <mailto:jmvalin at jmvalin.ca>> wrote:
>> >
>> > On 03/20/2018 11:51 AM, Drew Allen wrote:
>> > > Just to confirm, I would use opeint_* for all the
>> > > OpusGenericEncoder-related functions?
>> >
>> > Correct. Or you can also use oge_ if you like. Just don't use
>> something
>> > that starts with an underscore.
>> >
>> >
>> > > On Tue,...
2018 Mar 20
2
[PATCH] Support for Ambisonics
Hi Drew,
Some comments on the libopusenc patch:
+ int _oge_use_projection(int channel_mapping);
These functions are part of libopusenc, so I'd expect them to have an
ope prefix like the other functions in the libopusenc library.
+ if (_oge_use_projection(h->channel_mapping))
+ {
+ len=27+(h->channels*(h->nb_streams+h->nb_coupled)*2);
+ }
+ else
+ {
+
2018 Jul 07
0
[PATCH] Support for Ambisonics
...;>> jmvalin at jmvalin.ca
>>>>>>> > <mailto:jmvalin at jmvalin.ca>> wrote:
>>>>>>> >
>>>>>>> > On 03/20/2018 11:51 AM, Drew Allen wrote:
>>>>>>> > > Just to confirm, I would use opeint_* for all the
>>>>>>> > > OpusGenericEncoder-related functions?
>>>>>>> >
>>>>>>> > Correct. Or you can also use oge_ if you like. Just don't use
>>>>>>> something
>>>>>>>...
2018 Mar 20
0
[PATCH] Support for Ambisonics
...like the other functions in the libopusenc library.
I'd like to avoid using the ope_ prefix for functions that's aren't in
the public API. Right now there are other functions with a leading
underscore, so we'll have to fix them as well (not in this patch of
course). Maybe an "opeint_" prefix would do the job here (unless anyone
has a better idea)?
> +int ope_encoder_deferred_init_with_mapping(OggOpusEnc *enc, int
> family, int streams,
> int coupled_streams, const unsigned char *mapping) {
> int ret;
> int i;
>
> This code is allowing fami...